LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-20 09:49:15 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibIDL: Fix accidental early return in resolve_typedef()

Browse Source 
This made sense before we had the next step to resolve union types, but
now we only need to skip transferring the extended attributes, without
returning just yet.
This commit is contained in:
Linus Groh 2022-11-10 19:14:37 +00:00
parent 4edcb660b9
commit d9cb7b6dc7
Notes: sideshowbarker 2024-07-18 03:35:30 +09:00 
Author: https://github.com/linusg
Commit: https://github.com/SerenityOS/serenity/commit/d9cb7b6dc7
Pull-request: https://github.com/SerenityOS/serenity/pull/16009
Reviewed-by: https://github.com/kennethmyhra ✅
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Userland/Libraries/LibIDL/IDLParser.cpp
View File

@ -831,10 +831,10 @@ static void resolve_typedef(Interface& interface, NonnullRefPtr<Type>& type, Has
bool nullable = type->is_nullable();
type = it->value.type;
type->set_nullable(nullable);
if (!extended_attributes)
return;
for (auto& attribute : it->value.extended_attributes)
extended_attributes->set(attribute.key, attribute.value);
if (extended_attributes) {
for (auto& attribute : it->value.extended_attributes)
extended_attributes->set(attribute.key, attribute.value);
}
// Recursively resolve typedefs in unions after we resolved the type itself - e.g. for this:
// typedef (A or B) Union1;