LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-20 01:37:39 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibVT: Fix integer overflow when parsing long OSC sequences

Browse Source 
We were storing indices into OSC escape sequences as `u8`s, which
overflow at a length of just 256 characters. This caused a crash when
parsing OSC 8 hyperlinks pointing to long filenames.
This commit is contained in:
Daniel Bertalan 2023-03-17 17:41:53 +01:00 committed by Linus Groh
parent 5d7a85bc37
commit e3195b060d
Notes: sideshowbarker 2024-07-16 23:54:15 +09:00 
Author: https://github.com/BertalanD
Commit: https://github.com/SerenityOS/serenity/commit/e3195b060d
Pull-request: https://github.com/SerenityOS/serenity/pull/17897
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Userland/Libraries/LibVT/EscapeSequenceParser.h
View File

@ -69,7 +69,7 @@ private:
Vector<unsigned, 4> m_param_vector;
unsigned m_param { 0 };
Vector<u8> m_osc_parameter_indexes;
Vector<size_t> m_osc_parameter_indexes;
Vector<u8, 16> m_osc_raw;
bool m_ignoring { false };