LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-21 18:37:58 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Remove Proxy() argument count check

Browse Source 
Let's just treat missing arguments as undefined and throw with
'target/handler must be object' - this is more JavaScript-y.
This commit is contained in:
Linus Groh 2021-06-08 21:46:45 +01:00 committed by Andreas Kling
parent 5ff85abe8c
commit e39dd65cf0
Notes: sideshowbarker 2024-07-18 12:36:18 +09:00 
Author: https://github.com/linusg
Commit: https://github.com/SerenityOS/serenity/commit/e39dd65cf03
Pull-request: https://github.com/SerenityOS/serenity/pull/7926
3 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Userland/Libraries/LibJS/Runtime/ErrorTypes.h
View File

@ -128,7 +128,6 @@
M(ProxySetPrototypeOfNonExtensible, "Proxy handler's setPrototypeOf trap violates " \
"invariant: the argument must match the prototype of the target if the " \
"target is non-extensible") \
M(ProxyTwoArguments, "Proxy constructor requires at least two arguments") \
M(ReduceNoInitial, "Reduce of empty array with no initial value") \
M(ReferenceNullishDeleteProperty, "Cannot delete property '{}' of {}") \
M(ReferenceNullishGetProperty, "Cannot get property '{}' of {}") \

5
Userland/Libraries/LibJS/Runtime/ProxyConstructor.cpp
View File

@ -38,11 +38,6 @@ Value ProxyConstructor::call()
Value ProxyConstructor::construct(Function&)
{
auto& vm = this->vm();
if (vm.argument_count() < 2) {
vm.throw_exception<TypeError>(global_object(), ErrorType::ProxyTwoArguments);
return {};
}
auto target = vm.argument(0);
auto handler = vm.argument(1);

10
Userland/Libraries/LibJS/Tests/builtins/Proxy/Proxy.js
View File

@ -7,11 +7,17 @@ test("constructs properly", () => {
test("constructor argument count", () => {
expect(() => {
new Proxy();
}).toThrowWithMessage(TypeError, "Proxy constructor requires at least two arguments");
}).toThrowWithMessage(
TypeError,
"Expected target argument of Proxy constructor to be object, got undefined"
);
expect(() => {
new Proxy({});
}).toThrowWithMessage(TypeError, "Proxy constructor requires at least two arguments");
}).toThrowWithMessage(
TypeError,
"Expected handler argument of Proxy constructor to be object, got undefined"
);
});
test("constructor requires objects", () => {