LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-11 13:36:13 +03:00
Code Issues Packages Projects Releases Wiki Activity

AK: Iterate the bytes of a URL query with an unsigned type

Browse Source 
Otherwise, we percent-encode negative signed chars incorrectly. For
example, https://www.strava.com/login contains the following hidden
<input> field:

    <input name="utf8" type="hidden" value="✓" />

On submitting the form, we would percent-encode that field as:

    utf8=%-1E%-64%-6D

Which would cause us to receive an HTTP 500 response. We now properly
percent-encode that field as:

    utf8=%E2%9C%93

And can login to Strava :^)
This commit is contained in:
Timothy Flynn 2024-03-10 09:42:48 -04:00 committed by Andreas Kling
parent dc47210360
commit e3b5e24ce0
Notes: sideshowbarker 2024-07-16 23:54:15 +09:00 
Author: https://github.com/trflynn89
Commit: https://github.com/SerenityOS/serenity/commit/e3b5e24ce0
Pull-request: https://github.com/SerenityOS/serenity/pull/23539
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
AK/URLParser.cpp
View File

@ -714,7 +714,7 @@ ErrorOr<String> URLParser::percent_encode_after_encoding(StringView input, URL::
StringBuilder output;
// 3. For each byte of encodeOutput converted to a byte sequence:
for (auto byte : input) {
for (u8 byte : input) {
// 1. If spaceAsPlus is true and byte is 0x20 (SP), then append U+002B (+) to output and continue.
if (space_as_plus && byte == ' ') {
output.append('+');

9
Tests/AK/TestURL.cpp
View File

@ -438,6 +438,15 @@ TEST_CASE(unicode)
EXPECT(!url.fragment().has_value());
}
TEST_CASE(query_with_non_ascii)
{
URL url { "http://example.com/?utf8=✓"sv };
EXPECT(url.is_valid());
EXPECT_EQ(url.serialize_path(), "/"sv);
EXPECT_EQ(url.query(), "utf8=%E2%9C%93");
EXPECT(!url.fragment().has_value());
}
TEST_CASE(complete_file_url_with_base)
{
URL url { "file:///home/index.html" };