LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-13 01:59:14 +03:00
Code Issues Packages Projects Releases Wiki Activity

HexEditor: Add ASCII to the value inspector

Browse Source 
This is kind of redundant but probably easier to read than the ASCII
column. Also, it seems appropriate after we add other character
encodings.
This commit is contained in:
kleines Filmröllchen 2022-04-12 18:59:23 +02:00 committed by Linus Groh
parent da7a8a8711
commit e5736cdf2f
Notes: sideshowbarker 2024-07-17 11:30:40 +09:00 
Author: https://github.com/kleinesfilmroellchen
Commit: https://github.com/SerenityOS/serenity/commit/e5736cdf2f
Pull-request: https://github.com/SerenityOS/serenity/pull/13640
Reviewed-by: https://github.com/alimpfard
Reviewed-by: https://github.com/gmta
Reviewed-by: https://github.com/linusg
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Userland/Applications/HexEditor/HexEditorWidget.cpp
View File

@ -285,9 +285,11 @@ void HexEditorWidget::update_inspector_values(size_t position)
value_inspector_model->set_parsed_value(ValueInspectorModel::ValueType::SignedByte, String::number(static_cast<i8>(unsigned_byte_value)));
value_inspector_model->set_parsed_value(ValueInspectorModel::ValueType::UnsignedByte, String::number(unsigned_byte_value));
value_inspector_model->set_parsed_value(ValueInspectorModel::ValueType::ASCII, String::formatted("{:c}", static_cast<char>(unsigned_byte_value)));
} else {
value_inspector_model->set_parsed_value(ValueInspectorModel::ValueType::SignedByte, "");
value_inspector_model->set_parsed_value(ValueInspectorModel::ValueType::UnsignedByte, "");
value_inspector_model->set_parsed_value(ValueInspectorModel::ValueType::ASCII, "");
}
if (byte_read_count >= 2) {

4
Userland/Applications/HexEditor/ValueInspectorModel.h
View File

@ -26,6 +26,7 @@ public:
UnsignedLong,
Float,
Double,
ASCII,
__Count
};
@ -90,6 +91,8 @@ public:
return "Float";
case Double:
return "Double";
case ASCII:
return "ASCII";
default:
return "";
}
@ -112,6 +115,7 @@ public:
switch (selected_type) {
case SignedByte:
case UnsignedByte:
case ASCII:
return 1;
case SignedShort:
case UnsignedShort: