LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-18 16:57:29 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Allow progress element value to be set higher than the max value

Browse Source 
Previously, we returned from the value setter if the specified value
was above the max value. This is not required, as the getter clamps the
returned value to the max value.
This commit is contained in:
Tim Ledbetter 2024-03-18 06:13:01 +00:00 committed by Andreas Kling
parent e795c24fdd
commit ecbc686bc8
Notes: sideshowbarker 2024-07-18 00:34:07 +09:00 
Author: https://github.com/tcl3
Commit: https://github.com/SerenityOS/serenity/commit/ecbc686bc8
Pull-request: https://github.com/SerenityOS/serenity/pull/23624
3 changed files with 29 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Tests/LibWeb/Text/expected/HTML/HTMLProgressElement-set-attributes.txt Normal file
View File

@ -0,0 +1,8 @@
value attribute initial value: 0
max attribute initial value: 1
value attribute after setting value attribute to -1: 0
max attribute after setting max attribute to -1: 1
value attribute after setting value attribute to 50: 1
value attribute after setting max attribute to 100: 50
max attribute after setting max attribute to 100: 100
value attribute after setting max attribute to 101: 100

20
Tests/LibWeb/Text/input/HTML/HTMLProgressElement-set-attributes.html Normal file
View File

@ -0,0 +1,20 @@
<!DOCTYPE html>
<script src="../include.js"></script>
<script>
test(() => {
const progressElement = document.createElement("progress");
println(`value attribute initial value: ${progressElement.value}`);
println(`max attribute initial value: ${progressElement.max}`);
progressElement.value = -1;
println(`value attribute after setting value attribute to -1: ${progressElement.value}`);
progressElement.max = -1;
println(`max attribute after setting max attribute to -1: ${progressElement.max}`);
progressElement.value = 50;
println(`value attribute after setting value attribute to 50: ${progressElement.value}`);
progressElement.max = 100;
println(`value attribute after setting max attribute to 100: ${progressElement.value}`);
println(`max attribute after setting max attribute to 100: ${progressElement.max}`);
progressElement.value = 101;
println(`value attribute after setting max attribute to 101: ${progressElement.value}`);
});
</script>

2
Userland/Libraries/LibWeb/HTML/HTMLProgressElement.cpp
View File

@ -48,7 +48,7 @@ double HTMLProgressElement::value() const
WebIDL::ExceptionOr<void> HTMLProgressElement::set_value(double value)
{
if (value < 0 || value > max())
if (value < 0)
return {};
TRY(set_attribute(HTML::AttributeNames::value, MUST(String::number(value))));