LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-26 20:55:35 +03:00
Code Issues Packages Projects Releases Wiki Activity

AK: Use __has_builtin() in Checked.h

Browse Source 
Instead of avoiding overflow-checking builtins with AK_COMPILER_CLANG,
we can use the preprocessor's __has_builtin() mechanism to check if
they are available.
This commit is contained in:
Andreas Kling 2022-12-17 20:09:21 +01:00 committed by Tim Flynn
parent c4bc889346
commit f11e6beca8
Notes: sideshowbarker 2024-07-17 04:21:32 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/f11e6beca8
Pull-request: https://github.com/SerenityOS/serenity/pull/16586
Reviewed-by: https://github.com/trflynn89 ✅
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
AK/Checked.h
View File

@ -328,26 +328,26 @@ public:
template<typename U, typename V>
[[nodiscard]] static constexpr bool addition_would_overflow(U u, V v)
{
#if defined(AK_COMPILER_CLANG)
#if __has_builtin(__builtin_add_overflow_p)
return __builtin_add_overflow_p(u, v, (T)0);
#else
Checked checked;
checked = u;
checked += v;
return checked.has_overflow();
#else
return __builtin_add_overflow_p(u, v, (T)0);
#endif
}
template<typename U, typename V>
[[nodiscard]] static constexpr bool multiplication_would_overflow(U u, V v)
{
#if defined(AK_COMPILER_CLANG)
#if __has_builtin(__builtin_mul_overflow_p)
return __builtin_mul_overflow_p(u, v, (T)0);
#else
Checked checked;
checked = u;
checked *= v;
return checked.has_overflow();
#else
return __builtin_mul_overflow_p(u, v, (T)0);
#endif
}