LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-01-04 01:05:58 +03:00
Code Issues Packages Projects Releases Wiki Activity

Shell: Don't blindly dereference the result of Parser::parse()

Browse Source 
It _may_ return nullptr if there's nothing to return.
Fixes #5691.
This commit is contained in:
AnotherTest 2021-03-08 10:59:32 +03:30 committed by Andreas Kling
parent 26c4cae77c
commit fb68aa1480
Notes: sideshowbarker 2024-07-18 21:37:37 +09:00 
Author: https://github.com/alimpfard
Commit: https://github.com/SerenityOS/serenity/commit/fb68aa1480d
Pull-request: https://github.com/SerenityOS/serenity/pull/5693
Issue: https://github.com/SerenityOS/serenity/issues/5691
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Userland/Shell/Shell.cpp
View File

@ -1582,7 +1582,11 @@ bool Shell::has_history_event(StringView source)
bool has_history_event { false };
} visitor;
Parser { source, true }.parse()->visit(visitor);
auto ast = Parser { source, true }.parse();
if (!ast)
return false;
ast->visit(visitor);
return visitor.has_history_event;
}