LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-20 09:49:15 +03:00
Code Issues Packages Projects Releases Wiki Activity

DynamicLoader: Stop performing relative relocations on non-pie objects

Browse Source 
Co-authored-by: Daniel Bertalan <dani@danielbertalan.dev>
This commit is contained in:
Idan Horowitz 2022-07-10 03:13:11 +03:00 committed by Andreas Kling
parent b700d1a474
commit fbeef409c6
Notes: sideshowbarker 2024-07-17 09:32:40 +09:00 
Author: https://github.com/IdanHo
Commit: https://github.com/SerenityOS/serenity/commit/fbeef409c6
Pull-request: https://github.com/SerenityOS/serenity/pull/14533
Reviewed-by: https://github.com/linusg ✅
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Userland/Libraries/LibELF/DynamicLoader.cpp
View File

@ -557,6 +557,8 @@ DynamicLoader::RelocationResult DynamicLoader::do_relocation(const ELF::DynamicO
#else
case R_X86_64_RELATIVE: {
#endif
if (!image().is_dynamic())
break;
// FIXME: According to the spec, R_386_relative ones must be done first.
// We could explicitly do them first using m_number_of_relocations from DT_RELCOUNT
// However, our compiler is nice enough to put them at the front of the relocations for us :)