LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-21 10:19:03 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Accept symbol property in ObjectPrototype::hasOwnProperty

Browse Source 
This is used by discord.com and allowed by the specification
(https://tc39.es/ecma262/#sec-topropertykey)
This commit is contained in:
Idan Horowitz 2021-04-16 01:33:12 +03:00 committed by Linus Groh
parent 2381b19719
commit fff7aceb9d
Notes: sideshowbarker 2024-07-18 20:15:40 +09:00 
Author: https://github.com/IdanHo
Commit: https://github.com/SerenityOS/serenity/commit/fff7aceb9dc
Pull-request: https://github.com/SerenityOS/serenity/pull/6364
Reviewed-by: https://github.com/linusg
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Userland/Libraries/LibJS/Runtime/ObjectPrototype.cpp
View File

@ -66,10 +66,10 @@ JS_DEFINE_NATIVE_FUNCTION(ObjectPrototype::has_own_property)
auto* this_object = vm.this_value(global_object).to_object(global_object);
if (!this_object)
return {};
auto name = vm.argument(0).to_string(global_object);
auto string_or_symbol = StringOrSymbol::from_value(global_object, vm.argument(0));
if (vm.exception())
return {};
return Value(this_object->has_own_property(name));
return Value(this_object->has_own_property(string_or_symbol));
}
JS_DEFINE_NATIVE_FUNCTION(ObjectPrototype::to_string)

5
Userland/Libraries/LibJS/Tests/builtins/Object/Object.prototype.hasOwnProperty.js
View File

@ -10,4 +10,9 @@ test("basic functionality", () => {
o.undefined = 2;
expect(o.hasOwnProperty()).toBeTrue();
expect(o.hasOwnProperty(undefined)).toBeTrue();
var testSymbol = Symbol("real");
o[testSymbol] = 3;
expect(o.hasOwnProperty(testSymbol)).toBeTrue();
expect(o.hasOwnProperty(Symbol("fake"))).toBeFalse();
});