mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2024-09-19 09:17:38 +03:00
5cf1570f40
Previously, we were handling viewBoxes/viewports in a slightly hacky way, asking graphics elements to figure out what viewBox to use during layout. This does not work in all cases, and can't allow for more complex SVGs where it is possible to have nested viewports. This commit makes the SVGFormattingContext keep track of the viewport/boxes, and it now lays out each viewport recursively, where each nested `<svg>` or `<symbol>` can establish a new viewport. This fixes some previous edge cases, and starts to allow nested viewports (there's still some issues to resolve there). Fixes #22931
46 lines
1.2 KiB
C++
46 lines
1.2 KiB
C++
/*
|
|
* Copyright (c) 2023, Preston Taylor <95388976+PrestonLTaylor@users.noreply.github.com>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <LibWeb/SVG/SVGGraphicsElement.h>
|
|
#include <LibWeb/SVG/SVGViewport.h>
|
|
|
|
namespace Web::SVG {
|
|
|
|
class SVGSymbolElement final : public SVGGraphicsElement
|
|
, public SVGViewport {
|
|
WEB_PLATFORM_OBJECT(SVGSymbolElement, SVGGraphicsElement);
|
|
JS_DECLARE_ALLOCATOR(SVGSymbolElement);
|
|
|
|
public:
|
|
virtual ~SVGSymbolElement() override = default;
|
|
|
|
void apply_presentational_hints(CSS::StyleProperties& style) const override;
|
|
|
|
virtual Optional<ViewBox> view_box() const override { return m_view_box; }
|
|
virtual Optional<PreserveAspectRatio> preserve_aspect_ratio() const override
|
|
{
|
|
// FIXME: Support the `preserveAspectRatio` attribute on <symbol>.
|
|
return {};
|
|
}
|
|
|
|
private:
|
|
SVGSymbolElement(DOM::Document&, DOM::QualifiedName);
|
|
|
|
virtual void initialize(JS::Realm&) override;
|
|
|
|
virtual JS::GCPtr<Layout::Node> create_layout_node(NonnullRefPtr<CSS::StyleProperties>) override;
|
|
|
|
bool is_direct_child_of_use_shadow_tree() const;
|
|
|
|
virtual void attribute_changed(FlyString const& name, Optional<String> const& value) override;
|
|
|
|
Optional<ViewBox> m_view_box;
|
|
};
|
|
|
|
}
|