Andrew Kaster e687e5ba74 LibCrypt: Link the SHA2 hash implementation into LibCrypt privately ... Previously, we linked LibCrypt against LibCrypto. This creates a circular symbol dependency between LibCore, LibCrypto and LibCrypt. LibCrypto uses Core::DateTime, LibCrypt uses Crypto::SHA2, and LibCore uses crypt in Core::Account. The GNU toolchain massages the DT_NEEDED lines of each library and applications that use each library such that the Loader finds all the symbols as necessary. However, when using the Clang toolchain, the circular library dependency is not as tolerated. We get a symbol not found error in the Loader at runtime, and the app in question crashes. Now, we build the SHA2.cpp implementation file into LibCrypt using an object library and `-fvisibility=hidden -fvisibility-hidden-inlines`. This adds the implementation in a way that only creates STB_LOCAL symbols and should avoid nasty ODR problems in the future. An alternative approach to resolving this dependency would be to move Core::DateTime to AK, or to make Crypto::ASN1::parse_utc_date return a struct tm instead of a Core::DateTime. One of those approaches to remove the LibCore dependency from LibCrypto should probabably be investigated further in the future. The net effect of removing this circular library dependency is that one can now build and run the python3 port with the Clang toolchain :^)		2022-01-08 18:56:29 +01:00
..
CMakeLists.txt	LibCrypt: Link the SHA2 hash implementation into LibCrypt privately	2022-01-08 18:56:29 +01:00
crypt.cpp	Everywhere: Use my cool new @serenityos.org email address	2021-09-01 11:37:25 +04:30
crypt.h	LibC: Move crypt() and crypt_r() to the right header file	2021-05-01 12:40:12 +02:00