mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2024-12-28 05:35:52 +03:00
b4fbd30b70
This change was a long time in the making ever since we obtained sample rate awareness in the system. Now, each client has its own sample rate, accessible via new IPC APIs, and the device sample rate is only accessible via the management interface. AudioServer takes care of resampling client streams into the device sample rate. Therefore, the main improvement introduced with this commit is full responsiveness to sample rate changes; all open audio programs will continue to play at correct speed with the audio resampled to the new device rate. The immediate benefits are manifold: - Gets rid of the legacy hardware sample rate IPC message in the non-managing client - Removes duplicate resampling and sample index rescaling code everywhere - Avoids potential sample index scaling bugs in SoundPlayer (which have happened many times before) and fixes a sample index scaling bug in aplay - Removes several FIXMEs - Reduces amount of sample copying in all applications (especially Piano, where this is critical), improving performance - Reduces number of resampling users, making future API changes (which will need to happen for correct resampling to be implemented) easier I also threw in a simple race condition fix for Piano's audio player loop.
163 lines
5.9 KiB
C++
163 lines
5.9 KiB
C++
/*
|
|
* Copyright (c) 2021, kleines Filmröllchen <filmroellchen@serenityos.org>
|
|
* Copyright (c) 2021, JJ Roberts-White <computerfido@gmail.com>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include "AudioPlayerLoop.h"
|
|
#include "Music.h"
|
|
#include "TrackManager.h"
|
|
#include <AK/Assertions.h>
|
|
#include <AK/FixedArray.h>
|
|
#include <AK/Forward.h>
|
|
#include <AK/NonnullOwnPtr.h>
|
|
#include <AK/NumericLimits.h>
|
|
#include <AK/StdLibExtras.h>
|
|
#include <AK/Time.h>
|
|
#include <LibAudio/ConnectionToServer.h>
|
|
#include <LibAudio/Queue.h>
|
|
#include <LibAudio/Sample.h>
|
|
#include <LibIPC/Connection.h>
|
|
#include <LibThreading/Thread.h>
|
|
#include <sched.h>
|
|
#include <time.h>
|
|
|
|
struct AudioLoopDeferredInvoker final : public IPC::DeferredInvoker {
|
|
static constexpr size_t INLINE_FUNCTIONS = 4;
|
|
|
|
virtual ~AudioLoopDeferredInvoker() = default;
|
|
|
|
virtual void schedule(Function<void()> function) override
|
|
{
|
|
deferred_functions.append(move(function));
|
|
}
|
|
|
|
void run_functions()
|
|
{
|
|
if (deferred_functions.size() > INLINE_FUNCTIONS)
|
|
dbgln("Warning: Audio loop has more than {} deferred functions, audio might glitch!", INLINE_FUNCTIONS);
|
|
while (!deferred_functions.is_empty()) {
|
|
auto function = deferred_functions.take_last();
|
|
function();
|
|
}
|
|
}
|
|
|
|
Vector<Function<void()>, INLINE_FUNCTIONS> deferred_functions;
|
|
};
|
|
|
|
AudioPlayerLoop::AudioPlayerLoop(TrackManager& track_manager, Atomic<bool>& need_to_write_wav, Atomic<int>& wav_percent_written, Threading::MutexProtected<Audio::WavWriter>& wav_writer)
|
|
: m_track_manager(track_manager)
|
|
, m_buffer(FixedArray<DSP::Sample>::must_create_but_fixme_should_propagate_errors(sample_count))
|
|
, m_pipeline_thread(Threading::Thread::construct([this]() {
|
|
return this->pipeline_thread_main();
|
|
},
|
|
"Audio pipeline"sv))
|
|
, m_need_to_write_wav(need_to_write_wav)
|
|
, m_wav_percent_written(wav_percent_written)
|
|
, m_wav_writer(wav_writer)
|
|
{
|
|
m_audio_client = Audio::ConnectionToServer::try_create().release_value_but_fixme_should_propagate_errors();
|
|
m_audio_client->set_self_sample_rate(sample_rate);
|
|
|
|
MUST(m_pipeline_thread->set_priority(sched_get_priority_max(0)));
|
|
m_pipeline_thread->start();
|
|
}
|
|
|
|
AudioPlayerLoop::~AudioPlayerLoop()
|
|
{
|
|
// Tell the pipeline to exit and wait for the last audio cycle to finish.
|
|
m_exit_requested.store(true);
|
|
auto result = m_pipeline_thread->join();
|
|
// FIXME: Get rid of the EINVAL/ESRCH check once we allow to join dead threads.
|
|
VERIFY(!result.is_error() || result.error() == EINVAL || result.error() == ESRCH);
|
|
|
|
m_audio_client->shutdown();
|
|
}
|
|
|
|
intptr_t AudioPlayerLoop::pipeline_thread_main()
|
|
{
|
|
m_audio_client->set_deferred_invoker(make<AudioLoopDeferredInvoker>());
|
|
auto& deferred_invoker = static_cast<AudioLoopDeferredInvoker&>(m_audio_client->deferred_invoker());
|
|
|
|
m_audio_client->async_start_playback();
|
|
|
|
while (!m_exit_requested.load()) {
|
|
deferred_invoker.run_functions();
|
|
|
|
// The track manager guards against allocations itself.
|
|
m_track_manager.fill_buffer(m_buffer);
|
|
|
|
// Tolerate errors in the audio pipeline; we don't want this thread to crash the program. This might likely happen with OOM.
|
|
if (auto result = send_audio_to_server(); result.is_error()) [[unlikely]] {
|
|
dbgln("Error in audio pipeline: {}", result.error());
|
|
m_track_manager.reset();
|
|
}
|
|
|
|
if (auto result = write_wav_if_needed(); result.is_error()) [[unlikely]]
|
|
dbgln("Error writing WAV: {}", result.error());
|
|
}
|
|
m_audio_client->async_pause_playback();
|
|
return static_cast<intptr_t>(0);
|
|
}
|
|
|
|
ErrorOr<void> AudioPlayerLoop::send_audio_to_server()
|
|
{
|
|
auto buffer_play_time_ns = 1'000'000'000.0 / (sample_rate / static_cast<double>(Audio::AUDIO_BUFFER_SIZE));
|
|
auto good_sleep_time = Duration::from_nanoseconds(static_cast<unsigned>(buffer_play_time_ns)).to_timespec();
|
|
|
|
size_t start_of_chunk_to_write = 0;
|
|
while (start_of_chunk_to_write + Audio::AUDIO_BUFFER_SIZE <= m_buffer.size()) {
|
|
auto const exact_chunk = m_buffer.span().slice(start_of_chunk_to_write, Audio::AUDIO_BUFFER_SIZE);
|
|
auto exact_chunk_array = Array<Audio::Sample, Audio::AUDIO_BUFFER_SIZE>::from_span(exact_chunk);
|
|
|
|
TRY(m_audio_client->blocking_realtime_enqueue(exact_chunk_array, [&]() {
|
|
nanosleep(&good_sleep_time, nullptr);
|
|
}));
|
|
|
|
start_of_chunk_to_write += Audio::AUDIO_BUFFER_SIZE;
|
|
}
|
|
// The buffer has to have been constructed with a size of an integer multiple of the audio buffer size.
|
|
VERIFY(start_of_chunk_to_write == m_buffer.size());
|
|
|
|
return {};
|
|
}
|
|
|
|
ErrorOr<void> AudioPlayerLoop::write_wav_if_needed()
|
|
{
|
|
bool _true = true;
|
|
if (m_need_to_write_wav.compare_exchange_strong(_true, false)) {
|
|
m_audio_client->async_pause_playback();
|
|
TRY(m_wav_writer.with_locked([this](auto& wav_writer) -> ErrorOr<void> {
|
|
m_track_manager.reset();
|
|
m_track_manager.set_should_loop(false);
|
|
do {
|
|
// FIXME: This progress detection is crude, but it works for now.
|
|
m_wav_percent_written.store(static_cast<int>(static_cast<float>(m_track_manager.transport()->time()) / roll_length * 100.0f));
|
|
m_track_manager.fill_buffer(m_buffer);
|
|
TRY(wav_writer.write_samples(m_buffer.span()));
|
|
} while (m_track_manager.transport()->time());
|
|
// FIXME: Make sure that the new TrackManager APIs aren't as bad.
|
|
m_wav_percent_written.store(100);
|
|
m_track_manager.reset();
|
|
m_track_manager.set_should_loop(true);
|
|
wav_writer.finalize();
|
|
|
|
return {};
|
|
}));
|
|
m_audio_client->async_start_playback();
|
|
}
|
|
|
|
return {};
|
|
}
|
|
|
|
void AudioPlayerLoop::toggle_paused()
|
|
{
|
|
m_should_play_audio = !m_should_play_audio;
|
|
|
|
if (m_should_play_audio)
|
|
m_audio_client->async_start_playback();
|
|
else
|
|
m_audio_client->async_pause_playback();
|
|
}
|