ladybird/Tests/AK/TestNonnullOwnPtr.cpp
Andreas Kling b7e847e58b AK: Fix crash during teardown of self-owning objects
We now null out smart pointers *before* calling unref on the pointee.
This ensures that the same smart pointer can't be used to acquire a new
reference to the pointee after its destruction has begun.

I ran into this when destroying a non-empty IntrusiveList of RefPtrs,
but the problem was more general so this fixes it for all of RefPtr,
NonnullRefPtr, OwnPtr and NonnullOwnPtr.
2023-04-21 18:15:00 +02:00

35 lines
941 B
C++

/*
* Copyright (c) 2018-2023, Andreas Kling <kling@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <LibTest/TestCase.h>
#include <AK/DeprecatedString.h>
#include <AK/NonnullOwnPtr.h>
#include <AK/OwnPtr.h>
TEST_CASE(destroy_self_owning_object)
{
// This test is a little convoluted because SelfOwning can't own itself
// through a NonnullOwnPtr directly. We have to use an intermediate object ("Inner").
struct SelfOwning {
SelfOwning()
{
}
struct Inner {
explicit Inner(NonnullOwnPtr<SelfOwning> self)
: self(move(self))
{
}
NonnullOwnPtr<SelfOwning> self;
};
OwnPtr<Inner> inner;
};
OwnPtr<SelfOwning> object = make<SelfOwning>();
auto* object_ptr = object.ptr();
object_ptr->inner = make<SelfOwning::Inner>(object.release_nonnull());
object_ptr->inner = nullptr;
}