LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-11 05:25:32 +03:00
Code Issues Packages Projects Releases Wiki Activity
3e659b10f0
ladybird/Ladybird/Qt
History
Timothy Flynn 3e659b10f0 Ladybird/Qt: Reference the correct tab when handling the audio icon 
We were errantly always referring to the active tab when the audio play
state changed, and when clicking a tab's audio state button, by way of
BrowserWindow::view().

It turns out we also can't copy / rely on the tab index provided to the
signal in any asynchronous context. If the tabs are rearranged, so are
their indices. Instead, capture a pointer to the tab of interest - this
should be safe as we wouldn't be able to click a tab's audio button if
that tab no longer exists.

With this change, we can click the audio button from any tab in the Qt
chrome, and re-arrange tabs at will. The AppKit and Serenity chromes do
not have this issue.
2024-03-31 14:29:17 +02:00
..
AudioCodecPluginQt.cpp
AudioCodecPluginQt.h
AudioThread.cpp
AudioThread.h
AutoComplete.cpp AK+LibURL: Move AK::URL into a new URL library 2024-03-18 14:06:28 -04:00
AutoComplete.h Ladybird/Qt: Make String allocation infallible 2023-12-04 12:03:48 -07:00
BrowserWindow.cpp Ladybird/Qt: Reference the correct tab when handling the audio icon 2024-03-31 14:29:17 +02:00
BrowserWindow.h Ladybird/Qt: Reference the correct tab when handling the audio icon 2024-03-31 14:29:17 +02:00
EventLoopImplementationQt.cpp Ladybird/Qt: Use a precise timer for event loop timer events 2024-02-26 16:12:20 -07:00
EventLoopImplementationQt.h LibCore+Ladybird: Don't force timer ids to be integer just to remap them 2024-02-25 17:24:36 -07:00
EventLoopImplementationQtEventTarget.cpp
EventLoopImplementationQtEventTarget.h
Icon.cpp Ladybird: Load all icons uses Core::Resource URIs 2023-11-06 09:39:59 +01:00
Icon.h Ladybird: Load all icons uses Core::Resource URIs 2023-11-06 09:39:59 +01:00
InspectorWidget.cpp Ladybird/Qt: Adjust the Inspector context menu by the device pixel ratio 2024-03-11 16:49:20 +01:00
InspectorWidget.h Ladybird/Qt: Adjust the Inspector context menu by the device pixel ratio 2024-03-11 16:49:20 +01:00
ladybird.qrc
LocationEdit.cpp AK+LibURL: Move AK::URL into a new URL library 2024-03-18 14:06:28 -04:00
LocationEdit.h Ladybird: Add autocomplete to LocationEdit 2023-08-17 15:30:23 +01:00
main.cpp AK+LibURL: Move AK::URL into a new URL library 2024-03-18 14:06:28 -04:00
RequestManagerQt.cpp AK+LibURL: Move AK::URL into a new URL library 2024-03-18 14:06:28 -04:00
RequestManagerQt.h AK+LibURL: Move AK::URL into a new URL library 2024-03-18 14:06:28 -04:00
Settings.cpp Ladybird+BrowserSettings: Load the NTP/home resource files with LibWeb 2023-12-24 14:09:23 +01:00
Settings.h Everywhere: Rename {Deprecated => Byte}String 2023-12-17 18:25:10 +03:30
SettingsDialog.cpp AK+LibURL: Move AK::URL into a new URL library 2024-03-18 14:06:28 -04:00
SettingsDialog.h Ladybird/Qt: Do not "share" ownership of Qt objects 2023-12-04 12:03:48 -07:00
StringUtils.cpp AK+LibURL: Move AK::URL into a new URL library 2024-03-18 14:06:28 -04:00
StringUtils.h AK+LibURL: Move AK::URL into a new URL library 2024-03-18 14:06:28 -04:00
Tab.cpp Ladybird: Reset the default favicon when starting a new page load 2024-03-29 08:52:01 -04:00
Tab.h Ladybird/Qt: Implement history state change mechanics 2024-03-29 08:52:01 -04:00
TVGIconEngine.cpp
TVGIconEngine.h
WebContentView.cpp Ladybird/Qt: Allow CR inside of elements title attributes 2024-03-13 07:58:36 -04:00
WebContentView.h AK+LibURL: Move AK::URL into a new URL library 2024-03-18 14:06:28 -04:00
WebSocketImplQt.cpp Everywhere: Rename {Deprecated => Byte}String 2023-12-17 18:25:10 +03:30
WebSocketImplQt.h Everywhere: Rename {Deprecated => Byte}String 2023-12-17 18:25:10 +03:30
WebSocketQt.cpp Everywhere: Rename {Deprecated => Byte}String 2023-12-17 18:25:10 +03:30
WebSocketQt.h Everywhere: Rename {Deprecated => Byte}String 2023-12-17 18:25:10 +03:30