mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2024-11-11 01:06:01 +03:00
6704961c82
This removes the awkward String::replace API which was the only String API which mutated the String and replaces it with a new immutable version that returns a new String with the replacements applied. This also fixes a couple of UAFs that were caused by the use of this API. As an optimization an equivalent StringView::replace API was also added to remove an unnecessary String allocations in the format of: `String { view }.replace(...);`
153 lines
4.6 KiB
C++
153 lines
4.6 KiB
C++
/*
|
|
* Copyright (c) 2021, the SerenityOS developers.
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include "GoToOffsetDialog.h"
|
|
#include <AK/String.h>
|
|
#include <Applications/HexEditor/GoToOffsetDialogGML.h>
|
|
#include <LibGUI/BoxLayout.h>
|
|
#include <LibGUI/Button.h>
|
|
#include <LibGUI/ComboBox.h>
|
|
#include <LibGUI/ItemListModel.h>
|
|
#include <LibGUI/Label.h>
|
|
#include <LibGUI/MessageBox.h>
|
|
#include <LibGUI/Statusbar.h>
|
|
#include <LibGUI/TextBox.h>
|
|
#include <LibGUI/Widget.h>
|
|
|
|
int GoToOffsetDialog::show(GUI::Window* parent_window, int& history_offset, int& out_offset, int selection_offset, int buffer_size)
|
|
{
|
|
auto dialog = GoToOffsetDialog::construct();
|
|
dialog->m_selection_offset = selection_offset;
|
|
dialog->m_buffer_size = buffer_size;
|
|
|
|
if (parent_window)
|
|
dialog->set_icon(parent_window->icon());
|
|
|
|
if (history_offset)
|
|
dialog->m_text_editor->set_text(String::formatted("{}", history_offset));
|
|
|
|
auto result = dialog->exec();
|
|
|
|
if (result != GUI::Dialog::ExecOK)
|
|
return result;
|
|
|
|
auto input_offset = dialog->process_input();
|
|
history_offset = move(input_offset);
|
|
|
|
auto new_offset = dialog->calculate_new_offset(input_offset);
|
|
dbgln("Go to offset: value={}", new_offset);
|
|
out_offset = move(new_offset);
|
|
|
|
return GUI::Dialog::ExecOK;
|
|
}
|
|
|
|
int GoToOffsetDialog::process_input()
|
|
{
|
|
auto input_offset = m_text_editor->text().trim_whitespace();
|
|
int offset;
|
|
auto type = m_offset_type_box->text().trim_whitespace();
|
|
if (type == "Decimal") {
|
|
offset = String::formatted("{}", input_offset).to_int().value_or(0);
|
|
} else if (type == "Hexadecimal") {
|
|
offset = strtol(String::formatted("{}", input_offset).characters(), nullptr, 16);
|
|
} else {
|
|
VERIFY_NOT_REACHED();
|
|
}
|
|
return offset;
|
|
}
|
|
|
|
int GoToOffsetDialog::calculate_new_offset(int input_offset)
|
|
{
|
|
int new_offset;
|
|
auto from = m_offset_from_box->text().trim_whitespace();
|
|
if (from == "Start") {
|
|
new_offset = input_offset;
|
|
} else if (from == "End") {
|
|
new_offset = m_buffer_size - input_offset;
|
|
} else if (from == "Here") {
|
|
new_offset = input_offset + m_selection_offset;
|
|
} else {
|
|
VERIFY_NOT_REACHED();
|
|
}
|
|
|
|
if (new_offset > m_buffer_size)
|
|
new_offset = m_buffer_size;
|
|
if (new_offset < 0)
|
|
new_offset = 0;
|
|
|
|
return new_offset;
|
|
}
|
|
|
|
void GoToOffsetDialog::update_statusbar()
|
|
{
|
|
auto new_offset = calculate_new_offset(process_input());
|
|
m_statusbar->set_text(0, String::formatted("HEX: {:#08X}", new_offset));
|
|
m_statusbar->set_text(1, String::formatted("DEC: {}", new_offset));
|
|
}
|
|
|
|
GoToOffsetDialog::GoToOffsetDialog()
|
|
: Dialog(nullptr)
|
|
{
|
|
resize(300, 80);
|
|
center_on_screen();
|
|
set_resizable(false);
|
|
set_title("Go to Offset");
|
|
|
|
auto& main_widget = set_main_widget<GUI::Widget>();
|
|
if (!main_widget.load_from_gml(go_to_offset_dialog_gml))
|
|
VERIFY_NOT_REACHED();
|
|
|
|
m_text_editor = *main_widget.find_descendant_of_type_named<GUI::TextBox>("text_editor");
|
|
m_go_button = *main_widget.find_descendant_of_type_named<GUI::Button>("go_button");
|
|
m_offset_type_box = *main_widget.find_descendant_of_type_named<GUI::ComboBox>("offset_type");
|
|
m_offset_from_box = *main_widget.find_descendant_of_type_named<GUI::ComboBox>("offset_from");
|
|
m_statusbar = *main_widget.find_descendant_of_type_named<GUI::Statusbar>("statusbar");
|
|
|
|
m_offset_type.append("Decimal");
|
|
m_offset_type.append("Hexadecimal");
|
|
m_offset_type_box->set_model(GUI::ItemListModel<String>::create(m_offset_type));
|
|
m_offset_type_box->set_selected_index(0);
|
|
m_offset_type_box->set_only_allow_values_from_model(true);
|
|
|
|
m_offset_from.append("Start");
|
|
m_offset_from.append("Here");
|
|
m_offset_from.append("End");
|
|
m_offset_from_box->set_model(GUI::ItemListModel<String>::create(m_offset_from));
|
|
m_offset_from_box->set_selected_index(0);
|
|
m_offset_from_box->set_only_allow_values_from_model(true);
|
|
|
|
m_text_editor->on_return_pressed = [this] {
|
|
m_go_button->click();
|
|
};
|
|
|
|
m_go_button->on_click = [this](auto) {
|
|
done(ExecResult::ExecOK);
|
|
};
|
|
|
|
m_text_editor->on_change = [this]() {
|
|
auto text = m_text_editor->text();
|
|
if (text.starts_with("0x")) {
|
|
m_offset_type_box->set_selected_index(1);
|
|
m_text_editor->set_text(text.replace("0x", ""));
|
|
}
|
|
update_statusbar();
|
|
};
|
|
|
|
m_offset_type_box->on_change = [this](auto&, auto&) {
|
|
update_statusbar();
|
|
};
|
|
|
|
m_offset_from_box->on_change = [this](auto&, auto&) {
|
|
update_statusbar();
|
|
};
|
|
|
|
update_statusbar();
|
|
}
|
|
|
|
GoToOffsetDialog::~GoToOffsetDialog()
|
|
{
|
|
}
|