mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2024-09-19 17:27:51 +03:00
398ae75f9a
Now that the chrome process is a singleton on all platforms, we can safely add a cache to the CookieJar to greatly speed up access. The way this works is we read all cookies upfront from the database. As cookies are updated by the web, we store a list of "dirty" cookies that need to be flushed to the database. We do that synchronization every 30 seconds and at shutdown. There's plenty of room for improvement here, some of which is marked with FIXMEs in the CookieJar. Before these changes, in a SQL database populated with 300 cookies, browsing to https://twinings.co.uk/ WebContent spent: 19,806ms waiting for a get-cookie response 505ms waiting for a set-cookie response With these changes, it spends: 24ms waiting for a get-cookie response 15ms waiting for a set-cookie response
130 lines
4.0 KiB
C++
130 lines
4.0 KiB
C++
/*
|
|
* Copyright (c) 2021-2024, Tim Flynn <trflynn89@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <AK/Function.h>
|
|
#include <AK/HashMap.h>
|
|
#include <AK/Optional.h>
|
|
#include <AK/String.h>
|
|
#include <AK/StringView.h>
|
|
#include <AK/Traits.h>
|
|
#include <LibCore/DateTime.h>
|
|
#include <LibCore/Timer.h>
|
|
#include <LibSQL/Type.h>
|
|
#include <LibURL/Forward.h>
|
|
#include <LibWeb/Cookie/Cookie.h>
|
|
#include <LibWeb/Forward.h>
|
|
#include <LibWebView/Forward.h>
|
|
|
|
namespace WebView {
|
|
|
|
struct CookieStorageKey {
|
|
bool operator==(CookieStorageKey const&) const = default;
|
|
|
|
String name;
|
|
String domain;
|
|
String path;
|
|
};
|
|
|
|
class CookieJar {
|
|
struct Statements {
|
|
SQL::StatementID create_table { 0 };
|
|
SQL::StatementID insert_cookie { 0 };
|
|
SQL::StatementID update_cookie { 0 };
|
|
SQL::StatementID expire_cookie { 0 };
|
|
SQL::StatementID select_all_cookies { 0 };
|
|
};
|
|
|
|
class TransientStorage {
|
|
public:
|
|
using Cookies = HashMap<CookieStorageKey, Web::Cookie::Cookie>;
|
|
|
|
void set_cookies(Cookies);
|
|
void set_cookie(CookieStorageKey, Web::Cookie::Cookie);
|
|
Optional<Web::Cookie::Cookie> get_cookie(CookieStorageKey const&);
|
|
|
|
size_t size() const { return m_cookies.size(); }
|
|
|
|
UnixDateTime purge_expired_cookies();
|
|
|
|
auto take_inserted_cookies() { return move(m_inserted_cookies); }
|
|
auto take_updated_cookies() { return move(m_updated_cookies); }
|
|
|
|
template<typename Callback>
|
|
void for_each_cookie(Callback callback)
|
|
{
|
|
for (auto& it : m_cookies)
|
|
callback(it.value);
|
|
}
|
|
|
|
private:
|
|
Cookies m_cookies;
|
|
Cookies m_inserted_cookies;
|
|
Cookies m_updated_cookies;
|
|
};
|
|
|
|
struct PersistedStorage {
|
|
void insert_cookie(Web::Cookie::Cookie const& cookie);
|
|
void update_cookie(Web::Cookie::Cookie const& cookie);
|
|
TransientStorage::Cookies select_all_cookies();
|
|
|
|
Database& database;
|
|
Statements statements;
|
|
RefPtr<Core::Timer> synchronization_timer {};
|
|
};
|
|
|
|
public:
|
|
static ErrorOr<NonnullOwnPtr<CookieJar>> create(Database&);
|
|
static NonnullOwnPtr<CookieJar> create();
|
|
|
|
~CookieJar();
|
|
|
|
String get_cookie(const URL::URL& url, Web::Cookie::Source source);
|
|
void set_cookie(const URL::URL& url, Web::Cookie::ParsedCookie const& parsed_cookie, Web::Cookie::Source source);
|
|
void update_cookie(Web::Cookie::Cookie);
|
|
void dump_cookies();
|
|
Vector<Web::Cookie::Cookie> get_all_cookies();
|
|
Vector<Web::Cookie::Cookie> get_all_cookies(URL::URL const& url);
|
|
Optional<Web::Cookie::Cookie> get_named_cookie(URL::URL const& url, StringView name);
|
|
|
|
private:
|
|
explicit CookieJar(Optional<PersistedStorage>);
|
|
|
|
AK_MAKE_NONCOPYABLE(CookieJar);
|
|
AK_MAKE_NONMOVABLE(CookieJar);
|
|
|
|
static Optional<String> canonicalize_domain(const URL::URL& url);
|
|
static bool domain_matches(StringView string, StringView domain_string);
|
|
static bool path_matches(StringView request_path, StringView cookie_path);
|
|
static String default_path(const URL::URL& url);
|
|
|
|
enum class MatchingCookiesSpecMode {
|
|
RFC6265,
|
|
WebDriver,
|
|
};
|
|
|
|
void store_cookie(Web::Cookie::ParsedCookie const& parsed_cookie, const URL::URL& url, String canonicalized_domain, Web::Cookie::Source source);
|
|
Vector<Web::Cookie::Cookie> get_matching_cookies(const URL::URL& url, StringView canonicalized_domain, Web::Cookie::Source source, MatchingCookiesSpecMode mode = MatchingCookiesSpecMode::RFC6265);
|
|
|
|
Optional<PersistedStorage> m_persisted_storage;
|
|
TransientStorage m_transient_storage;
|
|
};
|
|
|
|
}
|
|
|
|
template<>
|
|
struct AK::Traits<WebView::CookieStorageKey> : public AK::DefaultTraits<WebView::CookieStorageKey> {
|
|
static unsigned hash(WebView::CookieStorageKey const& key)
|
|
{
|
|
unsigned hash = 0;
|
|
hash = pair_int_hash(hash, key.name.hash());
|
|
hash = pair_int_hash(hash, key.domain.hash());
|
|
hash = pair_int_hash(hash, key.path.hash());
|
|
return hash;
|
|
}
|
|
};
|