mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2024-09-20 17:58:18 +03:00
ec2b4c271f
We would previously not return a RadioNodeList in the curious case where a named item resolves to two different elements within the form. This was not a problem when calling namedItem directly in the IDL as named_item_or_radio_node_list shadows named_item but is exposed when calling the property through array bracket notation (as an example). Fix this, and add a bunch more tests to cover HTMLFormControlsCollection.
88 lines
3.5 KiB
C++
88 lines
3.5 KiB
C++
/*
|
|
* Copyright (c) 2023, Shannon Booth <shannon@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibWeb/Bindings/Intrinsics.h>
|
|
#include <LibWeb/DOM/Element.h>
|
|
#include <LibWeb/DOM/HTMLCollection.h>
|
|
#include <LibWeb/DOM/HTMLFormControlsCollection.h>
|
|
#include <LibWeb/DOM/ParentNode.h>
|
|
|
|
namespace Web::DOM {
|
|
|
|
JS_DEFINE_ALLOCATOR(HTMLFormControlsCollection);
|
|
|
|
JS::NonnullGCPtr<HTMLFormControlsCollection> HTMLFormControlsCollection::create(ParentNode& root, Scope scope, Function<bool(Element const&)> filter)
|
|
{
|
|
return root.heap().allocate<HTMLFormControlsCollection>(root.realm(), root, scope, move(filter));
|
|
}
|
|
|
|
HTMLFormControlsCollection::HTMLFormControlsCollection(ParentNode& root, Scope scope, Function<bool(Element const&)> filter)
|
|
: HTMLCollection(root, scope, move(filter))
|
|
{
|
|
}
|
|
|
|
HTMLFormControlsCollection::~HTMLFormControlsCollection() = default;
|
|
|
|
void HTMLFormControlsCollection::initialize(JS::Realm& realm)
|
|
{
|
|
Base::initialize(realm);
|
|
set_prototype(&Bindings::ensure_web_prototype<Bindings::HTMLFormControlsCollectionPrototype>(realm, "HTMLFormControlsCollection"_fly_string));
|
|
}
|
|
|
|
// https://html.spec.whatwg.org/multipage/common-dom-interfaces.html#dom-htmlformcontrolscollection-nameditem
|
|
Variant<Empty, Element*, JS::Handle<RadioNodeList>> HTMLFormControlsCollection::named_item_or_radio_node_list(FlyString const& name) const
|
|
{
|
|
// 1. If name is the empty string, return null and stop the algorithm.
|
|
if (name.is_empty())
|
|
return {};
|
|
|
|
auto const deprecated_name = name.to_deprecated_fly_string();
|
|
|
|
// 2. If, at the time the method is called, there is exactly one node in the collection that has either an id attribute or a name attribute equal to name, then return that node and stop the algorithm.
|
|
// 3. Otherwise, if there are no nodes in the collection that have either an id attribute or a name attribute equal to name, then return null and stop the algorithm.
|
|
Element* matching_element = nullptr;
|
|
bool multiple_matching = false;
|
|
|
|
auto collection = collect_matching_elements();
|
|
for (auto const& element : collection) {
|
|
if (element->deprecated_attribute(HTML::AttributeNames::id) != deprecated_name && element->name() != deprecated_name)
|
|
continue;
|
|
|
|
if (matching_element) {
|
|
multiple_matching = true;
|
|
break;
|
|
}
|
|
|
|
matching_element = element;
|
|
}
|
|
|
|
if (!matching_element)
|
|
return {};
|
|
|
|
if (!multiple_matching)
|
|
return matching_element;
|
|
|
|
// 4. Otherwise, create a new RadioNodeList object representing a live view of the HTMLFormControlsCollection object, further filtered so that the only nodes in the
|
|
// RadioNodeList object are those that have either an id attribute or a name attribute equal to name. The nodes in the RadioNodeList object must be sorted in tree
|
|
// order. Return that RadioNodeList object.
|
|
return JS::make_handle(RadioNodeList::create(realm(), root(), LiveNodeList::Scope::Descendants, [deprecated_name](Node const& node) {
|
|
if (!is<Element>(node))
|
|
return false;
|
|
|
|
auto const& element = verify_cast<Element>(node);
|
|
return element.deprecated_attribute(HTML::AttributeNames::id) == deprecated_name || element.name() == deprecated_name;
|
|
}));
|
|
}
|
|
|
|
WebIDL::ExceptionOr<JS::Value> HTMLFormControlsCollection::named_item_value(FlyString const& name) const
|
|
{
|
|
return named_item_or_radio_node_list(name).visit(
|
|
[](Empty) -> JS::Value { return JS::js_undefined(); },
|
|
[](auto const& value) -> JS::Value { return value; });
|
|
}
|
|
|
|
}
|