ladybird/AK/Tests/TestMACAddress.cpp
Lenny Maiorani bdf3baa8ac MACAddress: AK::Array as member variable instead of C-array
Problem:
- C-style arrays do not automatically provide bounds checking and are
  less type safe overall.
- `__builtin_memcmp` is not a constant expression in the current gcc.

Solution:
- Change private m_data to be AK::Array.
- Eliminate constructor from C-style array.
- Change users of the C-style array constructor to use the default
  constructor.
- Change `operator==()` to be a hand-written comparison loop and let
  the optimizer figure out to use `memcmp`.
2020-11-20 21:18:14 +01:00

107 lines
3.0 KiB
C++

/*
* Copyright (c) 2020, the SerenityOS developers.
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are met:
*
* 1. Redistributions of source code must retain the above copyright notice, this
* list of conditions and the following disclaimer.
*
* 2. Redistributions in binary form must reproduce the above copyright notice,
* this list of conditions and the following disclaimer in the documentation
* and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
* CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
* OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
#include <AK/TestSuite.h>
#include <AK/MACAddress.h>
#include <AK/Types.h>
TEST_CASE(should_default_construct)
{
constexpr MACAddress sut {};
static_assert(sut.is_zero());
EXPECT(sut.is_zero());
}
TEST_CASE(should_braces_construct)
{
constexpr MACAddress sut { 1, 2, 3, 4, 5, 6 };
static_assert(!sut.is_zero());
EXPECT(!sut.is_zero());
}
TEST_CASE(should_construct_from_6_octets)
{
constexpr MACAddress sut(1, 2, 3, 4, 5, 6);
static_assert(!sut.is_zero());
EXPECT(!sut.is_zero());
}
TEST_CASE(should_provide_read_access_to_octet_by_index)
{
constexpr auto is_all_expected = [](auto& sut) {
for (auto i = 0u; i < sizeof(MACAddress); ++i) {
if (sut[i] != i + 1) {
return false;
}
}
return true;
};
constexpr MACAddress sut(1, 2, 3, 4, 5, 6);
static_assert(is_all_expected(sut));
for (auto i = 0u; i < sizeof(MACAddress); ++i) {
EXPECT_EQ(i + 1, sut[i]);
}
}
TEST_CASE(should_provide_write_access_to_octet_by_index)
{
constexpr auto sut = [] {
MACAddress m {};
for (auto i = 0u; i < sizeof(MACAddress); ++i) {
m[i] = i + 1;
}
return m;
}();
constexpr MACAddress expected(1, 2, 3, 4, 5, 6);
static_assert(expected == sut);
}
TEST_CASE(should_equality_compare)
{
constexpr MACAddress a(1, 2, 3, 4, 5, 6);
constexpr MACAddress b(1, 2, 3, 42, 5, 6);
static_assert(a == a);
static_assert(a != b);
EXPECT(a == a);
EXPECT(a != b);
}
TEST_CASE(should_string_format)
{
MACAddress sut(1, 2, 3, 4, 5, 6);
EXPECT_EQ("01:02:03:04:05:06", sut.to_string());
}
TEST_MAIN(MACAddress)