ladybird/Kernel/Lock.cpp
Andreas Kling b35ad5b523 Kernel: Fix bad assertion in Lock::unlock_if_locked()
We shouldn't assert if you call this on a Lock held by another Thread
in the same Process. Instead, we should just not unlock.
2019-09-14 20:21:06 +02:00

73 lines
1.7 KiB
C++

#include <Kernel/Lock.h>
void Lock::lock()
{
ASSERT(!Scheduler::is_active());
if (!are_interrupts_enabled()) {
kprintf("Interrupts disabled when trying to take Lock{%s}\n", m_name);
dump_backtrace();
hang();
}
for (;;) {
if (CAS(&m_lock, 1, 0) == 0) {
if (!m_holder || m_holder == current) {
m_holder = current;
++m_level;
memory_barrier();
m_lock = 0;
return;
}
m_lock = 0;
}
Scheduler::donate_to(m_holder, m_name);
}
}
void Lock::unlock()
{
for (;;) {
if (CAS(&m_lock, 1, 0) == 0) {
ASSERT(m_holder == current);
ASSERT(m_level);
--m_level;
if (m_level) {
memory_barrier();
m_lock = 0;
return;
}
m_holder = nullptr;
memory_barrier();
m_lock = 0;
return;
}
Scheduler::donate_to(m_holder, m_name);
}
}
bool Lock::unlock_if_locked()
{
for (;;) {
if (CAS(&m_lock, 1, 0) == 0) {
if (m_level == 0) {
m_lock = 0;
return false;
}
if (m_holder != current) {
m_lock = 0;
return false;
}
ASSERT(m_level);
--m_level;
if (m_level) {
memory_barrier();
m_lock = 0;
return false;
}
m_holder = nullptr;
memory_barrier();
m_lock = 0;
return true;
}
}
}