mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2024-10-12 05:07:15 +03:00
54b9a4ec1e
Previously we would crash the process immediately when a promise violation was found during a syscall. This is error prone, as we don't unwind the stack. This means that in certain cases we can leak resources, like an OwnPtr / RefPtr tracked on the stack. Or even leak a lock acquired in a ScopeLockLocker. To remedy this situation we move the promise violation handling to the syscall handler, right before we return to user space. This allows the code to follow the normal unwind path, and grantees there is no longer any cleanup that needs to occur. The Process::require_promise() and Process::require_no_promises() functions were modified to return ErrorOr<void> so we enforce that the errors are always propagated by the caller.
121 lines
3.5 KiB
C++
121 lines
3.5 KiB
C++
/*
|
|
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <AK/Time.h>
|
|
#include <Kernel/Process.h>
|
|
#include <Kernel/Time/TimeManagement.h>
|
|
|
|
namespace Kernel {
|
|
|
|
ErrorOr<FlatPtr> Process::sys$map_time_page()
|
|
{
|
|
VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this);
|
|
TRY(require_promise(Pledge::stdio));
|
|
|
|
auto& vmobject = TimeManagement::the().time_page_vmobject();
|
|
|
|
auto range = TRY(address_space().page_directory().range_allocator().try_allocate_randomized(PAGE_SIZE, PAGE_SIZE));
|
|
auto* region = TRY(address_space().allocate_region_with_vmobject(range, vmobject, 0, "Kernel time page"sv, PROT_READ, true));
|
|
return region->vaddr().get();
|
|
}
|
|
|
|
ErrorOr<FlatPtr> Process::sys$clock_gettime(clockid_t clock_id, Userspace<timespec*> user_ts)
|
|
{
|
|
VERIFY_NO_PROCESS_BIG_LOCK(this);
|
|
TRY(require_promise(Pledge::stdio));
|
|
|
|
if (!TimeManagement::is_valid_clock_id(clock_id))
|
|
return EINVAL;
|
|
|
|
auto ts = TimeManagement::the().current_time(clock_id).to_timespec();
|
|
TRY(copy_to_user(user_ts, &ts));
|
|
return 0;
|
|
}
|
|
|
|
ErrorOr<FlatPtr> Process::sys$clock_settime(clockid_t clock_id, Userspace<const timespec*> user_ts)
|
|
{
|
|
VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this);
|
|
TRY(require_promise(Pledge::settime));
|
|
|
|
if (!is_superuser())
|
|
return EPERM;
|
|
|
|
auto time = TRY(copy_time_from_user(user_ts));
|
|
|
|
switch (clock_id) {
|
|
case CLOCK_REALTIME:
|
|
TimeManagement::the().set_epoch_time(time);
|
|
break;
|
|
default:
|
|
return EINVAL;
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
ErrorOr<FlatPtr> Process::sys$clock_nanosleep(Userspace<const Syscall::SC_clock_nanosleep_params*> user_params)
|
|
{
|
|
VERIFY_NO_PROCESS_BIG_LOCK(this);
|
|
TRY(require_promise(Pledge::stdio));
|
|
auto params = TRY(copy_typed_from_user(user_params));
|
|
|
|
auto requested_sleep = TRY(copy_time_from_user(params.requested_sleep));
|
|
|
|
bool is_absolute;
|
|
switch (params.flags) {
|
|
case 0:
|
|
is_absolute = false;
|
|
break;
|
|
case TIMER_ABSTIME:
|
|
is_absolute = true;
|
|
break;
|
|
default:
|
|
return EINVAL;
|
|
}
|
|
|
|
if (!TimeManagement::is_valid_clock_id(params.clock_id))
|
|
return EINVAL;
|
|
|
|
bool was_interrupted;
|
|
if (is_absolute) {
|
|
was_interrupted = Thread::current()->sleep_until(params.clock_id, requested_sleep).was_interrupted();
|
|
} else {
|
|
Time remaining_sleep;
|
|
was_interrupted = Thread::current()->sleep(params.clock_id, requested_sleep, &remaining_sleep).was_interrupted();
|
|
timespec remaining_sleep_ts = remaining_sleep.to_timespec();
|
|
if (was_interrupted && params.remaining_sleep) {
|
|
TRY(copy_to_user(params.remaining_sleep, &remaining_sleep_ts));
|
|
}
|
|
}
|
|
if (was_interrupted)
|
|
return EINTR;
|
|
return 0;
|
|
}
|
|
|
|
ErrorOr<FlatPtr> Process::sys$adjtime(Userspace<const timeval*> user_delta, Userspace<timeval*> user_old_delta)
|
|
{
|
|
VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this);
|
|
if (user_old_delta) {
|
|
timespec old_delta_ts = TimeManagement::the().remaining_epoch_time_adjustment();
|
|
timeval old_delta;
|
|
timespec_to_timeval(old_delta_ts, old_delta);
|
|
TRY(copy_to_user(user_old_delta, &old_delta));
|
|
}
|
|
|
|
if (user_delta) {
|
|
TRY(require_promise(Pledge::settime));
|
|
if (!is_superuser())
|
|
return EPERM;
|
|
auto delta = TRY(copy_time_from_user(user_delta));
|
|
|
|
// FIXME: Should use AK::Time internally
|
|
TimeManagement::the().set_remaining_epoch_time_adjustment(delta.to_timespec());
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
}
|