ladybird/Kernel/ProcessGroup.cpp
Brian Gianforcaro e95eb7a51d Kernel: Avoid allocating under spinlock in ProcessGroup::find_or_create
Avoid allocating while holding the g_process_groups_lock spinlock, it's
a pattern that has a negative effect on performance and scalability,
especially given that it is a global lock, reachable by all processes.
2021-05-20 08:10:07 +02:00

66 lines
1.6 KiB
C++

/*
* Copyright (c) 2020, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include "ProcessGroup.h"
namespace Kernel {
RecursiveSpinLock g_process_groups_lock;
InlineLinkedList<ProcessGroup>* g_process_groups;
ProcessGroup::~ProcessGroup()
{
ScopedSpinLock lock(g_process_groups_lock);
g_process_groups->remove(this);
}
RefPtr<ProcessGroup> ProcessGroup::create(ProcessGroupID pgid)
{
auto process_group = adopt_ref_if_nonnull(new ProcessGroup(pgid));
if (process_group) {
ScopedSpinLock lock(g_process_groups_lock);
g_process_groups->prepend(process_group);
}
return process_group;
}
RefPtr<ProcessGroup> ProcessGroup::find_or_create(ProcessGroupID pgid)
{
// Avoid allocating under spinlock, this compromises by wasting the
// allocation when we race with another process to see if they have
// already created a process group.
auto process_group = adopt_ref_if_nonnull(new ProcessGroup(pgid));
ScopedSpinLock lock(g_process_groups_lock);
if (auto existing = from_pgid_nolock(pgid))
return existing.release_nonnull();
if (!process_group)
return {};
g_process_groups->prepend(process_group);
return process_group;
}
RefPtr<ProcessGroup> ProcessGroup::from_pgid(ProcessGroupID pgid)
{
ScopedSpinLock lock(g_process_groups_lock);
return from_pgid_nolock(pgid);
}
RefPtr<ProcessGroup> ProcessGroup::from_pgid_nolock(ProcessGroupID pgid)
{
VERIFY(g_process_groups_lock.own_lock());
for (auto& group : *g_process_groups) {
if (group.pgid() == pgid)
return &group;
}
return nullptr;
}
}