mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2024-09-20 17:58:18 +03:00
fd7a059e09
If invoking a NodeFilter ends up deleting a node from the DOM, it's not enough to only adjust the NodeIterator reference nodes in the pre-removing steps. We must also adjust the current traversal pointer. This is not in the spec, but it's how other engines behave, so let's do the same. I've encapsulated the Node + before-or-after-flag in a struct called NodePointer so that we can use the same pre-removing steps for both the traversal pointer and for the NodeIterator's reference node. Note that when invoking the NodeFilter, we have to remember the node we passed to the filter function, so that we can return it if accepted by the filter. This gets us another point on Acid3. :^)
82 lines
2.2 KiB
C++
82 lines
2.2 KiB
C++
/*
|
|
* Copyright (c) 2022, Andreas Kling <kling@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <AK/RefCounted.h>
|
|
#include <LibWeb/Bindings/Wrappable.h>
|
|
#include <LibWeb/DOM/NodeFilter.h>
|
|
|
|
namespace Web::DOM {
|
|
|
|
// https://dom.spec.whatwg.org/#nodeiterator
|
|
class NodeIterator
|
|
: public RefCounted<NodeIterator>
|
|
, public Bindings::Wrappable {
|
|
public:
|
|
using WrapperType = Bindings::NodeIteratorWrapper;
|
|
|
|
virtual ~NodeIterator() override;
|
|
|
|
static NonnullRefPtr<NodeIterator> create(Node& root, unsigned what_to_show, RefPtr<NodeFilter>);
|
|
|
|
NonnullRefPtr<Node> root() { return m_root; }
|
|
NonnullRefPtr<Node> reference_node() { return m_reference.node; }
|
|
bool pointer_before_reference_node() const { return m_reference.is_before_node; }
|
|
unsigned what_to_show() const { return m_what_to_show; }
|
|
|
|
NodeFilter* filter() { return m_filter; }
|
|
|
|
JS::ThrowCompletionOr<RefPtr<Node>> next_node();
|
|
JS::ThrowCompletionOr<RefPtr<Node>> previous_node();
|
|
|
|
void detach();
|
|
|
|
void run_pre_removing_steps(Node&);
|
|
|
|
private:
|
|
NodeIterator(Node& root);
|
|
|
|
enum class Direction {
|
|
Next,
|
|
Previous,
|
|
};
|
|
|
|
JS::ThrowCompletionOr<RefPtr<Node>> traverse(Direction);
|
|
|
|
JS::ThrowCompletionOr<NodeFilter::Result> filter(Node&);
|
|
|
|
// https://dom.spec.whatwg.org/#concept-traversal-root
|
|
NonnullRefPtr<DOM::Node> m_root;
|
|
|
|
struct NodePointer {
|
|
NonnullRefPtr<DOM::Node> node;
|
|
|
|
// https://dom.spec.whatwg.org/#nodeiterator-pointer-before-reference
|
|
bool is_before_node { true };
|
|
};
|
|
|
|
void run_pre_removing_steps_with_node_pointer(Node&, NodePointer&);
|
|
|
|
// https://dom.spec.whatwg.org/#nodeiterator-reference
|
|
NodePointer m_reference;
|
|
|
|
// While traversal is ongoing, we keep track of the current node pointer.
|
|
// This allows us to adjust it during traversal if calling the filter ends up removing the node from the DOM.
|
|
Optional<NodePointer> m_traversal_pointer;
|
|
|
|
// https://dom.spec.whatwg.org/#concept-traversal-whattoshow
|
|
unsigned m_what_to_show { 0 };
|
|
|
|
// https://dom.spec.whatwg.org/#concept-traversal-filter
|
|
RefPtr<DOM::NodeFilter> m_filter;
|
|
|
|
// https://dom.spec.whatwg.org/#concept-traversal-active
|
|
bool m_active { false };
|
|
};
|
|
|
|
}
|