mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2024-11-10 13:00:29 +03:00
655d9d1462
This fixes a plethora of rounding problems on many websites. In the future, we may want to replace this with fixed-point arithmetic (bug #18566) for performance (and consistency with other engines), but in the meantime this makes the web look a bit better. :^) There's a lot more things that could be converted to doubles, which would reduce the amount of casting necessary in this patch. We can do that incrementally, however.
170 lines
5.0 KiB
C++
170 lines
5.0 KiB
C++
/*
|
|
* Copyright (c) 2022, Sam Atkins <atkinssj@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <AK/Concepts.h>
|
|
#include <AK/DistinctNumeric.h>
|
|
#include <AK/Traits.h>
|
|
#include <LibGfx/Forward.h>
|
|
#include <math.h>
|
|
|
|
namespace Web {
|
|
|
|
/// DevicePixels: A position or length on the physical display.
|
|
AK_TYPEDEF_DISTINCT_NUMERIC_GENERAL(int, DevicePixels, Arithmetic, CastToUnderlying, Comparison, Increment);
|
|
|
|
template<Integral T>
|
|
constexpr bool operator==(DevicePixels left, T right) { return left.value() == right; }
|
|
|
|
template<Integral T>
|
|
constexpr bool operator!=(DevicePixels left, T right) { return left.value() != right; }
|
|
|
|
template<Integral T>
|
|
constexpr bool operator>(DevicePixels left, T right) { return left.value() > right; }
|
|
|
|
template<Integral T>
|
|
constexpr bool operator<(DevicePixels left, T right) { return left.value() < right; }
|
|
|
|
template<Integral T>
|
|
constexpr bool operator>=(DevicePixels left, T right) { return left.value() >= right; }
|
|
|
|
template<Integral T>
|
|
constexpr bool operator<=(DevicePixels left, T right) { return left.value() <= right; }
|
|
|
|
template<Integral T>
|
|
constexpr DevicePixels operator*(DevicePixels left, T right) { return left.value() * right; }
|
|
template<Integral T>
|
|
constexpr DevicePixels operator*(T left, DevicePixels right) { return right * left; }
|
|
|
|
template<Integral T>
|
|
constexpr DevicePixels operator/(DevicePixels left, T right) { return left.value() / right; }
|
|
|
|
template<Integral T>
|
|
constexpr DevicePixels operator%(DevicePixels left, T right) { return left.value() % right; }
|
|
|
|
/// CSSPixels: A position or length in CSS "reference pixels", independent of zoom or screen DPI.
|
|
/// See https://www.w3.org/TR/css-values-3/#reference-pixel
|
|
AK_TYPEDEF_DISTINCT_NUMERIC_GENERAL(double, CSSPixels, Arithmetic, CastToUnderlying, Comparison, Increment);
|
|
|
|
template<Arithmetic T>
|
|
constexpr bool operator==(CSSPixels left, T right) { return left.value() == right; }
|
|
|
|
template<Arithmetic T>
|
|
constexpr bool operator!=(CSSPixels left, T right) { return left.value() != right; }
|
|
|
|
template<Arithmetic T>
|
|
constexpr bool operator>(CSSPixels left, T right) { return left.value() > right; }
|
|
|
|
template<Arithmetic T>
|
|
constexpr bool operator<(CSSPixels left, T right) { return left.value() < right; }
|
|
|
|
template<Arithmetic T>
|
|
constexpr bool operator>=(CSSPixels left, T right) { return left.value() >= right; }
|
|
|
|
template<Arithmetic T>
|
|
constexpr bool operator<=(CSSPixels left, T right) { return left.value() <= right; }
|
|
|
|
template<Arithmetic T>
|
|
constexpr CSSPixels operator*(CSSPixels left, T right) { return left.value() * right; }
|
|
template<Arithmetic T>
|
|
constexpr CSSPixels operator*(T left, CSSPixels right) { return right * left; }
|
|
|
|
template<Arithmetic T>
|
|
constexpr CSSPixels operator/(CSSPixels left, T right) { return left.value() / right; }
|
|
|
|
template<Arithmetic T>
|
|
constexpr CSSPixels operator%(CSSPixels left, T right) { return left.value() % right; }
|
|
|
|
using CSSPixelLine = Gfx::Line<CSSPixels>;
|
|
using CSSPixelPoint = Gfx::Point<CSSPixels>;
|
|
using CSSPixelRect = Gfx::Rect<CSSPixels>;
|
|
using CSSPixelSize = Gfx::Size<CSSPixels>;
|
|
|
|
using DevicePixelLine = Gfx::Line<DevicePixels>;
|
|
using DevicePixelPoint = Gfx::Point<DevicePixels>;
|
|
using DevicePixelRect = Gfx::Rect<DevicePixels>;
|
|
using DevicePixelSize = Gfx::Size<DevicePixels>;
|
|
|
|
}
|
|
|
|
constexpr Web::CSSPixels floor(Web::CSSPixels const& value)
|
|
{
|
|
return ::floorf(value.value());
|
|
}
|
|
|
|
constexpr Web::CSSPixels ceil(Web::CSSPixels const& value)
|
|
{
|
|
return ::ceilf(value.value());
|
|
}
|
|
|
|
constexpr Web::CSSPixels round(Web::CSSPixels const& value)
|
|
{
|
|
return ::roundf(value.value());
|
|
}
|
|
|
|
constexpr Web::CSSPixels fmod(Web::CSSPixels const& x, Web::CSSPixels const& y)
|
|
{
|
|
return ::fmodf(x.value(), y.value());
|
|
}
|
|
|
|
constexpr Web::CSSPixels abs(Web::CSSPixels const& value)
|
|
{
|
|
return AK::abs(value.value());
|
|
}
|
|
|
|
constexpr Web::DevicePixels abs(Web::DevicePixels const& value)
|
|
{
|
|
return AK::abs(value.value());
|
|
}
|
|
|
|
namespace AK {
|
|
|
|
template<>
|
|
struct Traits<Web::CSSPixels> : public GenericTraits<Web::CSSPixels> {
|
|
static unsigned hash(Web::CSSPixels const& key)
|
|
{
|
|
VERIFY(isfinite(key.value()));
|
|
return Traits<Web::CSSPixels::Type>::hash(key.value());
|
|
}
|
|
|
|
static bool equals(Web::CSSPixels const& a, Web::CSSPixels const& b)
|
|
{
|
|
return a == b;
|
|
}
|
|
};
|
|
|
|
template<>
|
|
struct Traits<Web::DevicePixels> : public GenericTraits<Web::DevicePixels> {
|
|
static unsigned hash(Web::DevicePixels const& key)
|
|
{
|
|
return Traits<Web::DevicePixels::Type>::hash(key.value());
|
|
}
|
|
|
|
static bool equals(Web::DevicePixels const& a, Web::DevicePixels const& b)
|
|
{
|
|
return a == b;
|
|
}
|
|
};
|
|
|
|
template<>
|
|
struct Formatter<Web::CSSPixels> : Formatter<Web::CSSPixels::Type> {
|
|
ErrorOr<void> format(FormatBuilder& builder, Web::CSSPixels const& value)
|
|
{
|
|
return Formatter<Web::CSSPixels::Type>::format(builder, value.value());
|
|
}
|
|
};
|
|
|
|
template<>
|
|
struct Formatter<Web::DevicePixels> : Formatter<Web::DevicePixels::Type> {
|
|
ErrorOr<void> format(FormatBuilder& builder, Web::DevicePixels const& value)
|
|
{
|
|
return Formatter<Web::DevicePixels::Type>::format(builder, value.value());
|
|
}
|
|
};
|
|
|
|
}
|