MichaelMure/git-bug
1
1
Fork 0
mirror of https://github.com/MichaelMure/git-bug.git synced 2024-12-16 19:34:41 +03:00
Code Issues Projects Releases Wiki Activity

chore(TestCache): cleanup per PR review

Browse Source 
Resolves #979
This commit is contained in:
Steve Moyer 2023-01-05 22:09:51 -05:00
parent 0f12b901e7
commit 5c45e70aab
No known key found for this signature in database
GPG Key ID: D8D464C9D22FB8E0
1 changed files with 33 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
cache/repo_cache_test.go vendored
View File

@ -18,6 +18,17 @@ import (
func TestCache(t *testing.T) { func TestCache(t *testing.T) {
repo := repository.CreateGoGitTestRepo(t, false) repo := repository.CreateGoGitTestRepo(t, false)
indexCount := func(t *testing.T, name string) uint64 {
t.Helper()
idx, err := repo.GetIndex(name)
require.NoError(t, err)
count, err := idx.DocCount()
require.NoError(t, err)
return count
}
var ( var (
cache *RepoCache cache *RepoCache
bug1 *BugCache bug1 *BugCache
@ -25,8 +36,8 @@ func TestCache(t *testing.T) {
) )
t.Run("entity operations on cache", func(t *testing.T) { t.Run("entity operations on cache", func(t *testing.T) {
cache = createTestRepoCacheNoEvents(t, repo) cache, err := NewRepoCacheNoEvents(repo)
var err error require.NoError(t, err)
// Create, set and get user identity // Create, set and get user identity
iden1, err = cache.Identities().New("René Descartes", "rene@descartes.fr") iden1, err = cache.Identities().New("René Descartes", "rene@descartes.fr")
@ -48,8 +59,8 @@ func TestCache(t *testing.T) {
require.Len(t, cache.Identities().AllIds(), 2) require.Len(t, cache.Identities().AllIds(), 2)
require.Len(t, cache.identities.excerpts, 2) require.Len(t, cache.identities.excerpts, 2)
require.Len(t, cache.identities.cached, 2) require.Len(t, cache.identities.cached, 2)
require.Equal(t, uint64(2), indexCount(t, repo, identity.Namespace)) require.Equal(t, uint64(2), indexCount(t, identity.Namespace))
require.Equal(t, uint64(0), indexCount(t, repo, bug.Namespace)) require.Equal(t, uint64(0), indexCount(t, bug.Namespace))
// Create a bug // Create a bug
bug1, _, err = cache.Bugs().New("title", "message") bug1, _, err = cache.Bugs().New("title", "message")
@ -66,8 +77,8 @@ func TestCache(t *testing.T) {
require.Len(t, cache.Bugs().AllIds(), 2) require.Len(t, cache.Bugs().AllIds(), 2)
require.Len(t, cache.bugs.excerpts, 2) require.Len(t, cache.bugs.excerpts, 2)
require.Len(t, cache.bugs.cached, 2) require.Len(t, cache.bugs.cached, 2)
require.Equal(t, uint64(2), indexCount(t, repo, identity.Namespace)) require.Equal(t, uint64(2), indexCount(t, identity.Namespace))
require.Equal(t, uint64(2), indexCount(t, repo, bug.Namespace)) require.Equal(t, uint64(2), indexCount(t, bug.Namespace))
// Resolving // Resolving
_, err = cache.Identities().Resolve(iden1.Id()) _, err = cache.Identities().Resolve(iden1.Id())
@ -96,13 +107,22 @@ func TestCache(t *testing.T) {
res, err = cache.Bugs().Query(q) res, err = cache.Bugs().Query(q)
require.NoError(t, err) require.NoError(t, err)
require.Len(t, res, 1) require.Len(t, res, 1)
// Close
require.NoError(t, cache.Close())
require.Empty(t, cache.bugs.cached)
require.Empty(t, cache.bugs.excerpts)
require.Empty(t, cache.identities.cached)
require.Empty(t, cache.identities.excerpts)
}) })
// Close (repository is closed by t.Cleanup() when the function above is exited) t.Run("closed caches are empty", func(t *testing.T) {
require.Empty(t, cache.bugs.cached) t.Skip()
require.Empty(t, cache.bugs.excerpts) cache, err := NewRepoCacheNoEvents(repo)
require.Empty(t, cache.identities.cached) require.NoError(t, err)
require.Empty(t, cache.identities.excerpts)
require.Empty(t, cache.identities.excerpts)
})
// Reload, only excerpt are loaded, but as we need to load the identities used in the bugs // Reload, only excerpt are loaded, but as we need to load the identities used in the bugs
// to check the signatures, we also load the identity used above // to check the signatures, we also load the identity used above
@ -112,8 +132,8 @@ func TestCache(t *testing.T) {
require.Len(t, cache.bugs.excerpts, 2) require.Len(t, cache.bugs.excerpts, 2)
require.Len(t, cache.identities.cached, 0) require.Len(t, cache.identities.cached, 0)
require.Len(t, cache.identities.excerpts, 2) require.Len(t, cache.identities.excerpts, 2)
require.Equal(t, uint64(2), indexCount(t, repo, identity.Namespace)) require.Equal(t, uint64(2), indexCount(t, identity.Namespace))
require.Equal(t, uint64(2), indexCount(t, repo, bug.Namespace)) require.Equal(t, uint64(2), indexCount(t, bug.Namespace))
// Resolving load from the disk // Resolving load from the disk
_, err := cache.Identities().Resolve(iden1.Id()) _, err := cache.Identities().Resolve(iden1.Id())