commands: enhance flag description

bridge/github: improve configuration logic

Co-Authored-By: Michael Muré <batolettre@gmail.com>
This commit is contained in:
Amine 2019-08-23 11:09:03 +02:00 committed by Amine Hilaly
parent 0381400bfd
commit 65d7ce7c05
No known key found for this signature in database
GPG Key ID: 3F4C54B792F211C1
2 changed files with 2 additions and 2 deletions

View File

@ -45,7 +45,7 @@ func (g *Github) Configure(repo repository.RepoCommon, params core.BridgeParams)
var project string
if params.Token != "" &&
!(params.URL != "" || (params.Project != "" && params.Owner != "")) {
(params.URL == "" && (params.Project == "" || params.Owner == "")) {
return nil, fmt.Errorf("you must provide a project URL or Owner/Name to configure this bridge with a token")
}

View File

@ -191,7 +191,7 @@ func init() {
bridgeConfigureCmd.Flags().StringVarP(&bridgeParams.URL, "url", "u", "", "The URL of the target repository")
bridgeConfigureCmd.Flags().StringVarP(&bridgeParams.Owner, "owner", "o", "", "The owner of the target repository")
bridgeConfigureCmd.Flags().StringVarP(&bridgeParams.Token, "token", "T", "", "The authentication token for the API")
bridgeConfigureCmd.Flags().BoolVar(&tokenStdin, "token-stdin", false, "Expect to receive token from stdin and ignore token flag.")
bridgeConfigureCmd.Flags().BoolVar(&tokenStdin, "token-stdin", false, "Will read the token from stdin and ignore --token")
bridgeConfigureCmd.Flags().StringVarP(&bridgeParams.Project, "project", "p", "", "The name of the target repository")
bridgeConfigureCmd.Flags().SortFlags = false
}