Michael Muré
7348fb9edb
github: fix data race when closing event channel
...
I believe the issue was twofold:
When done importing, the calling context is likely still valid, so if the output channel is not read enough and reach capacity, some event producer down the line can be blocked trying to send in that channel. When closing it, this send is still trying to proceed, which is illegal in go.
In rateLimitHandlerClient, there was a need to 2 different type of output channel: core.ExportResult and ImportEvent. To do so, the previous code was using a single channel type RateLimitingEvent and a series of goroutines to read/cast/send to the final channel. This could result in more async goroutine being stuck trying to send in an at-capacity channel. Instead, the code now use a simple synchronous callback to directly push to the final output channel. No concurrency needed anymore and the code is simpler.
Any of those fixes could have resolved the data race, but both fixes is more correct.
2022-06-05 15:13:49 +02:00
Michael Muré
fe231231c6
graphql: fix two invalid mutex lock leading to data races
2022-06-05 13:23:02 +02:00
Steve Moyer
eda312f9b1
fix(778): remove extra mutex lock when resolving bug prefix
2022-05-31 21:25:23 -04:00
Michael Muré
295da9c70f
cache: ensure that the default repo has a non-empty name to make js/apollo happy
2022-05-31 21:47:57 +02:00
Michael Muré
96327c3371
Merge pull request #806 from MichaelMure/docs
...
doc: more discoverable docs
2022-05-31 20:20:25 +02:00
Michael Muré
1c219f6769
doc: more discoverable docs
2022-05-31 20:18:18 +02:00
Michael Muré
d94df63466
Merge pull request #805 from MichaelMure/completion-cleanup
...
misc: move all completions in a dedicated folder
2022-05-31 20:16:15 +02:00
Michael Muré
c732a18ac2
misc: move all completions in a dedicated folder
2022-05-31 19:44:53 +02:00
Steve Moyer
ccc342e814
refactor: simplify creation of temp dir - after 1.15
2022-05-31 07:47:56 -04:00
Steve Moyer
da9f95e495
fix: remove only t.Parallel()
2022-05-31 07:22:55 -04:00
Michael Muré
50de0306df
gogit: close index before deleting it on disk
2022-05-31 12:24:58 +02:00
Steve Moyer
86dd450aaf
test: clean up temp dir and repo correctly
2022-05-31 12:04:26 +02:00
Steve Moyer
90208b5f6d
test(778): execute rm bug in testEnv (hangs)
2022-05-28 10:38:04 -04:00
Steve Moyer
ecfffe3902
test(778): execute add user in testEnv and return userID
2022-05-28 10:30:44 -04:00
Steve Moyer
508d0eb82a
test(778): clear output after user creation
2022-05-28 10:29:30 -04:00
Steve Moyer
50324b8a7c
test(778): verify user create results in an identity and cache
2022-05-27 13:39:16 -04:00
Steve Moyer
5962ed8453
test(778): verify root command returns main help text
2022-05-27 13:37:16 -04:00
Steve Moyer
523a148185
test(778): allow alternate CWD via context
2022-05-27 13:33:44 -04:00
Steve Moyer
1659fed99f
test(778): capture stderr and stdout during tests
2022-05-27 11:15:35 -04:00
Steve Moyer
8821b67d1b
test: add verification that localStorage.Root() resolves to the correct absolute filepath
2022-05-26 13:40:52 -04:00
Steve Moyer
e120fdb97e
refactor: use namespace instead of application of applicationName
2022-05-26 13:39:13 -04:00
Steve Moyer
e29f58bf85
chore: clean-up commented code
2022-05-25 07:59:56 -04:00
Steve Moyer
b42fae382a
feat: make local storage configurable
2022-05-25 07:55:28 -04:00
dependabot[bot]
f20db728de
build(deps): bump github.com/xanzy/go-gitlab from 0.64.0 to 0.68.0
...
Bumps [github.com/xanzy/go-gitlab](https://github.com/xanzy/go-gitlab ) from 0.64.0 to 0.68.0.
- [Release notes](https://github.com/xanzy/go-gitlab/releases )
- [Changelog](https://github.com/xanzy/go-gitlab/blob/master/releases_test.go )
- [Commits](https://github.com/xanzy/go-gitlab/compare/v0.64.0...v0.68.0 )
---
updated-dependencies:
- dependency-name: github.com/xanzy/go-gitlab
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-05-25 04:10:41 +00:00
Michael Muré
650c11dcb6
Merge pull request #788 from hoijui/model_touchup
...
Model touchup
2022-05-10 16:30:58 +02:00
Michael Muré
bd7508291c
Merge pull request #768 from MichaelMure/dependabot/go_modules/github.com/stretchr/testify-1.7.1
...
build(deps): bump github.com/stretchr/testify from 1.7.0 to 1.7.1
2022-05-04 12:29:37 +02:00
Michael Muré
66c4da3417
Merge pull request #783 from MichaelMure/dependabot/go_modules/github.com/xanzy/go-gitlab-0.64.0
...
build(deps): bump github.com/xanzy/go-gitlab from 0.59.0 to 0.64.0
2022-05-04 12:29:20 +02:00
Robin Vobruba
75ca2ce7da
model: Multiple, minor readability and language improvements
2022-05-04 12:19:50 +02:00
Robin Vobruba
9b871c6114
model: Removes now outdated statement about ops and root
2022-05-04 12:18:50 +02:00
Robin Vobruba
00fb4bc098
model: Highlight some words with special meaning
2022-05-04 12:16:40 +02:00
Robin Vobruba
e652eb6f5b
model: Links to a section further down
2022-05-04 12:11:43 +02:00
Robin Vobruba
2a0331e2dd
model: Moves example description after the example
2022-05-04 12:11:11 +02:00
Robin Vobruba
543e7b78f5
model: Adds link explaining nounce (wikipedia)
2022-05-04 12:03:49 +02:00
Robin Vobruba
33c670271c
model: strict Markdown requires empty lines before (and after) lists
2022-05-04 12:01:22 +02:00
Michael Muré
547d626c25
Merge pull request #531 from krobelus/complete-bug-ids
...
Complete bug IDs where appropriate
2022-05-01 12:54:40 +02:00
Michael Muré
3d534a70e9
completion: lots of small ironing
2022-05-01 12:46:58 +02:00
Michael Muré
b9991d84b9
ls: fix incorrect query parsing with quotes escaped by the shell
2022-05-01 12:31:50 +02:00
TsT
edc8b7589d
misc: fix bash completion with "git bug"
2022-05-01 10:54:13 +02:00
Michael Muré
f25690db47
completion: use the correct GenBashCompletionV2 instead of the legacy function
2022-05-01 10:54:13 +02:00
Johannes Altmanninger
bc6ba02bd8
Add command-specific argument completions
...
Complete bug IDs, bridges, users, labels where appropriate.
This works in bash and fish. ZSH is not yet supported by Cobra.
In fish, descriptions (the part of a completion after the "\t") are shown
as completion label, and can be searched with Ctrl+S.
Reproduce with
fish -C 'source misc/fish_completion/git-bug'
git bug select ^I
(tested with fish version 3.3.1)
Also works with bash, but only for "git-bug" (with the dash)
bash --rcfile <(echo source misc/bash_completion/git-bug)
git-bug select ^I
Closes #493
2022-05-01 10:54:13 +02:00
Michael Muré
8ee333582f
a few fixes
2022-04-26 19:36:46 +02:00
dependabot[bot]
5354b08211
build(deps): bump github.com/xanzy/go-gitlab from 0.59.0 to 0.64.0
...
Bumps [github.com/xanzy/go-gitlab](https://github.com/xanzy/go-gitlab ) from 0.59.0 to 0.64.0.
- [Release notes](https://github.com/xanzy/go-gitlab/releases )
- [Changelog](https://github.com/xanzy/go-gitlab/blob/master/releases_test.go )
- [Commits](https://github.com/xanzy/go-gitlab/compare/v0.59.0...v0.64.0 )
---
updated-dependencies:
- dependency-name: github.com/xanzy/go-gitlab
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-04-25 04:11:38 +00:00
Michael Muré
a00f1a9897
Merge pull request #773 from gaelj/fix-gitlab-pat-format
...
Allow new gitlab PAT format
2022-04-19 21:53:52 +02:00
Michael Muré
b8a799a97d
Merge pull request #767 from MichaelMure/single-author
...
bug: don't serialize multiple time the author, only once in OperationPack
2022-04-19 21:47:15 +02:00
Gaël James
09037baa7c
Allow new gitlab PAT format
2022-03-31 09:57:50 +02:00
Michael Muré
450d7f7ade
entity/dag: add an extensive example
2022-03-22 21:34:55 +01:00
Michael Muré
d0e65d5a1e
doc: add missing file
2022-03-22 21:31:44 +01:00
Michael Muré
14e3d0a8a0
Merge pull request #670 from MichaelMure/update-doc
...
update doc
2022-03-22 21:30:00 +01:00
Michael Muré
c9cec5b17b
update doc
2022-03-22 21:28:10 +01:00
dependabot[bot]
5f9359ed6a
build(deps): bump github.com/stretchr/testify from 1.7.0 to 1.7.1
...
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify ) from 1.7.0 to 1.7.1.
- [Release notes](https://github.com/stretchr/testify/releases )
- [Commits](https://github.com/stretchr/testify/compare/v1.7.0...v1.7.1 )
---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-03-16 04:11:19 +00:00
