noredink-ui/README.md

96 lines
3.7 KiB
Markdown
Raw Normal View History

2018-02-01 18:27:04 +03:00
# noredink-ui
UI widgets we use.
2018-03-08 01:41:31 +03:00
2018-11-13 02:46:35 +03:00
## Dual publishing notes
This package is published for both 0.18 and 0.19! The 0.18 source code is in src-0.18. While
we still have codebases that utilize either version we'll need to make updates to any version
after 6.0.0 in both src and src-0.18. Eventually, everything will be updated to 0.19 at which
point we will delete src-0.18 and stop publishing for Elm 0.18.
## Versioning policy
We try to avoid breaking changes and the associated major version bumps in this package. The reason for that is to avoid the following scenario:
```
|
x 4.6.0: Adding RadioButton widget
|
x 5.0.0: Breaking change in the TextArea widget
|
x 5.0.1: Styling fix in the Checkbox widget
|
```
Suppose you just released version `5.0.1`, a small styling fix in the checkbox widget, for a story you're working on. If the project you're working in currently pulls in `noredink-ui` at version `4.x`, then getting to your styling fix means pulling in a new major version of `noredink-ui`. This breaks all `TextArea` widgets across the project, so those will need to be fixed before you can do anything else, potentially a big effort.
To prevent these big Yaks from suddenly showing up in seemingly trivial tasks we prefer to avoid breaking changes in the package. Instead when we need to make a breaking change in a widget, we create a new module for it `Nri.Ui.MyWidget.VX`. Similarly, when we build custom elements in JavaScript we create a file `lib/MyWidget/VX.js` and define a custom element `nri-mywidget-vX`.
We should change this process if we feel it's not working for us!
## Moving Widgets to `noredink-ui`
If you are moving in a widget from the monolith:
- Copy the contents of `Nri.SomeModule` and its tests to `Nri.Ui.SomeModule.V1` in `noredink-ui`
- Publish!
- If `Nri.Ui.SomeModule.V1` is a direct copy of `Nri.SomeModule`, switch over to it everywhere!
- If `Nri.Ui.SomeModule.V1` makes changes, rename `Nri.SomeModule` to `Nri.DEPRECATEDSomeModule` in the monolith and start using `Nri.Ui.SomeModule.V1` where you need it
2018-08-22 00:23:27 +03:00
## Phasing out old versions
Our goal is to gradually move to the newest version of each widget, and remove the old versions when they are no longer used.
Currently, `noredink-ui` is used by the monolith and by CCS. When neither of these repos use a version of a widget, it can be deleted. (Note: this will be a major version bump, so you may want to batch deletions together.)
When touching code that uses a widget, prefer upgrading to the latest version.
2018-03-08 01:41:31 +03:00
## Examples
This repo contains an app showcasing all of these UI widgets.
To see them locally:
```
make styleguide-app/elm.js
2018-03-08 01:41:31 +03:00
```
Open `styleguide-app/index.html` in your browser.
2018-03-08 01:41:31 +03:00
Alternatively, you may use elm-reactor. Please be aware that you'll need to globally
install fonts (in particular, Muli) if you go this route.
2018-10-04 21:16:47 +03:00
If you'd like to test your widget in the monolith before publishing, check out the helpful tips [here](https://paper.dropbox.com/doc/Grafting-noredink-ui-into-the-monolith--AOae7awXY8Br7YEhbZunUEZdAg-ff7N9zwMyRR2D5Umza5Ez).
## Tests
Run tests with
```
make test
```
### CI (Travis)
Travis will run `make ci` to verify everything looks good.
You can run this locally to catch errors before you push!
## Deploying
Once your PR is merged, you can publish `master` as a new version:
Run the following to bump && publish the version in `elm-packages.json`:
```
elm-package bump
git tag -a 5.10.0 -m "release version 5.10.0"
git push origin master --tags
elm-package publish
```
You can also add a tag in https://github.com/NoRedInk/noredink-ui/releases/new if you want to add more detail.
2018-10-29 23:33:40 +03:00
Once you've published, you should see the latest version at the top of https://dmy.github.io/elm-0.18-packages/.