mirror of
https://github.com/NoRedInk/noredink-ui.git
synced 2024-11-13 07:48:26 +03:00
update ownership
This commit is contained in:
parent
b0680bb9e8
commit
378a5eec94
12
.github/pull_request_template.md
vendored
12
.github/pull_request_template.md
vendored
@ -58,9 +58,9 @@ Please link to any relevant context and stories.
|
||||
- e.g., as a dev, I can conveniently add an `nriDescription`
|
||||
- and adding a new feature to the component will _not_ require major API changes to the component
|
||||
- [ ] Please assign the following reviewers:
|
||||
- [ ] Someone from your team who can review your PR in full and review requirements from your team's perspective.
|
||||
- [ ] [team-accessibilibats-a11ybats](https://github.com/orgs/NoRedInk/teams/team-accessibilibats-a11ybats) - Someone from this group will review your PR for accessibility and adherence to component library foundations.
|
||||
- [ ] If there are user-facing changes, a designer. (You may want to direct your designer to the [deploy preview](https://github.com/NoRedInk/noredink-ui#reviews--preview-environments) for easy review):
|
||||
- [ ] Someone from your team who can review your PR in full and review requirements from your team's perspective.
|
||||
- [ ] Component library owner - Someone from this group will review your PR for accessibility and adherence to component library foundations.
|
||||
- [ ] If there are user-facing changes, a designer. (You may want to direct your designer to the [deploy preview](https://github.com/NoRedInk/noredink-ui#reviews--preview-environments) for easy review):
|
||||
- For writing-related component changes, add Stacey (staceyadams)
|
||||
- For quiz engine-related components, add Ravi (ravi-morbia)
|
||||
- For a11y-related changes to general components, add Ben (bendansby)
|
||||
@ -101,9 +101,9 @@ Please link to any relevant context and stories.
|
||||
- [ ] If this is a new major version of the component, our team has stories created to upgrade all instances of the old component. Here are links to the stories:
|
||||
- add your story links here OR just write this is not a new major version
|
||||
- [ ] Please assign the following reviewers:
|
||||
- [ ] Someone from your team who can review your PR in full and review requirements from your team's perspective.
|
||||
- [ ] [team-accessibilibats-a11ybats](https://github.com/orgs/NoRedInk/teams/team-accessibilibats-a11ybats) - Someone from this group will review your PR for accessibility and adherence to component library foundations.
|
||||
- [ ] If there are user-facing changes, a designer. (You may want to direct your designer to the [deploy preview](https://github.com/NoRedInk/noredink-ui#reviews--preview-environments) for easy review):
|
||||
- [ ] Someone from your team who can review your PR in full and review requirements from your team's perspective.
|
||||
- [ ] Component library owner - Someone from this group will review your PR for accessibility and adherence to component library foundations.
|
||||
- [ ] If there are user-facing changes, a designer. (You may want to direct your designer to the [deploy preview](https://github.com/NoRedInk/noredink-ui#reviews--preview-environments) for easy review):
|
||||
- For writing-related component changes, add Stacey (staceyadams)
|
||||
- For quiz engine-related components, add Ravi (ravi-morbia)
|
||||
- For a11y-related changes to general components, add Ben (bendansby)
|
||||
|
Loading…
Reference in New Issue
Block a user