NoRedInk/noredink-ui
1
1
Fork 0
mirror of https://github.com/NoRedInk/noredink-ui.git synced 2024-09-21 04:07:54 +03:00
Code Issues Packages Projects Releases Wiki Activity

Update pull_request_template.md with new designer pingage info

Browse Source
This commit is contained in:
Ben Dansby 2023-06-14 15:54:00 -07:00 committed by GitHub
parent 59af0452cb
commit 3d92c49e22
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
.github/pull_request_template.md vendored
View File

@ -36,8 +36,12 @@ Please link to any relevant context and stories.
## :framed_picture: What does this change look like?
- [ ] Follow the the [Guidelines for an optimal design ping](https://paper.dropbox.com/doc/Guidelines-for-Sharing-User-Facing-Changes-with-Design--BpL8hpJLMugy6033aT5m0JdaAg-bdKGQtYH9qO9I00hUkA6k) to add helpful screenshots/videos for design.
- [ ] @ mention the design team on this PR to request approval on your changes. A designer will "thumbs up" react to your PR if they approve it, or will leave comments if it's not quite approved yet.
- Fill in with screenshots, movies, and states, and add a designer as a reviewer if there are user-facing changes:
- For writing-related component changes, add Stacey (@staceyadams)
- For quiz engine-related components, add Ravi (@ravi-morbia)
- For a11y-related changes to general components, add Ben (@bendansby)
- For general component-related changes or if you’re not sure about something, add the Design group (@NoRedInk/design)
- Guidelines for an optimal design review: https://paper.dropbox.com/doc/Guidelines-for-Sharing-User-Facing-Changes-with-Design--BpL8hpJLMugy6033aT5m0JdaAg-bdKGQtYH9qO9I00hUkA6k
## Component completion checklist