From 424bd1854c639f368caecac8ee4627b104b879f9 Mon Sep 17 00:00:00 2001
From: Tessa Kelly <tessakkelly@gmail.com>
Date: Fri, 20 Nov 2020 10:45:35 -0800
Subject: [PATCH] :skull: remove the invisible label. having an invisible label
 makes it easier to make bad UX decisions.

---
 src/Nri/Ui/RadioButton/V2.elm           | 40 ++++++++-----------------
 styleguide-app/Examples/RadioButton.elm | 19 ------------
 2 files changed, 12 insertions(+), 47 deletions(-)

diff --git a/src/Nri/Ui/RadioButton/V2.elm b/src/Nri/Ui/RadioButton/V2.elm
index 65a3911a..ba7a3952 100644
--- a/src/Nri/Ui/RadioButton/V2.elm
+++ b/src/Nri/Ui/RadioButton/V2.elm
@@ -2,8 +2,8 @@ module Nri.Ui.RadioButton.V2 exposing (view, premium)
 
 {-| Changes from V1:
 
-- adds an outline when a radio button is focused
-- remove NoOp/event swallowing (it broke default radio button behavior)
+  - adds an outline when a radio button is focused
+  - remove NoOp/event swallowing (it broke default radio button behavior)
 
 @docs view, premium
 
@@ -42,7 +42,6 @@ view :
     , name : String
     , selectedValue : Maybe a
     , onSelect : a -> msg
-    , showLabel : Bool
     , valueToString : a -> String
     }
     -> Html msg
@@ -52,7 +51,6 @@ view config =
         , value = config.value
         , name = config.name
         , selectedValue = config.selectedValue
-        , showLabel = config.showLabel
         , isLocked = False
         , isDisabled = False
         , onSelect = config.onSelect
@@ -102,7 +100,6 @@ premium config =
         , isLocked = isLocked
         , isDisabled = config.isDisabled
         , onSelect = config.onSelect
-        , showLabel = True
         , valueToString = config.valueToString
         , premiumMsg = Just config.premiumMsg
         , showPennant =
@@ -126,7 +123,6 @@ type alias InternalConfig a msg =
     , isLocked : Bool
     , isDisabled : Bool
     , onSelect : a -> msg
-    , showLabel : Bool
     , premiumMsg : Maybe msg
     , valueToString : a -> String
     , showPennant : Bool
@@ -179,15 +175,7 @@ internalView config =
                 , ( "Nri-RadioButton-RadioButtonChecked", isChecked )
                 ]
             , css
-                [ if not config.showLabel then
-                    -- Invisible label styles
-                    Css.batch
-                        [ Css.height (px 28) -- Hardcode height for invisible labels so radio button image appears- normally, label height is set by the text
-                        , padding4 (px 4) zero (px 4) (px 28)
-                        ]
-
-                  else
-                    padding4 (px 4) zero (px 4) (px 40)
+                [ padding4 (px 4) zero (px 4) (px 40)
                 , if config.isDisabled then
                     Css.batch
                         [ color Colors.gray45
@@ -212,20 +200,16 @@ internalView config =
                 , isChecked = isChecked
                 }
             , span
-                (case ( config.showLabel, config.showPennant ) of
-                    ( False, _ ) ->
-                        Style.invisible
-
-                    ( True, False ) ->
-                        [ css [ verticalAlign middle ] ]
-
-                    ( True, True ) ->
-                        [ css
-                            [ displayFlex
-                            , alignItems center
-                            , Css.height (px 20)
-                            ]
+                (if config.showPennant then
+                    [ css
+                        [ displayFlex
+                        , alignItems center
+                        , Css.height (px 20)
                         ]
+                    ]
+
+                 else
+                    [ css [ verticalAlign middle ] ]
                 )
                 [ Html.text config.label
                 , viewIf
diff --git a/styleguide-app/Examples/RadioButton.elm b/styleguide-app/Examples/RadioButton.elm
index c3cea3f0..197a19ce 100644
--- a/styleguide-app/Examples/RadioButton.elm
+++ b/styleguide-app/Examples/RadioButton.elm
@@ -58,7 +58,6 @@ view model =
     [ Heading.h3 [] [ Html.text "RadioButton" ]
     , Heading.h4 [] [ Html.text "view" ]
     , viewVanilla model
-    , viewInvisibleLabel model
     , Heading.h4 [] [ Html.text "premium" ]
     , viewPremium model
     , Modal.info
@@ -91,7 +90,6 @@ viewVanilla state =
     div [ css [ Css.margin (Css.px 8) ] ]
         [ RadioButton.view
             { label = "Cats"
-            , showLabel = True
             , value = "Cats"
             , name = "radio-button-examples"
             , selectedValue = state.selectedValue
@@ -100,7 +98,6 @@ viewVanilla state =
             }
         , RadioButton.view
             { label = "Dogs"
-            , showLabel = True
             , value = "Dogs"
             , name = "radio-button-examples"
             , selectedValue = state.selectedValue
@@ -110,22 +107,6 @@ viewVanilla state =
         ]
 
 
-viewInvisibleLabel : State -> Html Msg
-viewInvisibleLabel state =
-    div [ css [ Css.margin (Css.px 8) ] ]
-        [ Heading.h4 [] [ Html.text "Invisible Label" ]
-        , RadioButton.view
-            { label = "Shh"
-            , showLabel = False
-            , value = "I'm a secret... but not to screen readers"
-            , name = "Secret"
-            , selectedValue = state.selectedValue
-            , onSelect = Select
-            , valueToString = \_ -> "i-m-a-secret-but-not-to-screen-readers"
-            }
-        ]
-
-
 viewPremium : State -> Html Msg
 viewPremium state =
     let