From 47e57c559496a248b220a4be3eaf718f02e9c1b1 Mon Sep 17 00:00:00 2001 From: Tessa Kelly Date: Thu, 14 Apr 2022 14:01:28 -0700 Subject: [PATCH] Fix Balloon color contrast failure by switching to greenDarkest bg color --- script/puppeteer-tests.js | 1 - src/Nri/Ui/Balloon/V1.elm | 8 ++++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/script/puppeteer-tests.js b/script/puppeteer-tests.js index fb0f044a..91a63aa9 100644 --- a/script/puppeteer-tests.js +++ b/script/puppeteer-tests.js @@ -71,7 +71,6 @@ describe('UI tests', function () { const skippedRules = { 'Accordion': ['heading-order', 'region'], - 'Balloon': ['color-contrast'], 'Checkbox': ['region'], 'Loading': ['color-contrast'], 'Menu': ['region'], diff --git a/src/Nri/Ui/Balloon/V1.elm b/src/Nri/Ui/Balloon/V1.elm index bda78acf..f6ac2a65 100644 --- a/src/Nri/Ui/Balloon/V1.elm +++ b/src/Nri/Ui/Balloon/V1.elm @@ -326,8 +326,8 @@ balloonTheme theme = Green -> batch - [ backgroundColor Colors.greenDark - , border3 (px 1) solid Colors.greenDark + [ backgroundColor Colors.greenDarkest + , border3 (px 1) solid Colors.greenDarkest , Fonts.baseFont , fontSize (px 15) , color Colors.white @@ -439,8 +439,8 @@ arrowTheme theme = Green -> batch - [ backgroundColor Colors.greenDark - , border3 (px 1) solid Colors.greenDark + [ backgroundColor Colors.greenDarkest + , border3 (px 1) solid Colors.greenDarkest , Fonts.baseFont , fontSize (px 15) , color Colors.white