NoRedInk/noredink-ui
1
1
Fork 0
mirror of https://github.com/NoRedInk/noredink-ui.git synced 2024-11-26 09:11:01 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix CI

Browse Source
This commit is contained in:
Tessa Kelly 2022-12-05 17:22:34 -07:00
parent 58c29c18d4
commit 556581317f
5 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
elm.json
View File

@ -56,6 +56,7 @@
"Nri.Ui.Panel.V1",
"Nri.Ui.Pennant.V2",
"Nri.Ui.PremiumCheckbox.V8",
"Nri.Ui.QuestionBox.V1",
"Nri.Ui.RadioButton.V4",
"Nri.Ui.RingGauge.V1",
"Nri.Ui.SegmentedControl.V14",

3
script/puppeteer-tests.js
View File

@ -150,9 +150,10 @@ describe("UI tests", function () {
};
const skippedRules = {
// See https://github.com/dequelabs/axe-core/issues/3649 -- we may be able to remove the Highlighter & Mark skipped rule
// See https://github.com/dequelabs/axe-core/issues/3649 -- we may be able to remove the Highlighter, Mark, and Block skipped rule
Highlighter: ["aria-roledescription"],
Block: ["aria-roledescription"],
QuestionBox: ["aria-roledescription"],
// Loading's color contrast check seems to change behavior depending on whether Percy snapshots are taken or not
Loading: ["color-contrast"],
RadioButton: ["duplicate-id"],

7
src/Nri/Ui/QuestionBox/V1.elm
View File

@ -24,7 +24,6 @@ module Nri.Ui.QuestionBox.V1 exposing
-}
import Browser.Events
import Css
import Css.Global
import Dict
@ -33,19 +32,20 @@ import Html.Styled exposing (..)
import Html.Styled.Attributes as Attributes exposing (alt, css, id, src)
import Json.Decode as Decode exposing (Decoder)
import List.Extra
import Markdown
import Nri.Ui.Balloon.V2 as Balloon
import Nri.Ui.Button.V10 as Button
import Nri.Ui.Colors.V1 as Colors
import Nri.Ui.Html.Attributes.V2 exposing (nriDescription)
{-| -}
type alias QuestionBox msg =
{ markdown : String
, actions : List { label : String, onClick : msg }
}
{-| -}
containerId : String -> String
containerId id =
"Nri-Scaffolding-QuestionBox-" ++ id
@ -229,6 +229,7 @@ alignTarget { anchors, container } =
|> (\( highlightStart, highlightEnd ) -> (highlightStart + highlightEnd) / 2 - container.x)
{-| -}
viewStandalone : QuestionBox msg -> String -> Html msg
viewStandalone questionBox idString =
div
@ -242,6 +243,7 @@ viewStandalone questionBox idString =
]
{-| -}
viewAnchored : QuestionBox msg -> String -> AnchoredBoxMeasurementState -> List (Html msg) -> Html msg
viewAnchored questionBox idString state content =
let
@ -280,6 +282,7 @@ viewAnchored questionBox idString state content =
]
{-| -}
viewPointingTo : List (Html msg) -> QuestionBox msg -> Html msg
viewPointingTo content questionBox =
span

4
styleguide-app/Examples/QuestionBox.elm
View File

@ -15,7 +15,7 @@ import Debug.Control.View as ControlView
import EllieLink
import Example exposing (Example)
import Html.Styled exposing (..)
import Html.Styled.Attributes exposing (css, id)
import Html.Styled.Attributes exposing (css)
import Json.Decode
import Json.Encode as Encode
import Markdown
@ -26,7 +26,7 @@ import Nri.Ui.Heading.V3 as Heading
import Nri.Ui.Highlightable.V1 as Highlightable
import Nri.Ui.Highlighter.V1 as Highlighter
import Nri.Ui.HighlighterTool.V1 as Tool
import Nri.Ui.QuestionBox.V1 as QuestionBox exposing (QuestionBox)
import Nri.Ui.QuestionBox.V1 as QuestionBox
import Nri.Ui.Spacing.V1 as Spacing
import Nri.Ui.Table.V6 as Table

1
tests/elm-verify-examples.json
View File

@ -52,6 +52,7 @@
"Nri.Ui.Panel.V1",
"Nri.Ui.Pennant.V2",
"Nri.Ui.PremiumCheckbox.V8",
"Nri.Ui.QuestionBox.V1",
"Nri.Ui.RadioButton.V4",
"Nri.Ui.RingGauge.V1",
"Nri.Ui.SegmentedControl.V14",