NoRedInk/noredink-ui
1
1
Fork 0
mirror of https://github.com/NoRedInk/noredink-ui.git synced 2024-09-21 12:19:03 +03:00
Code Issues Packages Projects Releases Wiki Activity

Use SideNav.V5

Browse Source
This commit is contained in:
Tessa Kelly 2023-08-04 10:04:24 -06:00
parent 0760400550
commit 70a6afafc1
8 changed files with 18 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
component-catalog/src/App.elm
View File

@ -21,7 +21,7 @@ import Nri.Ui.FocusRing.V1 as FocusRing
import Nri.Ui.Header.V1 as Header
import Nri.Ui.MediaQuery.V1 exposing (mobile)
import Nri.Ui.Page.V3 as Page
import Nri.Ui.SideNav.V4 as SideNav
import Nri.Ui.SideNav.V5 as SideNav
import Nri.Ui.Spacing.V1 as Spacing
import Nri.Ui.Sprite.V1 as Sprite
import Nri.Ui.UiIcon.V1 as UiIcon

4
component-catalog/src/Examples/SideNav.elm
View File

@ -18,12 +18,12 @@ import EllieLink
import Example exposing (Example)
import Html.Styled.Attributes exposing (css)
import Nri.Ui.Colors.V1 as Colors
import Nri.Ui.SideNav.V4 as SideNav
import Nri.Ui.SideNav.V5 as SideNav
version : Int
version =
4
5
{-| -}

2
deprecated-modules.csv
View File

@ -1,4 +1,6 @@
Nri.Ui.Block.V4,upgrade to V5
Nri.Ui.Mark.V2,upgrade to V3
Nri.Ui.Message.V3,upgrade to V4
Nri.Ui.SideNav.V4,upgrade to V5
Nri.Ui.Table.V6,upgrade to V7
Nri.Ui.Tabs.V6,upgrade to V8

1 Nri.Ui.Block.V4 upgrade to V5
2 Nri.Ui.Mark.V2 upgrade to V3
3 Nri.Ui.Message.V3 upgrade to V4
4 Nri.Ui.SideNav.V4 upgrade to V5
5 Nri.Ui.Table.V6 upgrade to V7
6 Nri.Ui.Tabs.V6 upgrade to V8

1
elm.json
View File

@ -65,6 +65,7 @@
"Nri.Ui.Select.V9",
"Nri.Ui.Shadows.V1",
"Nri.Ui.SideNav.V4",
"Nri.Ui.SideNav.V5",
"Nri.Ui.SortableTable.V4",
"Nri.Ui.Spacing.V1",
"Nri.Ui.Sprite.V1",

6
forbidden-imports.toml
View File

@ -149,6 +149,9 @@ hint = 'upgrade to V3'
[forbidden."Nri.Ui.Message.V2"]
hint = 'upgrade to V3'
[forbidden."Nri.Ui.Message.V3"]
hint = 'upgrade to V4'
[forbidden."Nri.Ui.Modal.V10"]
hint = 'upgrade to V11'
usages = ['component-catalog-app/Examples/RadioButton.elm']
@ -211,6 +214,9 @@ hint = 'upgrade to V3'
[forbidden."Nri.Ui.SideNav.V3"]
hint = 'upgrade to V4'
[forbidden."Nri.Ui.SideNav.V4"]
hint = 'upgrade to V5'
[forbidden."Nri.Ui.SortableTable.V2"]
hint = 'upgrade to V3'

12
src/Nri/Ui/SideNav/V5.elm
View File

@ -1,4 +1,4 @@
module Nri.Ui.SideNav.V4 exposing
module Nri.Ui.SideNav.V5 exposing
( view, Config, NavAttribute
, collapsible
, navLabel, navId
@ -15,16 +15,10 @@ module Nri.Ui.SideNav.V4 exposing
{-|
### Patch changes
- add missing aria-current=page attribute
- don't render an empty nav when there are no entries
- adjust closed sidenav toggle button styles
### Changes from V4
### Changes from V3
- make the nav configurably collapsible
## View
@docs view, Config, NavAttribute
@docs collapsible

2
tests/Spec/Nri/Ui/SideNav.elm
View File

@ -4,7 +4,7 @@ import Accessibility.Aria as Aria
import Expect exposing (Expectation)
import Html.Attributes as Attributes
import Html.Styled exposing (toUnstyled)
import Nri.Ui.SideNav.V4 as SideNav exposing (Entry)
import Nri.Ui.SideNav.V5 as SideNav exposing (Entry)
import Test exposing (..)
import Test.Html.Query as Query
import Test.Html.Selector exposing (..)

2
tests/elm-verify-examples.json
View File

@ -41,6 +41,7 @@
"Nri.Ui.Loading.V1",
"Nri.Ui.Logo.V1",
"Nri.Ui.Mark.V2",
"Nri.Ui.Mark.V3",
"Nri.Ui.MasteryIcon.V1",
"Nri.Ui.MediaQuery.V1",
"Nri.Ui.Menu.V4",
@ -60,6 +61,7 @@
"Nri.Ui.Select.V9",
"Nri.Ui.Shadows.V1",
"Nri.Ui.SideNav.V4",
"Nri.Ui.SideNav.V5",
"Nri.Ui.SortableTable.V4",
"Nri.Ui.Spacing.V1",
"Nri.Ui.Sprite.V1",