NoRedInk/noredink-ui
1
1
Fork 0
mirror of https://github.com/NoRedInk/noredink-ui.git synced 2024-09-21 20:27:36 +03:00
Code Issues Packages Projects Releases Wiki Activity

Change the racheting accessibility tooling to expect null violations

Browse Source
This commit is contained in:
Tessa Kelly 2020-09-04 14:23:20 -07:00
parent 000c97b92d
commit 8729d8bb4f
1 changed files with 4 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
script/format-axe-report.sh
View File

@ -9,28 +9,11 @@ fi
jq -r -f script/axe-report.jq "$JSON_FILE"
# Hey there! Did this script tell you to check out this file because the
# expected error count went down? Well done! Just change this number to the new
# value.
TARGET_ERRORS=5
# ideally we'd fail on any failures, but we have had a bunch build up over time!
# So right now, we need to fail if the error count is not exactly what we
# expect. This failure reminds us to come back and ratchet down the number of
# failures to the correct value.
NUM_ERRORS="$(jq '.violations | map(.nodes | length) | add' "$JSON_FILE")"
if test "$NUM_ERRORS" -ne "$TARGET_ERRORS"; then
echo "got $NUM_ERRORS errors, but expected $TARGET_ERRORS."
if [ -z "$NUM_ERRORS" ];
then
echo "$NUM_ERRORS accessibility errors"
echo
echo 'If it went down, hooray!'
echo "Check out ${0:-} and change the count to the reported value above."
echo
echo "If it went up, let's fix it instead."
echo "Since there are so many errors right now, a decent debugging strategy is:"
echo
echo " 1. save this output somewhere ('make axe-report > errors.new')"
echo " 2. undo your changes ('git stash' or 'checkout master')"
echo " 3. regenerate the log with 'make axe-report > errors.old'"
echo " 4. see what's new with 'diff -u errors.old errors.new'"
echo "To see these errors, run 'make axe-report > errors.new' and open 'errors.new'"
exit 1
fi