NoRedInk/noredink-ui
1
1
Fork 0
mirror of https://github.com/NoRedInk/noredink-ui.git synced 2024-11-27 03:14:25 +03:00
Code Issues Packages Projects Releases Wiki Activity

Adds expectations against the disabled status

Browse Source
This commit is contained in:
Tessa Kelly 2022-05-16 14:09:16 -07:00
parent 61db0f617f
commit b5058f545e
3 changed files with 28 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
elm.json
View File

@ -98,6 +98,6 @@
"avh4/elm-program-test": "3.3.0 <= v < 4.0.0",
"elm/html": "1.0.0 <= v < 2.0.0",
"elm-explorations/test": "1.2.2 <= v < 2.0.0",
"tesk9/accessible-html": "4.1.0 <= v < 5.0.0"
"tesk9/accessible-html": "5.0.0 <= v < 6.0.0"
}
}

31
tests/Spec/ClickableAttributes.elm
View File

@ -1,5 +1,6 @@
module Spec.ClickableAttributes exposing (suite)
import Accessibility.Aria as Aria
import Accessibility.Role as Role
import ClickableAttributes exposing (ClickableAttributes)
import Expect
@ -25,8 +26,9 @@ linkAttributes =
|> setupLinkTest
|> Expect.all
[ Query.has [ Selector.attribute (href "some-route") ]
, -- should not include redundant roles
, -- should not include a redundant role
Query.hasNot [ Selector.attribute Role.link ]
, Query.hasNot [ Selector.attribute (Aria.disabled True) ]
]
, test "with an external href" <|
\() ->
@ -34,8 +36,9 @@ linkAttributes =
|> setupLinkTest
|> Expect.all
[ Query.has [ Selector.attribute (href "some-route") ]
, -- should not include redundant roles
, -- should not include a redundant role
Query.hasNot [ Selector.attribute Role.link ]
, Query.hasNot [ Selector.attribute (Aria.disabled True) ]
]
, test "with an external href that also supports tracking" <|
\() ->
@ -43,8 +46,9 @@ linkAttributes =
|> setupLinkTest
|> Expect.all
[ Query.has [ Selector.attribute (href "some-route") ]
, -- should not include redundant roles
, -- should not include a redundant role
Query.hasNot [ Selector.attribute Role.link ]
, Query.hasNot [ Selector.attribute (Aria.disabled True) ]
]
, test "with a SPA link" <|
\() ->
@ -52,8 +56,9 @@ linkAttributes =
|> setupLinkTest
|> Expect.all
[ Query.has [ Selector.attribute (href "some-route") ]
, -- should not include redundant roles
, -- should not include a redundant role
Query.hasNot [ Selector.attribute Role.link ]
, Query.hasNot [ Selector.attribute (Aria.disabled True) ]
]
, test "with a link with a method" <|
\() ->
@ -61,8 +66,9 @@ linkAttributes =
|> setupLinkTest
|> Expect.all
[ Query.has [ Selector.attribute (href "some-route") ]
, -- should not include redundant roles
, -- should not include a redundant role
Query.hasNot [ Selector.attribute Role.link ]
, Query.hasNot [ Selector.attribute (Aria.disabled True) ]
]
, test "with a link with tracking" <|
\() ->
@ -70,8 +76,9 @@ linkAttributes =
|> setupLinkTest
|> Expect.all
[ Query.has [ Selector.attribute (href "some-route") ]
, -- should not include redundant roles
, -- should not include a redundant role
Query.hasNot [ Selector.attribute Role.link ]
, Query.hasNot [ Selector.attribute (Aria.disabled True) ]
]
]
@ -87,6 +94,8 @@ disabledLinkAttributes =
[ Query.hasNot [ Selector.attribute (href "some-route") ]
, -- should explicitly be tagged as having the link role
Query.has [ Selector.attribute Role.link ]
, -- should be marked as disabled for screenreader users
Query.has [ Selector.attribute (Aria.disabled True) ]
]
, test "with an external href" <|
\() ->
@ -96,6 +105,8 @@ disabledLinkAttributes =
[ Query.hasNot [ Selector.attribute (href "some-route") ]
, -- should explicitly be tagged as having the link role
Query.has [ Selector.attribute Role.link ]
, -- should be marked as disabled for screenreader users
Query.has [ Selector.attribute (Aria.disabled True) ]
]
, test "with an external href that also supports tracking" <|
\() ->
@ -105,6 +116,8 @@ disabledLinkAttributes =
[ Query.hasNot [ Selector.attribute (href "some-route") ]
, -- should explicitly be tagged as having the link role
Query.has [ Selector.attribute Role.link ]
, -- should be marked as disabled for screenreader users
Query.has [ Selector.attribute (Aria.disabled True) ]
]
, test "with a SPA link" <|
\() ->
@ -114,6 +127,8 @@ disabledLinkAttributes =
[ Query.hasNot [ Selector.attribute (href "some-route") ]
, -- should explicitly be tagged as having the link role
Query.has [ Selector.attribute Role.link ]
, -- should be marked as disabled for screenreader users
Query.has [ Selector.attribute (Aria.disabled True) ]
]
, test "with a link with a method" <|
\() ->
@ -123,6 +138,8 @@ disabledLinkAttributes =
[ Query.hasNot [ Selector.attribute (href "some-route") ]
, -- should explicitly be tagged as having the link role
Query.has [ Selector.attribute Role.link ]
, -- should be marked as disabled for screenreader users
Query.has [ Selector.attribute (Aria.disabled True) ]
]
, test "with a link with tracking" <|
\() ->
@ -132,6 +149,8 @@ disabledLinkAttributes =
[ Query.hasNot [ Selector.attribute (href "some-route") ]
, -- should explicitly be tagged as having the link role
Query.has [ Selector.attribute Role.link ]
, -- should be marked as disabled for screenreader users
Query.has [ Selector.attribute (Aria.disabled True) ]
]
]

4
tests/Spec/Nri/Ui/Tooltip.elm
View File

@ -1,6 +1,6 @@
module Spec.Nri.Ui.Tooltip exposing (spec)
import Accessibility.Widget as Widget
import Accessibility.Aria as Aria
import Html.Attributes as Attributes
import Html.Styled as HtmlStyled
import Nri.Ui.Tooltip.V3 as Tooltip
@ -136,7 +136,7 @@ clickButtonByLabel label =
ProgramTest.simulateDomEvent
(Query.find
[ Selector.tag "button"
, Selector.attribute (Widget.label label)
, Selector.attribute (Aria.label label)
]
)
Event.click