more consistent names for returned components

component-catalog/src/Examples/Carousel.elm

@@ -417,7 +417,7 @@ viewCustomizableWithCombinedControls model =
                 |> indicesForItemCount
                 |> List.map toCombinedCarouselItem
 
-        { tabControls, slides, viewPreviousButton, viewNextButton, containerAttributes } =
+        { tabs, slides, viewPreviousButton, viewNextButton, containerAttributes } =
             Carousel.viewWithCombinedControls
                 { selected = model.selected
                 , slides = List.map Tuple.second allItems
@@ -462,13 +462,13 @@ viewCustomizableWithCombinedControls model =
                 , ( "focusAndSelect", "FocusAndSelect" )
                 , ( "announceAndSelect", "AnnounceAndSelect" )
                 ]
-        , Code.anonymousFunction "{ tabControls, slides, viewPreviousButton, viewNextButton, containerAttributes }"
+        , Code.anonymousFunction "{ tabs, slides, viewPreviousButton, viewNextButton, containerAttributes }"
             (Code.newlineWithIndent 2
-                ++ "section containerAttributes [ slides, tabControls, viewPreviousButton, viewNextButton  ]"
+                ++ "section containerAttributes [ slides, tabs, viewPreviousButton, viewNextButton  ]"
             )
         ]
         0
-    , Html.div containerAttributes [ slides, tabControls, viewPreviousButton, viewNextButton ]
+    , Html.div containerAttributes [ slides, tabs, viewPreviousButton, viewNextButton ]
     )
 
 
@@ -483,7 +483,7 @@ viewCustomizableWithTabControls model =
                 |> indicesForItemCount
                 |> List.map toTabbedCarouselItem
 
-        { controls, slides, containerAttributes } =
+        { tabs, slides, containerAttributes } =
             Carousel.viewWithTabControls
                 { selected = model.selected
                 , slides = List.map Tuple.second allItems
@@ -514,13 +514,13 @@ viewCustomizableWithTabControls model =
                 , ( "focusAndSelect", "FocusAndSelect" )
                 , ( "announceAndSelect", "AnnounceAndSelect" )
                 ]
-        , Code.anonymousFunction "{ controls, slides, containerAttributes }"
+        , Code.anonymousFunction "{ tabs, slides, containerAttributes }"
             (Code.newlineWithIndent 2
-                ++ "section containerAttributes [ slides, controls ]"
+                ++ "section containerAttributes [ slides, tabs ]"
             )
         ]
         0
-    , Html.div containerAttributes [ slides, controls ]
+    , Html.div containerAttributes [ slides, tabs ]
     )
 
 
@@ -715,7 +715,7 @@ type Tip
 viewTestimonials : Testimonial -> Html Msg
 viewTestimonials selected =
     let
-        { controls, slides, containerAttributes } =
+        { tabs, slides, containerAttributes } =
             Carousel.viewWithTabControls
                 { selected = selected
                 , slides =
@@ -748,7 +748,7 @@ viewTestimonials selected =
         , Container.css [ maxWidth (px 210) ]
         , Container.html
             [ slides
-            , controls
+            , tabs
             ]
         ]
 
@@ -762,7 +762,7 @@ type Testimonial
 viewPackages : Package -> Html Msg
 viewPackages selected =
     let
-        { tabControls, slides, viewPreviousButton, viewNextButton, containerAttributes } =
+        { tabs, slides, viewPreviousButton, viewNextButton, containerAttributes } =
             Carousel.viewWithCombinedControls
                 { selected = selected
                 , slides =
@@ -835,7 +835,7 @@ viewPackages selected =
             ]
         , Container.html
             [ div [] [ viewPreviousButton, slides, viewNextButton ]
-            , tabControls
+            , tabs
             ]
         ]
 

src/Nri/Ui/Carousel/V2.elm

@@ -136,7 +136,7 @@ viewWithPreviousAndNextControls config =
 {-| Builds a carousel with tab buttons
 Returns:
 
-  - `controls`: tabs control buttons
+  - `tabs`: tabs control buttons
   - `slides` container with the carousel contents
   - `containerAttributes` attributes that should be used on the parent div of both the button and slides elements
 
@@ -158,7 +158,7 @@ viewWithTabControls :
     , focusAndSelect : { select : id, focus : Maybe String } -> msg
     }
     ->
-        { controls : Html msg
+        { tabs : Html msg
         , slides : Html msg
         , containerAttributes : List (Attribute msg)
         }
@@ -179,7 +179,7 @@ viewWithTabControls config =
                 , tabListStyles = config.tabControlListStyles
                 }
     in
-    { controls = tabList
+    { tabs = tabList
     , slides = tabPanels
     , containerAttributes =
         [ roleAttribute config.role
@@ -192,7 +192,7 @@ viewWithTabControls config =
 {-| Builds a carousel with tab buttons
 Returns:
 
-  - `tabControls`: tabs control buttons
+  - `tabs`: tabs control buttons
   - `slides` container with the carousel contents
   - `viewPreviousButton` previous button
   - `viewNextButton` next button
@@ -220,7 +220,7 @@ viewWithCombinedControls :
     , select : { select : id, announce : Maybe String, focus : Maybe String } -> msg
     }
     ->
-        { tabControls : Html msg
+        { tabs : Html msg
         , viewPreviousButton : Html msg
         , viewNextButton : Html msg
         , slides : Html msg
@@ -244,7 +244,7 @@ viewWithCombinedControls config =
                     , focus = Nothing
                     }
 
-        { controls, slides, containerAttributes } =
+        { tabs, slides, containerAttributes } =
             viewWithTabControls
                 { selected = config.selected
                 , slides =
@@ -293,7 +293,7 @@ viewWithCombinedControls config =
                             }
                     }
     in
-    { tabControls = controls
+    { tabs = tabs
     , slides = slides
     , containerAttributes = containerAttributes
     , viewPreviousButton = viewPreviousButton

tests/Spec/Nri/Ui/Carousel.elm

@@ -292,8 +292,8 @@ viewWithTabControlsSpec =
                                         , focus = focus
                                         }
                             }
-                            |> (\{ controls, slides, containerAttributes } ->
-                                    section containerAttributes [ slides, controls ]
+                            |> (\{ tabs, slides, containerAttributes } ->
+                                    section containerAttributes [ slides, tabs ]
                                )
                             |> toUnstyled
                 }
@@ -441,8 +441,8 @@ viewWithCombinedControlsSpec =
                             , nextButton = { attributes = [], icon = UiIcon.arrowRight, name = "Next" }
                             , select = Select
                             }
-                            |> (\{ tabControls, slides, containerAttributes, viewNextButton, viewPreviousButton } ->
-                                    section containerAttributes [ slides, tabControls, viewNextButton, viewPreviousButton ]
+                            |> (\{ tabs, slides, containerAttributes, viewNextButton, viewPreviousButton } ->
+                                    section containerAttributes [ slides, tabs, viewNextButton, viewPreviousButton ]
                                )
                             |> toUnstyled
                 }