From bb9819fb7b4812528c0dbd5f64f45ad199a703c4 Mon Sep 17 00:00:00 2001 From: Tessa Kelly Date: Thu, 4 Nov 2021 09:33:24 -0700 Subject: [PATCH] Update to V8: --- deprecated-modules.csv | 3 ++- elm.json | 1 + forbidden-imports.toml | 5 ++++- src/Nri/Ui/Select/V8.elm | 4 ++-- styleguide-app/Examples/ClickableSvg.elm | 2 +- styleguide-app/Examples/Select.elm | 4 ++-- styleguide-app/Examples/Svg.elm | 2 +- tests/elm-verify-examples.json | 1 + 8 files changed, 14 insertions(+), 8 deletions(-) diff --git a/deprecated-modules.csv b/deprecated-modules.csv index da42d77b..6276e7ce 100644 --- a/deprecated-modules.csv +++ b/deprecated-modules.csv @@ -5,7 +5,8 @@ Nri.Ui.Menu.V1,upgrade to V3 Nri.Ui.Menu.V2,upgrade to V3 Nri.Ui.Modal.V10,upgrade to V11 Nri.Ui.RadioButton.V1,upgrade to V2 -Nri.Ui.Select.V5,upgrade to V7 +Nri.Ui.Select.V5,upgrade to V8 +Nri.Ui.Select.V7,upgrade to V8 Nri.Ui.Table.V4,upgrade to V5 Nri.Ui.Tabs.V6,upgrade to V7 Nri.Ui.Text.V5,upgrade to V6 diff --git a/elm.json b/elm.json index 866b1847..1dbe5f2d 100644 --- a/elm.json +++ b/elm.json @@ -51,6 +51,7 @@ "Nri.Ui.SegmentedControl.V14", "Nri.Ui.Select.V5", "Nri.Ui.Select.V7", + "Nri.Ui.Select.V8", "Nri.Ui.Slide.V1", "Nri.Ui.SlideModal.V2", "Nri.Ui.SortableTable.V2", diff --git a/forbidden-imports.toml b/forbidden-imports.toml index afc00bc5..2e80bba7 100644 --- a/forbidden-imports.toml +++ b/forbidden-imports.toml @@ -95,7 +95,10 @@ hint = 'upgrade to V14' hint = 'upgrade to V14' [forbidden."Nri.Ui.Select.V5"] -hint = 'upgrade to V7' +hint = 'upgrade to V8' + +[forbidden."Nri.Ui.Select.V7"] +hint = 'upgrade to V8' [forbidden."Nri.Ui.Table.V4"] hint = 'upgrade to V5' diff --git a/src/Nri/Ui/Select/V8.elm b/src/Nri/Ui/Select/V8.elm index ada7bc89..b7f56dd7 100644 --- a/src/Nri/Ui/Select/V8.elm +++ b/src/Nri/Ui/Select/V8.elm @@ -1,6 +1,6 @@ -module Nri.Ui.Select.V7 exposing (Choice, view) +module Nri.Ui.Select.V8 exposing (Choice, view) -{-| Build a select input. +{-| Build a select input with a label, optional guidance, and error messaging. @docs Choice, view diff --git a/styleguide-app/Examples/ClickableSvg.elm b/styleguide-app/Examples/ClickableSvg.elm index e266609e..cfa9f60e 100644 --- a/styleguide-app/Examples/ClickableSvg.elm +++ b/styleguide-app/Examples/ClickableSvg.elm @@ -20,7 +20,7 @@ import Nri.Ui.ClickableSvg.V2 as ClickableSvg import Nri.Ui.Colors.Extra exposing (fromCssColor, toCssColor) import Nri.Ui.Colors.V1 as Colors import Nri.Ui.Heading.V2 as Heading -import Nri.Ui.Select.V7 as Select +import Nri.Ui.Select.V8 as Select import Nri.Ui.Svg.V1 as Svg exposing (Svg) import Nri.Ui.Tooltip.V2 as Tooltip import Nri.Ui.UiIcon.V1 as UiIcon diff --git a/styleguide-app/Examples/Select.elm b/styleguide-app/Examples/Select.elm index b89e01e8..9bd56279 100644 --- a/styleguide-app/Examples/Select.elm +++ b/styleguide-app/Examples/Select.elm @@ -13,14 +13,14 @@ import Html.Styled import Html.Styled.Attributes import KeyboardSupport exposing (Direction(..), Key(..)) import Nri.Ui.Heading.V2 as Heading -import Nri.Ui.Select.V7 as Select +import Nri.Ui.Select.V8 as Select {-| -} example : Example State Msg example = { name = "Select" - , version = 7 + , version = 8 , state = init , update = update , subscriptions = \_ -> Sub.none diff --git a/styleguide-app/Examples/Svg.elm b/styleguide-app/Examples/Svg.elm index 690b4e62..2ae45569 100644 --- a/styleguide-app/Examples/Svg.elm +++ b/styleguide-app/Examples/Svg.elm @@ -17,7 +17,7 @@ import KeyboardSupport exposing (Direction(..), Key(..)) import Nri.Ui.Colors.Extra exposing (fromCssColor, toCssColor) import Nri.Ui.Colors.V1 as Colors import Nri.Ui.Heading.V2 as Heading -import Nri.Ui.Select.V7 as Select +import Nri.Ui.Select.V8 as Select import Nri.Ui.Svg.V1 as Svg import Nri.Ui.UiIcon.V1 as UiIcon import SolidColor exposing (SolidColor) diff --git a/tests/elm-verify-examples.json b/tests/elm-verify-examples.json index f2f78779..b4b0790b 100644 --- a/tests/elm-verify-examples.json +++ b/tests/elm-verify-examples.json @@ -47,6 +47,7 @@ "Nri.Ui.SegmentedControl.V14", "Nri.Ui.Select.V5", "Nri.Ui.Select.V7", + "Nri.Ui.Select.V8", "Nri.Ui.Slide.V1", "Nri.Ui.SlideModal.V2", "Nri.Ui.SortableTable.V2",