From bd5f5fd2475fde1c394d7a3eb9a51b5bd4459305 Mon Sep 17 00:00:00 2001 From: Tessa Kelly Date: Wed, 21 Oct 2020 17:40:34 -0700 Subject: [PATCH] Fix test failures --- src/Nri/Ui/ClickableSvg/V2.elm | 1 - src/Nri/Ui/Message/V2.elm | 14 +++++++------- src/Nri/Ui/RadioButton/V1.elm | 6 +++--- src/Nri/Ui/Tooltip/V2.elm | 6 +++--- tests/elm-verify-examples.json | 1 + 5 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/Nri/Ui/ClickableSvg/V2.elm b/src/Nri/Ui/ClickableSvg/V2.elm index 0dd955a2..ed6e22ff 100644 --- a/src/Nri/Ui/ClickableSvg/V2.elm +++ b/src/Nri/Ui/ClickableSvg/V2.elm @@ -53,7 +53,6 @@ import Html.Styled as Html exposing (Html) import Html.Styled.Attributes as Attributes import Nri.Ui.Colors.V1 as Colors import Nri.Ui.Svg.V1 as Svg exposing (Svg) -import Nri.Ui.Tooltip.V1 as Tooltip exposing (Tooltip) {-| -} diff --git a/src/Nri/Ui/Message/V2.elm b/src/Nri/Ui/Message/V2.elm index 86cb6062..58e276bd 100644 --- a/src/Nri/Ui/Message/V2.elm +++ b/src/Nri/Ui/Message/V2.elm @@ -61,7 +61,7 @@ import Html.Styled.Attributes exposing (css) import Html.Styled.Events exposing (onClick) import Markdown import Nri.Ui -import Nri.Ui.ClickableSvg.V1 as ClickableSvg +import Nri.Ui.ClickableSvg.V2 as ClickableSvg import Nri.Ui.Colors.V1 as Colors import Nri.Ui.Fonts.V1 as Fonts import Nri.Ui.Svg.V1 as NriSvg exposing (Svg) @@ -682,8 +682,8 @@ tinyDismissButton msg = [ ClickableSvg.button "Dismiss message" UiIcon.x [ ClickableSvg.onClick msg - , ClickableSvg.width (px 16) - , ClickableSvg.height (px 16) + , ClickableSvg.exactWidth 16 + , ClickableSvg.exactHeight 16 , ClickableSvg.css [ Css.verticalAlign Css.middle , Css.marginLeft (Css.px 5) @@ -702,8 +702,8 @@ largeDismissButton msg = [ ClickableSvg.button "Dismiss message" UiIcon.x [ ClickableSvg.onClick msg - , ClickableSvg.width (px 16) - , ClickableSvg.height (px 16) + , ClickableSvg.exactWidth 16 + , ClickableSvg.exactHeight 16 ] ] @@ -717,7 +717,7 @@ bannerDismissButton msg = [ ClickableSvg.button "Dismiss banner" UiIcon.x [ ClickableSvg.onClick msg - , ClickableSvg.width (px 16) - , ClickableSvg.height (px 16) + , ClickableSvg.exactWidth 16 + , ClickableSvg.exactHeight 16 ] ] diff --git a/src/Nri/Ui/RadioButton/V1.elm b/src/Nri/Ui/RadioButton/V1.elm index 703d071d..ce801c20 100644 --- a/src/Nri/Ui/RadioButton/V1.elm +++ b/src/Nri/Ui/RadioButton/V1.elm @@ -19,7 +19,7 @@ import Html.Styled as Html import Html.Styled.Attributes exposing (..) import Html.Styled.Events exposing (onClick, stopPropagationOn) import Json.Decode -import Nri.Ui.ClickableSvg.V1 as ClickableSvg +import Nri.Ui.ClickableSvg.V2 as ClickableSvg import Nri.Ui.Colors.V1 as Colors import Nri.Ui.Data.PremiumLevel as PremiumLevel exposing (PremiumLevel) import Nri.Ui.Fonts.V1 as Fonts @@ -250,8 +250,8 @@ internalView config = ClickableSvg.button "Premium" Pennant.premiumFlag [ ClickableSvg.onClick config.premiumMsg - , ClickableSvg.width (px 26) - , ClickableSvg.height (px 24) + , ClickableSvg.exactWidth 26 + , ClickableSvg.exactHeight 24 , ClickableSvg.css [ marginLeft (px 8) ] ] ) diff --git a/src/Nri/Ui/Tooltip/V2.elm b/src/Nri/Ui/Tooltip/V2.elm index e609a486..e7d3f8a4 100644 --- a/src/Nri/Ui/Tooltip/V2.elm +++ b/src/Nri/Ui/Tooltip/V2.elm @@ -83,7 +83,7 @@ import Html.Styled.Attributes as Attributes import Html.Styled.Events as Events import Json.Encode as Encode import Nri.Ui -import Nri.Ui.ClickableSvg.V1 as ClickableSvg +import Nri.Ui.ClickableSvg.V2 as ClickableSvg import Nri.Ui.Colors.V1 as Colors import Nri.Ui.Fonts.V1 as Fonts import Nri.Ui.Svg.V1 as Svg @@ -453,8 +453,8 @@ toggleTip { label } attributes_ = \events -> ClickableSvg.button label UiIcon.help - [ ClickableSvg.width (Css.px 20) - , ClickableSvg.height (Css.px 20) + [ ClickableSvg.exactWidth 20 + , ClickableSvg.exactHeight 20 , ClickableSvg.custom events , ClickableSvg.css [ -- Take up enough room within the document flow diff --git a/tests/elm-verify-examples.json b/tests/elm-verify-examples.json index 2b220317..a0bdab62 100644 --- a/tests/elm-verify-examples.json +++ b/tests/elm-verify-examples.json @@ -11,6 +11,7 @@ "Nri.Ui.Callout.V1", "Nri.Ui.Checkbox.V5", "Nri.Ui.ClickableSvg.V1", + "Nri.Ui.ClickableSvg.V2", "Nri.Ui.ClickableText.V3", "Nri.Ui.Colors.Extra", "Nri.Ui.Colors.V1",