NoRedInk/noredink-ui
1
1
Fork 0
mirror of https://github.com/NoRedInk/noredink-ui.git synced 2025-01-02 11:28:01 +03:00
Code Issues Packages Projects Releases Wiki Activity

Remove some imports exposing (..)

Browse Source 
To make it easier to understand where a value is coming from.

Also, we should now be in a better place to replace `Html` in favor of
`Html.Styled`.
This commit is contained in:
Jasper Woudenberg 2018-05-18 10:23:59 +02:00
parent 670563cc83
commit c43dca766b
1 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/Nri/Ui/TextArea/V2.elm
View File

@ -26,9 +26,9 @@ explicitly using an elm-css length value.
import Accessibility.Style
import Css exposing (LengthOrMinMaxDimension)
import DEPRECATED.Css
import Html exposing (..)
import Html.Attributes exposing (..)
import Html.Events exposing (onInput)
import Html exposing (Html)
import Html.Attributes as Attributes
import Html.Events as Events
import Nri.Ui.InputStyles exposing (CssClasses(..))
import Nri.Ui.Styles.V1
import Nri.Ui.Util exposing (dashify, removePunctuation)
@ -85,18 +85,18 @@ view_ textAreaStyle model =
textAreaStyle == ContentCreationStyle
sharedAttributes =
[ onInput model.onInput
, Html.Attributes.id (generateId model.label)
[ Events.onInput model.onInput
, Attributes.id (generateId model.label)
, styles.class [ Input ]
, autofocus model.autofocus
, placeholder model.placeholder
, attribute "data-gramm" "false" -- disables grammarly to prevent https://github.com/NoRedInk/NoRedInk/issues/14859
, Attributes.autofocus model.autofocus
, Attributes.placeholder model.placeholder
, Attributes.attribute "data-gramm" "false" -- disables grammarly to prevent https://github.com/NoRedInk/NoRedInk/issues/14859
-- Html.Styled migration consideration:
, [ Css.minHeight model.minimumHeight ] |> DEPRECATED.Css.asPairs |> Html.Attributes.style
, [ Css.minHeight model.minimumHeight ] |> DEPRECATED.Css.asPairs |> Attributes.style
]
in
div
Html.div
[ styles.classList
[ ( Container, True )
, ( IsInError, model.isInError )
@ -122,7 +122,7 @@ view_ textAreaStyle model =
(sharedAttributes
++ [ -- setting the default value via a text node doesn't play well with the custom element,
-- but we'll be able to switch to the regular value property in 0.19 anyway
defaultValue model.value
Attributes.defaultValue model.value
]
)
[]
@ -131,14 +131,14 @@ view_ textAreaStyle model =
[ Html.text model.value ]
, if not model.showLabel then
Html.label
[ for (generateId model.label)
[ Attributes.for (generateId model.label)
, styles.class [ Label ]
, Accessibility.Style.invisible
]
[ Html.text model.label ]
else
Html.label
[ for (generateId model.label)
[ Attributes.for (generateId model.label)
, styles.class [ Label ]
]
[ Html.text model.label ]