NoRedInk/noredink-ui
1
1
Fork 0
mirror of https://github.com/NoRedInk/noredink-ui.git synced 2024-09-21 12:19:03 +03:00
Code Issues Packages Projects Releases Wiki Activity

more renames for consistency

Browse Source
This commit is contained in:
Juan Edi 2023-09-06 15:45:46 -03:00
parent f70f11ea88
commit ce39fdd949
3 changed files with 53 additions and 53 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

60
component-catalog/src/Examples/Carousel.elm
View File

@ -537,7 +537,7 @@ toNonTabbedCarouselItem :
, idString : String
, name : String
, visibleLabelId : Maybe String
, slideHtml : Html msg
, slideView : Html msg
}
)
toNonTabbedCarouselItem id =
@ -553,14 +553,14 @@ toNonTabbedCarouselItem id =
, ( "idString", Code.string (String.fromInt id) )
, ( "name", Code.string ("Slide " ++ humanizedId) )
, ( "visibleLabelId", Code.maybe Nothing )
, ( "slideHtml", "Html.text " ++ Code.string ("Contents for slide " ++ humanizedId) )
, ( "slideView", "Html.text " ++ Code.string ("Contents for slide " ++ humanizedId) )
]
4
, { id = id
, idString = idString
, name = "Slide " ++ humanizedId
, visibleLabelId = Nothing
, slideHtml = Html.text ("Contents for slide " ++ humanizedId)
, slideView = Html.text ("Contents for slide " ++ humanizedId)
}
)
@ -571,8 +571,8 @@ toTabbedCarouselItem :
( String
, { id : Int
, idString : String
, slideHtml : Html msg
, tabControlHtml : Html Never
, slideView : Html msg
, tabView : Html Never
}
)
toTabbedCarouselItem id =
@ -586,14 +586,14 @@ toTabbedCarouselItem id =
( Code.recordMultiline
[ ( "id", Code.int id )
, ( "idString", Code.string (String.fromInt id) )
, ( "tabControlHtml", "Html.text " ++ Code.string ("Slide " ++ humanizedId) )
, ( "slideHtml", "Html.text " ++ Code.string ("Contents for slide " ++ humanizedId) )
, ( "tabView", "Html.text " ++ Code.string ("Slide " ++ humanizedId) )
, ( "slideView", "Html.text " ++ Code.string ("Contents for slide " ++ humanizedId) )
]
3
, { id = id
, idString = idString
, tabControlHtml = Html.text ("Slide " ++ humanizedId)
, slideHtml = Html.text ("Contents for slide " ++ humanizedId)
, tabView = Html.text ("Slide " ++ humanizedId)
, slideView = Html.text ("Contents for slide " ++ humanizedId)
}
)
@ -606,8 +606,8 @@ toCombinedCarouselItem :
, idString : String
, name : String
, visibleLabelId : Maybe String
, slideHtml : Html msg
, tabControlHtml : Html Never
, slideView : Html msg
, tabView : Html Never
}
)
toCombinedCarouselItem id =
@ -623,16 +623,16 @@ toCombinedCarouselItem id =
, ( "idString", Code.string (String.fromInt id) )
, ( "name", Code.string ("Slide " ++ humanizedId) )
, ( "visibleLabelId", Code.maybe Nothing )
, ( "tabControlHtml", "Html.text " ++ Code.string ("Slide " ++ humanizedId) )
, ( "slideHtml", "Html.text " ++ Code.string ("Contents for slide " ++ humanizedId) )
, ( "tabView", "Html.text " ++ Code.string ("Slide " ++ humanizedId) )
, ( "slideView", "Html.text " ++ Code.string ("Contents for slide " ++ humanizedId) )
]
3
, { id = id
, idString = idString
, name = "Slide " ++ humanizedId
, visibleLabelId = Nothing
, tabControlHtml = Html.text ("Slide " ++ humanizedId)
, slideHtml = Html.text ("Contents for slide " ++ humanizedId)
, tabView = Html.text ("Slide " ++ humanizedId)
, slideView = Html.text ("Contents for slide " ++ humanizedId)
}
)
@ -648,19 +648,19 @@ viewTips selected =
, idString = "avoid-white-after-labor-day"
, name = "Avoid White After Labor Day"
, visibleLabelId = Nothing
, slideHtml = text "Avoid wearing white after Labor Day"
, slideView = text "Avoid wearing white after Labor Day"
}
, { id = AvoidNavyAndBlack
, idString = "avoid-navy-and-black"
, name = "Avoid pairing navy and black"
, visibleLabelId = Nothing
, slideHtml = text "Avoid pairing navy and black"
, slideView = text "Avoid pairing navy and black"
}
, { id = TailorOffTheShelfClothes
, idString = "tailor-off-the-shelf-clothes"
, name = "Tailor off the shelf clothes"
, visibleLabelId = Nothing
, slideHtml = text "Tailor off the shelf clothes"
, slideView = text "Tailor off the shelf clothes"
}
]
, previousButton =
@ -721,18 +721,18 @@ viewTestimonials selected =
, slides =
[ { id = GreatService
, idString = "great-service"
, slideHtml = text "Great service!"
, tabControlHtml = span Style.invisible [ text "Testimonial 1" ]
, slideView = text "Great service!"
, tabView = span Style.invisible [ text "Testimonial 1" ]
}
, { id = GreatProduct
, idString = "great-product"
, slideHtml = text "Great product!"
, tabControlHtml = span Style.invisible [ text "Testimonial 2" ]
, slideView = text "Great product!"
, tabView = span Style.invisible [ text "Testimonial 2" ]
}
, { id = GreatMission
, idString = "great-mission"
, slideHtml = text "Great mission!"
, tabControlHtml = span Style.invisible [ text "Testimonial 3" ]
, slideView = text "Great mission!"
, tabView = span Style.invisible [ text "Testimonial 3" ]
}
]
, tabStyles = tabStyles
@ -770,22 +770,22 @@ viewPackages selected =
, idString = "free-trial"
, name = "Free trial"
, visibleLabelId = Nothing
, slideHtml = text "Free trial"
, tabControlHtml = span Style.invisible [ text "Free trial" ]
, slideView = text "Free trial"
, tabView = span Style.invisible [ text "Free trial" ]
}
, { id = DeveloperTier
, idString = "developer-tier"
, name = "Developer Tier"
, visibleLabelId = Nothing
, slideHtml = text "Developer Tier"
, tabControlHtml = span Style.invisible [ text "Developer tier" ]
, slideView = text "Developer Tier"
, tabView = span Style.invisible [ text "Developer tier" ]
}
, { id = EnterpriseTier
, idString = "enterprise-tier"
, name = "Enterprise Tier"
, visibleLabelId = Nothing
, slideHtml = text "Enterprise Tier"
, tabControlHtml = span Style.invisible [ text "Enterprise tier" ]
, slideView = text "Enterprise Tier"
, tabView = span Style.invisible [ text "Enterprise tier" ]
}
]
, tabStyles = tabStyles

20
src/Nri/Ui/Carousel/V2.elm
View File

@ -57,7 +57,7 @@ viewWithPreviousAndNextControls :
, idString : String
, name : String
, visibleLabelId : Maybe String
, slideHtml : Html msg
, slideView : Html msg
}
, previousButton : { name : String, icon : Svg, attributes : List (ClickableSvg.Attribute msg) }
, nextButton : { name : String, icon : Svg, attributes : List (ClickableSvg.Attribute msg) }
@ -121,7 +121,7 @@ viewWithPreviousAndNextControls config =
else
Attrs.style "display" "none"
]
[ slide.slideHtml ]
[ slide.slideView ]
)
config.slides
)
@ -147,8 +147,8 @@ viewWithTabControls :
List
{ id : id
, idString : String
, slideHtml : Html msg
, tabControlHtml : Html Never
, slideView : Html msg
, tabView : Html Never
}
, tabStyles : Bool -> List Style
, tabListStyles : List Style
@ -166,8 +166,8 @@ viewWithTabControls config =
let
buildTab tabConfig =
TabsInternal.fromList { id = tabConfig.id, idString = tabConfig.idString }
[ \tab -> { tab | panelView = tabConfig.slideHtml }
, \tab -> { tab | tabView = [ Html.map never tabConfig.tabControlHtml ] }
[ \tab -> { tab | panelView = tabConfig.slideView }
, \tab -> { tab | tabView = [ Html.map never tabConfig.tabView ] }
]
{ tabList, tabPanels } =
@ -207,8 +207,8 @@ viewWithCombinedControls :
, idString : String
, name : String
, visibleLabelId : Maybe String
, slideHtml : Html msg
, tabControlHtml : Html Never
, slideView : Html msg
, tabView : Html Never
}
, tabStyles : Bool -> List Style
, tabListStyles : List Style
@ -252,8 +252,8 @@ viewWithCombinedControls config =
(\slide ->
{ id = slide.id
, idString = slide.idString
, slideHtml = slide.slideHtml
, tabControlHtml = slide.tabControlHtml
, slideView = slide.slideView
, tabView = slide.tabView
}
)
config.slides

26
tests/Spec/Nri/Ui/Carousel.elm
View File

@ -80,7 +80,7 @@ viewWithPreviousAndNextControlsSpec =
VisibleLabel ->
Just ("slide-" ++ String.fromInt index ++ "-label")
, slideHtml =
, slideView =
div [ StyledAttrs.id ("slide-" ++ String.fromInt index ++ "-label") ]
[ text ("Slide " ++ String.fromInt index) ]
}
@ -249,18 +249,18 @@ viewWithTabControlsSpec =
allSlides =
[ { id = 0
, idString = "slide-0"
, tabControlHtml = text "Control 0"
, slideHtml = text "Slide 0"
, tabView = text "Control 0"
, slideView = text "Slide 0"
}
, { id = 1
, idString = "slide-1"
, tabControlHtml = text "Control 1"
, slideHtml = text "Slide 1"
, tabView = text "Control 1"
, slideView = text "Slide 1"
}
, { id = 2
, idString = "slide-2"
, tabControlHtml = text "Control 2"
, slideHtml = text "Slide 2"
, tabView = text "Control 2"
, slideView = text "Slide 2"
}
]
@ -404,22 +404,22 @@ viewWithCombinedControlsSpec =
, idString = "slide-0"
, name = "Slide 0"
, visibleLabelId = Nothing
, tabControlHtml = text "Control 0"
, slideHtml = text "Slide 0"
, tabView = text "Control 0"
, slideView = text "Slide 0"
}
, { id = 1
, idString = "slide-1"
, name = "Slide 1"
, visibleLabelId = Nothing
, tabControlHtml = text "Control 1"
, slideHtml = text "Slide 1"
, tabView = text "Control 1"
, slideView = text "Slide 1"
}
, { id = 2
, idString = "slide-2"
, name = "Slide 2"
, visibleLabelId = Nothing
, tabControlHtml = text "Control 2"
, slideHtml = text "Slide 2"
, tabView = text "Control 2"
, slideView = text "Slide 2"
}
]