💀 Select V7

deprecated-modules.csv

@@ -1,7 +1,6 @@
 Nri.Ui.Accordion.V1,upgrade to V3
 Nri.Ui.Menu.V1,upgrade to V3
 Nri.Ui.Menu.V2,upgrade to V3
-Nri.Ui.Select.V7,upgrade to V8
 Nri.Ui.Table.V4,upgrade to V5
 Nri.Ui.Tabs.V6,upgrade to V7
 Nri.Ui.Tooltip.V1,upgrade to V2

elm.json

@@ -45,7 +45,6 @@
         "Nri.Ui.PremiumCheckbox.V6",
         "Nri.Ui.RadioButton.V2",
         "Nri.Ui.SegmentedControl.V14",
-        "Nri.Ui.Select.V7",
         "Nri.Ui.Select.V8",
         "Nri.Ui.Slide.V1",
         "Nri.Ui.SlideModal.V2",

src/Nri/Ui/Select/V7.elm

@@ -1,176 +0,0 @@
-module Nri.Ui.Select.V7 exposing (Choice, view)
-
-{-| Build a select input.
-
-@docs Choice, view
-
--}
-
-import Css
-import Dict
-import Html.Styled as Html exposing (Html)
-import Html.Styled.Attributes as Attributes
-import Html.Styled.Events as Events
-import Json.Decode exposing (Decoder)
-import Nri.Ui
-import Nri.Ui.Colors.Extra as ColorsExtra
-import Nri.Ui.Colors.V1 as Colors
-import Nri.Ui.CssVendorPrefix.V1 as VendorPrefixed
-import Nri.Ui.Fonts.V1 as Fonts
-import Nri.Ui.Util
-import SolidColor
-
-
-{-| A single possible choice.
--}
-type alias Choice a =
-    { label : String, value : a }
-
-
-{-| A select dropdown. Remember to add a label!
--}
-view :
-    { choices : List (Choice a)
-    , current : Maybe a
-    , id : String
-    , valueToString : a -> String
-    , defaultDisplayText : Maybe String
-    , isInError : Bool
-    }
-    -> Html a
-view config =
-    let
-        valueLookup =
-            config.choices
-                |> List.map (\x -> ( niceId (config.valueToString x.value), x.value ))
-                |> Dict.fromList
-
-        decodeValue string =
-            Dict.get string valueLookup
-                |> Maybe.map Json.Decode.succeed
-                |> Maybe.withDefault
-                    -- At present, elm/virtual-dom throws this failure away.
-                    (Json.Decode.fail
-                        ("Nri.Select: could not decode the value: "
-                            ++ string
-                            ++ "\nexpected one of: "
-                            ++ String.join ", " (Dict.keys valueLookup)
-                        )
-                    )
-
-        onSelectHandler =
-            Events.on "change" (Events.targetValue |> Json.Decode.andThen decodeValue)
-
-        defaultOption =
-            config.defaultDisplayText
-                |> Maybe.map (viewDefaultChoice config.current >> List.singleton)
-                |> Maybe.withDefault []
-
-        currentVal =
-            if config.current == Nothing && config.defaultDisplayText == Nothing then
-                config.choices
-                    |> List.head
-                    |> Maybe.map .value
-
-            else
-                config.current
-    in
-    config.choices
-        |> List.map (viewChoice currentVal config.valueToString)
-        |> (++) defaultOption
-        |> Nri.Ui.styled Html.select
-            "nri-select-menu"
-            [ -- border
-              Css.border3 (Css.px 1)
-                Css.solid
-                (if config.isInError then
-                    Colors.purple
-
-                 else
-                    Colors.gray75
-                )
-            , Css.borderBottomWidth (Css.px 3)
-            , Css.borderRadius (Css.px 8)
-            , Css.focus [ Css.borderColor Colors.azure ]
-
-            -- Font and color
-            , Css.color Colors.gray20
-            , Fonts.baseFont
-            , Css.fontSize (Css.px 15)
-            , Css.fontWeight (Css.int 600)
-            , Css.textOverflow Css.ellipsis
-            , Css.overflow Css.hidden
-            , Css.whiteSpace Css.noWrap
-
-            -- Interaction
-            , Css.cursor Css.pointer
-
-            -- Size and spacing
-            , Css.height (Css.px 45)
-            , Css.width (Css.pct 100)
-            , Css.paddingLeft (Css.px 15)
-            , Css.paddingRight (Css.px 30)
-
-            -- Icons
-            , selectArrowsCss
-            ]
-            [ onSelectHandler
-            , Attributes.id config.id
-            ]
-
-
-viewDefaultChoice : Maybe a -> String -> Html a
-viewDefaultChoice current displayText =
-    Html.option
-        [ Attributes.selected (current == Nothing)
-        , Attributes.disabled True
-        ]
-        [ Html.text displayText ]
-
-
-viewChoice : Maybe a -> (a -> String) -> Choice a -> Html a
-viewChoice current toString choice =
-    let
-        isSelected =
-            current
-                |> Maybe.map ((==) choice.value)
-                |> Maybe.withDefault False
-    in
-    Html.option
-        [ Attributes.id (niceId (toString choice.value))
-        , Attributes.value (niceId (toString choice.value))
-        , Attributes.selected isSelected
-        ]
-        [ Html.text choice.label ]
-
-
-niceId : String -> String
-niceId x =
-    "nri-select-" ++ Nri.Ui.Util.dashify (Nri.Ui.Util.removePunctuation x)
-
-
-selectArrowsCss : Css.Style
-selectArrowsCss =
-    let
-        color =
-            SolidColor.toRGBString (ColorsExtra.fromCssColor Colors.azure)
-    in
-    Css.batch
-        [ """<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="12px" height="16px" viewBox="0 0 12 16"><g fill=" """
-            ++ color
-            ++ """ "><path d="M2.10847,9.341803 C1.65347,8.886103 0.91427,8.886103 0.45857,9.341803 C0.23107,9.570003 0.11697,9.868203 0.11697,10.167103 C0.11697,10.465303 0.23107,10.763503 0.45857,10.991703 L5.12547,15.657903 C5.57977,16.114303 6.31897,16.114303 6.77537,15.657903 L11.44157,10.991703 C11.89727,10.536003 11.89727,9.797503 11.44157,9.341803 C10.98657,8.886103 10.24667,8.886103 9.79167,9.341803 L5.95007,13.182703 L2.10847,9.341803 Z"/><path d="M1.991556,6.658179 C1.536659,7.11394 0.797279,7.11394 0.3416911,6.658179 C0.1140698,6.43004 0,6.13173 0,5.83325 C0,5.53476 0.1140698,5.23645 0.3416911,5.00831 L5.008185,0.34182 C5.463081,-0.11394 6.202461,-0.11394 6.65805,0.34182 L11.32454,5.00831 C11.78031,5.4639 11.78031,6.202592 11.32454,6.658179 C10.86965,7.11394 10.13027,7.11394 9.674679,6.658179 L5.833118,2.81679 L1.991556,6.658179 Z"/></g></svg> """
-            |> urlUtf8
-            |> Css.property "background"
-        , Css.backgroundColor Colors.white
-
-        -- "appearance: none" removes the default dropdown arrows
-        , VendorPrefixed.property "appearance" "none"
-        , Css.backgroundRepeat Css.noRepeat
-        , Css.property "background-position" "center right -20px"
-        , Css.backgroundOrigin Css.contentBox
-        ]
-
-
-urlUtf8 : String -> String
-urlUtf8 content =
-    """url('data:image/svg+xml;utf8,""" ++ content ++ """')"""

tests/Spec/Nri/Ui/Select.elm

@@ -1,223 +0,0 @@
-module Spec.Nri.Ui.Select exposing (spec)
-
-import Expect exposing (Expectation)
-import Html
-import Html.Attributes as Attr
-import Html.Styled
-import Nri.Ui.Select.V7
-import Test exposing (..)
-import Test.Html.Query as Query
-import Test.Html.Selector exposing (..)
-
-
-spec : Test
-spec =
-    describe "view" <|
-        viewSuiteV7
-            (\config ->
-                { choices = config.choices
-                , current = config.current
-                , id = "fake-id"
-                , valueToString = identity
-                , defaultDisplayText = config.defaultDisplayText
-                , isInError = False
-                }
-                    |> Nri.Ui.Select.V7.view
-                    |> Html.Styled.toUnstyled
-            )
-
-
-viewSuiteV6 :
-    ({ choices : List { label : String, value : String }, current : Maybe String, defaultDisplayText : Maybe String } -> Html.Html msg)
-    -> List Test
-viewSuiteV6 view =
-    [ describe "without a default option"
-        [ test "shows all options" <|
-            \() ->
-                viewTestV6
-                    view
-                    Nothing
-                    Nothing
-                    [ "Tacos", "Burritos", "Enchiladas" ]
-                    |> Query.find [ tag "select" ]
-                    |> Query.findAll [ tag "option" ]
-                    |> Query.count (Expect.equal 3)
-        , test "selects the first option if nothing is selected and there's no default" <|
-            \() ->
-                viewTestV6
-                    view
-                    Nothing
-                    Nothing
-                    [ "Tacos", "Burritos", "Enchiladas" ]
-                    |> Query.find
-                        [ tag "option"
-                        , attribute <| Attr.selected True
-                        ]
-                    |> Query.has [ text "Tacos" ]
-        , test "selects the current option" <|
-            \() ->
-                viewTestV6
-                    view
-                    Nothing
-                    (Just "Burritos")
-                    [ "Tacos", "Burritos", "Enchiladas" ]
-                    |> Query.find
-                        [ tag "option"
-                        , attribute <| Attr.selected True
-                        ]
-                    |> Query.has [ text "Burritos" ]
-        ]
-    , describe "with a default option"
-        [ test "shows all options" <|
-            \() ->
-                viewTestV6
-                    view
-                    (Just "Tasty tortilla'd foods")
-                    Nothing
-                    [ "Tacos", "Burritos", "Enchiladas" ]
-                    |> Query.find [ tag "select" ]
-                    |> Query.findAll [ tag "option" ]
-                    |> Query.count (Expect.equal 4)
-        , test "selects the disabled default option if nothing is currently selected" <|
-            \() ->
-                viewTestV6
-                    view
-                    (Just "Tasty tortilla'd foods")
-                    Nothing
-                    [ "Tacos", "Burritos", "Enchiladas" ]
-                    |> Query.find
-                        [ tag "option"
-                        , attribute <| Attr.selected True
-                        , attribute <| Attr.disabled True
-                        ]
-                    |> Query.has [ text "Tasty tortilla'd foods" ]
-        , test "selects the current option" <|
-            \() ->
-                viewTestV6
-                    view
-                    (Just "Tasty tortilla'd foods")
-                    (Just "Burritos")
-                    [ "Tacos", "Burritos", "Enchiladas" ]
-                    |> Query.find
-                        [ tag "option"
-                        , attribute <| Attr.selected True
-                        ]
-                    |> Query.has [ text "Burritos" ]
-        ]
-    ]
-
-
-viewTestV6 :
-    ({ choices : List { label : a, value : a }, current : Maybe b, defaultDisplayText : Maybe String } -> Html.Html msg)
-    -> Maybe String
-    -> Maybe b
-    -> List a
-    -> Query.Single msg
-viewTestV6 view defaultDisplayText selected items =
-    Query.fromHtml
-        (Html.div []
-            [ view
-                { choices = List.map (\x -> { label = x, value = x }) items
-                , current = selected
-                , defaultDisplayText = defaultDisplayText
-                }
-            ]
-        )
-
-
-viewSuiteV7 :
-    ({ choices : List { label : String, value : String }, current : Maybe String, defaultDisplayText : Maybe String } -> Html.Html msg)
-    -> List Test
-viewSuiteV7 view =
-    [ describe "without a default option"
-        [ test "shows all options" <|
-            \() ->
-                viewTestV7
-                    view
-                    Nothing
-                    Nothing
-                    [ "Tacos", "Burritos", "Enchiladas" ]
-                    |> Query.find [ tag "select" ]
-                    |> Query.findAll [ tag "option" ]
-                    |> Query.count (Expect.equal 3)
-        , test "selects the first option if nothing is selected and there's no default" <|
-            \() ->
-                viewTestV7
-                    view
-                    Nothing
-                    Nothing
-                    [ "Tacos", "Burritos", "Enchiladas" ]
-                    |> Query.find
-                        [ tag "option"
-                        , attribute <| Attr.selected True
-                        ]
-                    |> Query.has [ text "Tacos" ]
-        , test "selects the current option" <|
-            \() ->
-                viewTestV7
-                    view
-                    Nothing
-                    (Just "Burritos")
-                    [ "Tacos", "Burritos", "Enchiladas" ]
-                    |> Query.find
-                        [ tag "option"
-                        , attribute <| Attr.selected True
-                        ]
-                    |> Query.has [ text "Burritos" ]
-        ]
-    , describe "with a default option"
-        [ test "shows all options" <|
-            \() ->
-                viewTestV7
-                    view
-                    (Just "Tasty tortilla'd foods")
-                    Nothing
-                    [ "Tacos", "Burritos", "Enchiladas" ]
-                    |> Query.find [ tag "select" ]
-                    |> Query.findAll [ tag "option" ]
-                    |> Query.count (Expect.equal 4)
-        , test "selects the disabled default option if nothing is currently selected" <|
-            \() ->
-                viewTestV7
-                    view
-                    (Just "Tasty tortilla'd foods")
-                    Nothing
-                    [ "Tacos", "Burritos", "Enchiladas" ]
-                    |> Query.find
-                        [ tag "option"
-                        , attribute <| Attr.selected True
-                        , attribute <| Attr.disabled True
-                        ]
-                    |> Query.has [ text "Tasty tortilla'd foods" ]
-        , test "selects the current option" <|
-            \() ->
-                viewTestV7
-                    view
-                    (Just "Tasty tortilla'd foods")
-                    (Just "Burritos")
-                    [ "Tacos", "Burritos", "Enchiladas" ]
-                    |> Query.find
-                        [ tag "option"
-                        , attribute <| Attr.selected True
-                        ]
-                    |> Query.has [ text "Burritos" ]
-        ]
-    ]
-
-
-viewTestV7 :
-    ({ choices : List { label : a, value : a }, current : Maybe b, defaultDisplayText : Maybe String } -> Html.Html msg)
-    -> Maybe String
-    -> Maybe b
-    -> List a
-    -> Query.Single msg
-viewTestV7 view defaultDisplayText selected items =
-    Query.fromHtml
-        (Html.div []
-            [ view
-                { choices = List.map (\x -> { label = x, value = x }) items
-                , current = selected
-                , defaultDisplayText = defaultDisplayText
-                }
-            ]
-        )

tests/elm-verify-examples.json

@@ -41,7 +41,6 @@
         "Nri.Ui.PremiumCheckbox.V6",
         "Nri.Ui.RadioButton.V2",
         "Nri.Ui.SegmentedControl.V14",
-        "Nri.Ui.Select.V7",
         "Nri.Ui.Select.V8",
         "Nri.Ui.Slide.V1",
         "Nri.Ui.SlideModal.V2",