NoRedInk/noredink-ui
1
1
Fork 0
mirror of https://github.com/NoRedInk/noredink-ui.git synced 2025-01-04 12:47:53 +03:00
Code Issues Packages Projects Releases Wiki Activity

Move the click handling to the shared location

Browse Source
This commit is contained in:
Tessa Kelly 2021-02-10 17:23:33 -08:00
parent a88f1fb155
commit e702bd1a3c
1 changed files with 12 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/Nri/Ui/Menu/V2.elm
View File

@ -165,7 +165,6 @@ view config =
else
[]
]
, Events.onClick (config.toggle (not config.isOpen))
, config.buttonWidth
-- TODO: don't set this value as an inline style unnecessarily
|> Maybe.map (\w -> Attributes.style "width" (String.fromInt w ++ "px"))
@ -326,23 +325,7 @@ iconButtonWithMenu config =
ClickableSvg.button config.label
config.icon
[ ClickableSvg.disabled config.isDisabled
, ClickableSvg.custom
(attrs
++ buttonAttributes
++ (if config.isDisabled then
[]
else
[ Events.custom "click"
(Json.Decode.succeed
{ preventDefault = True
, stopPropagation = True
, message = config.toggle (not config.isOpen)
}
)
]
)
)
, ClickableSvg.custom (attrs ++ buttonAttributes)
, ClickableSvg.exactWidth 25
, ClickableSvg.exactHeight 25
, ClickableSvg.css [ Css.marginLeft (Css.px 10) ]
@ -397,6 +380,17 @@ viewMenu config content =
, Widget.expanded config.isOpen
, Aria.controls config.menuId
, Attributes.id config.buttonId
, if config.isDisabled then
AttributesExtra.none
else
Events.custom "click"
(Json.Decode.succeed
{ preventDefault = True
, stopPropagation = True
, message = config.toggle (not config.isOpen)
}
)
]
, viewDropdown
{ alignment = config.alignment