NoRedInk/noredink-ui
1
1
Fork 0
mirror of https://github.com/NoRedInk/noredink-ui.git synced 2024-12-18 11:11:38 +03:00
Code Issues Packages Projects Releases Wiki Activity

prefer explicit type to bool

Browse Source
This commit is contained in:
Michael Glass 2018-08-21 14:02:56 -07:00
parent 7f879bf48c
commit e7824d451d
No known key found for this signature in database
GPG Key ID: 0A1A7A8792A6A129
1 changed files with 20 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/Nri/Ui/Button/V3.elm
View File

@ -212,7 +212,7 @@ customButton attributes config content =
in
Nri.Ui.styled Html.button
"Nri-Button-V3-CustomButton"
(buttonStyles config.size config.width buttonStyle False)
(buttonStyles config.size config.width buttonStyle Button)
([ onClick config.onClick
, Attributes.disabled disabled
, Attributes.type_ "button"
@ -261,7 +261,7 @@ copyToClipboard assets config =
in
Nri.Ui.styled Html.button
"Nri-Ui-Button-V3-copyToClipboard"
(buttonStyles config.size config.width (styleToColorPalette config.style) False)
(buttonStyles config.size config.width (styleToColorPalette config.style) Button)
[ Widget.label "Copy URL to clipboard"
, attribute "data-clipboard-text" config.copyText
, widthStyle config.width
@ -341,7 +341,7 @@ toggleButton config =
in
Nri.Ui.styled Html.button
"Nri-Ui-Button-V3-toggleButton"
(buttonStyles Medium Nothing SecondaryColors False
(buttonStyles Medium Nothing SecondaryColors Button
++ toggledStyles
)
(if config.pressed then
@ -490,7 +490,7 @@ linkBase : List (Attribute msg) -> LinkConfig -> Html msg
linkBase extraAttrs config =
Nri.Ui.styled Html.a
"Nri-Button-V3-linkBase"
(buttonStyles config.size config.width (styleToColorPalette config.style) True
(buttonStyles config.size config.width (styleToColorPalette config.style) Anchor
++ [ whiteSpace noWrap
]
)
@ -535,12 +535,12 @@ styleToColorPalette style =
PremiumColors
buttonStyles : ButtonSize -> Maybe Int -> ColorPalette -> Bool -> List Style
buttonStyles size width colorPalette isLink =
buttonStyles : ButtonSize -> Maybe Int -> ColorPalette -> ElementType -> List Style
buttonStyles size width colorPalette elementType =
List.concat
[ buttonStyle
, colorStyle colorPalette
, sizeStyle size width isLink
, sizeStyle size width elementType
]
@ -730,8 +730,13 @@ colorStyle colorPalette =
]
sizeStyle : ButtonSize -> Maybe Int -> Bool -> List Style
sizeStyle size width isLink =
type ElementType
= Anchor
| Button
sizeStyle : ButtonSize -> Maybe Int -> ElementType -> List Style
sizeStyle size width elementType =
let
config =
case size of
@ -780,9 +785,11 @@ sizeStyle size width isLink =
]
lineHeightPx =
if isLink then
case elementType of
Anchor ->
config.height
else
Button ->
config.lineHeight
in
[ fontSize (px config.fontSize)