NoRedInk/noredink-ui
1
1
Fork 0
mirror of https://github.com/NoRedInk/noredink-ui.git synced 2024-12-18 19:21:29 +03:00
Code Issues Packages Projects Releases Wiki Activity

hide label on inline. No one is asking for this and it looks awful

Browse Source
This commit is contained in:
Alex Perkins 2021-11-21 12:23:24 -05:00
parent 3bfb389c9b
commit f5865855f3
2 changed files with 57 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
src/Nri/Ui/RadioButton/V3.elm
View File

@ -331,7 +331,7 @@ type alias InternalConfig value msg =
, isLocked : Bool
, showPennant : Bool
, id : String
, disclosureIdAndElement : Maybe ( String, Html msg )
, disclosureIdAndElement : Maybe ( String, List (Html msg) )
}
@ -394,7 +394,7 @@ internalConfig label config eventsAndValues =
Nothing
( (_ :: _) as childNodes, True ) ->
Just <| ( disclosureId, div [ id disclosureId ] childNodes )
Just <| ( disclosureId, childNodes )
}
_ ->
@ -517,9 +517,18 @@ viewBlock config =
config.premiumMsg
]
]
, viewJust
Tuple.second
config.disclosureIdAndElement
, case config.disclosureIdAndElement of
Just ( id_, childNodes ) ->
div
[ id id_
, css
[ display inlineBlock
]
]
childNodes
Nothing ->
text ""
]
@ -622,9 +631,25 @@ viewInline config =
else
[ css [ verticalAlign middle ] ]
)
[ Html.text config.label
, viewJust
(\premiumMsg ->
[ Html.span
[ css <|
if config.hideLabel then
[ Css.height <| px 1
, Css.width <| px 1
, overflow Css.hidden
, margin <| px -1
, padding <| px 0
, border <| px 0
, display inlineBlock
, textIndent <| px 1
]
else
[]
]
[ Html.text config.label ]
, case ( config.hideLabel, config.premiumMsg ) of
( False, Just premiumMsg ) ->
ClickableSvg.button "Premium"
Pennant.premiumFlag
[ ClickableSvg.onClick premiumMsg
@ -632,13 +657,17 @@ viewInline config =
, ClickableSvg.exactHeight 24
, ClickableSvg.css [ marginLeft (px 8) ]
]
)
config.premiumMsg
_ ->
text ""
]
]
, viewJust
Tuple.second
config.disclosureIdAndElement
, case config.disclosureIdAndElement of
Just ( id_, childNodes ) ->
span [ id id_ ] childNodes
Nothing ->
text ""
]

19
styleguide-app/Examples/RadioButton.elm
View File

@ -116,7 +116,7 @@ viewVanilla state =
, RadioButton.disclosure
[ span
[ Attributes.id "cats-description" ]
[ Text.mediumBody [ Text.plaintext "Cats kind of do their own thing" ] ]
[ Text.smallBody [ Text.plaintext "Cats kind of do their own thing" ] ]
]
, RadioButton.block
]
@ -151,16 +151,27 @@ viewVanilla state =
, RadioButton.view
(selectionToString Robots)
[ RadioButton.premium
{ teacherPremiumLevel = PremiumLevel.Premium
, contentPremiumLevel = PremiumLevel.PremiumWithWriting
{ teacherPremiumLevel = PremiumLevel.PremiumWithWriting
, contentPremiumLevel = PremiumLevel.Premium
}
, RadioButton.value Robots
, RadioButton.name "pets"
, RadioButton.selectedValue state.selectedValue
, RadioButton.onSelect Select
, RadioButton.valueToString selectionToString
, RadioButton.showPennant <| OpenModal "pets-robots"
, RadioButton.inline
, RadioButton.showPennant <| OpenModal "pets-robots"
, if state.selectedValue == Just Robots then
RadioButton.hiddenLabel
else
RadioButton.none
, RadioButton.disclosure
[ Text.smallBody
[ Text.plaintext "With apologies to Karel Čapek"
, Text.css [ Css.display Css.inlineBlock ]
]
]
]
, p
[ Attributes.id "dogs-description" ]