NoRedInk/noredink-ui
1
1
Fork 0
mirror of https://github.com/NoRedInk/noredink-ui.git synced 2024-09-21 04:07:54 +03:00
Code Issues Packages Projects Releases Wiki Activity

Update pull_request_template.md

Browse Source
This commit is contained in:
kristine 2024-01-10 10:23:07 -05:00 committed by GitHub
parent e63016540f
commit ff0fb0521e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
.github/pull_request_template.md vendored
View File

@ -56,10 +56,9 @@ Please link to any relevant context and stories.
- [ ] Component API follows standard patterns in noredink-ui
- e.g., as a dev, I can conveniently add an `nriDescription`
- and adding a new feature to the component will _not_ require major API changes to the component
- [ ] Please assign the following reviewers (applicable Sep 2023–Dec 2023):
- [ ] [a11y-volunteer-reviewers](https://github.com/orgs/NoRedInk/teams/volunteer-a11y-reviewers) - Someone from this group will review your PR in full.
- [ ] [team-accessibilibats-a11ybats](https://github.com/orgs/NoRedInk/teams/team-accessibilibats-a11ybats) - Someone from this group will review your PR for ACCESSIBILITY ONLY.
- [ ] Someone from your team who can review requirements from your team's perspective. (This could be the same person from the [a11y-volunteer-reviewers](https://github.com/orgs/NoRedInk/teams/volunteer-a11y-reviewers) group if you'd like.)
- [ ] Please assign the following reviewers:
- [ ] Someone from your team who can review your PR in full and review requirements from your team's perspective.
- [ ] [team-accessibilibats-a11ybats](https://github.com/orgs/NoRedInk/teams/team-accessibilibats-a11ybats) - Someone from this group will review your PR for accessibility and adherence to component library foundations.
- [ ] If there are user-facing changes, a designer. (You may want to direct your designer to the [deploy preview](https://github.com/NoRedInk/noredink-ui#reviews--preview-environments) for easy review):
- For writing-related component changes, add Stacey (staceyadams)
- For quiz engine-related components, add Ravi (ravi-morbia)
@ -100,10 +99,9 @@ Please link to any relevant context and stories.
- and adding a new feature to the component will _not_ require major API changes to the component
- [ ] If this is a new major version of the component, our team has stories created to upgrade all instances of the old component. Here are links to the stories:
- add your story links here OR just write this is not a new major version
- [ ] Please assign the following reviewers (applicable Sep 2023–Dec 2023):
- [ ] [a11y-volunteer-reviewers](https://github.com/orgs/NoRedInk/teams/volunteer-a11y-reviewers) - Someone from this group will review your PR in full.
- [ ] [team-accessibilibats-a11ybats](https://github.com/orgs/NoRedInk/teams/team-accessibilibats-a11ybats) - Someone from this group will review your PR for ACCESSIBILITY ONLY.
- [ ] Someone from your team who can review requirements from your team's perspective. (This could be the same person from the [a11y-volunteer-reviewers](https://github.com/orgs/NoRedInk/teams/volunteer-a11y-reviewers) group if you'd like.)
- [ ] Please assign the following reviewers:
- [ ] Someone from your team who can review your PR in full and review requirements from your team's perspective.
- [ ] [team-accessibilibats-a11ybats](https://github.com/orgs/NoRedInk/teams/team-accessibilibats-a11ybats) - Someone from this group will review your PR for accessibility and adherence to component library foundations.
- [ ] If there are user-facing changes, a designer. (You may want to direct your designer to the [deploy preview](https://github.com/NoRedInk/noredink-ui#reviews--preview-environments) for easy review):
- For writing-related component changes, add Stacey (staceyadams)
- For quiz engine-related components, add Ravi (ravi-morbia)