1
1
mirror of https://github.com/NoRedInk/noredink-ui.git synced 2024-12-27 15:42:23 +03:00
Commit Graph

6 Commits

Author SHA1 Message Date
Michael Hadley
b907c12d7a Prevent text area with auto resize from jumping scroll position
The old logic looked like this:

```
if (this._textarea.scrollHeight > minHeight) {
  this._textarea.style.height = minHeight + 'px'
  this._textarea.style.height = this._textarea.scrollHeight + 'px'
}
```

Imagine a case where the `minHeight` is actually less than the current
height of the text area due to the current content. The height of the
element would be set to a smaller value, and then later reset to the
desired height. This causes the overall scroll height of the page to
shrink (because the text-area did), and then expand again. Now the
scroll position for the user on the page has changed, and this happens
on every keystroke.

This change just skips the first assignment to `.height`. I'm not sure why it
was initially there, but I can't see a reason for keeping it (especially
since it seems to be the cause of this bug).
2020-03-27 11:34:00 -07:00
Gavin Panella
28d36c6f64 Revert "Merge pull request from NoRedInk/puffins/prepare-for-merge"
This reverts commit 4373c78d82, reversing
changes made to 6b78075f02.
2020-03-06 20:00:34 +01:00
Stoeffel
873f0ef521 move files into subdirectory 2020-03-02 10:45:03 +01:00
Michael Hadley
ccb52d032c Create matching custom element for V4 text area 2019-01-16 12:49:03 -08:00
Luke Westby
2342836ac1
make sure it exists () 2018-06-13 16:49:45 -07:00
Luke Westby
38ca396ac8
Updates to TextArea ()
* update textarea js code and make it npm-ready

* use an attribute instead so dom debugging is easier

* use data- attribute to be I D I O M A T I C

* version the custom element

* include marica's resize logic improvements

* changes to elm module

* clean up styleguide build and use v3 in styleguide
2018-06-11 11:08:49 -07:00