Commit Graph

2508 Commits

Author SHA1 Message Date
Brian Hicks
498d609003
Merge pull request #488 from NoRedInk/tessa/refactor-styleguide-percy
Tessa/refactor styleguide percy
2020-04-01 17:28:54 -05:00
Tessa Kelly
30910c4c3b Merge remote-tracking branch 'origin/master' into tessa/refactor-styleguide-percy 2020-04-01 09:52:14 -07:00
Brian Hicks
18af70fe96 restore modules that were actually used 2020-04-01 06:30:50 -05:00
Brian Hicks
c576d0d543
Merge pull request #489 from NoRedInk/reenable-major-version-check
re-enable major version check
2020-04-01 05:51:46 -05:00
Brian Hicks
4c3f449b28 re-enable major version check 2020-04-01 05:48:15 -05:00
Brian Hicks
387e1a7e84
Merge pull request #486 from NoRedInk/spring-cleaning
Spring cleaning
2020-04-01 05:46:59 -05:00
Brian Hicks
bfdb712b59 temporarily disable major upgrade check 2020-04-01 05:44:36 -05:00
Brian Hicks
c0432d99df bump to 8.0.0 2020-04-01 05:41:26 -05:00
Brian Hicks
0534b0d051 clarify upgrade policy (reduc) 2020-04-01 05:40:31 -05:00
Tessa Kelly
7ad8df39d4 Separate out the wrapState and wrapMsg helpers to better emphasize what example we're looking at 2020-03-31 16:35:17 -07:00
Tessa Kelly
32264949c6 Pull the example state management up a level 2020-03-31 16:35:17 -07:00
Tessa Kelly
97f237f589 Adds remaining modules to the examples 2020-03-31 16:35:17 -07:00
Tessa Kelly
7d25639382 Avoids manually managing the state keys 2020-03-31 16:35:17 -07:00
Tessa Kelly
8a4b246dfa Inline the example accessors 2020-03-31 16:35:17 -07:00
Tessa Kelly
0501c25141 Change the modeling to a dict 2020-03-31 16:35:17 -07:00
Tessa Kelly
b87a61b86f Use all module list for subscriptions and view 2020-03-31 16:35:17 -07:00
Tessa Kelly
92573874fc Use new implementation style 2020-03-31 16:35:17 -07:00
Tessa Kelly
5e879fd801 Begin trying wrapped implementation 2020-03-31 16:35:17 -07:00
Tessa Kelly
3d1d65b508 💀 remove Module example 2020-03-31 16:35:17 -07:00
Tessa Kelly
6d5184137f Adds Example type annotations 2020-03-31 16:35:17 -07:00
Tessa Kelly
de82a5c4ab Adds back in subscriptions 2020-03-31 16:35:17 -07:00
Tessa Kelly
dc9ed8ba7b Uncomment all the states 2020-03-31 16:35:17 -07:00
Tessa Kelly
267164e9cc Adds banner alert example back in 2020-03-31 16:35:17 -07:00
Tessa Kelly
2f5fb613f2 Adds button example back in 2020-03-31 16:35:17 -07:00
Tessa Kelly
72daef5d24 Begin refactoring to make adding new modules easier 2020-03-31 16:35:17 -07:00
Tessa Kelly
61024704f5 NriModules -> Examples 2020-03-31 16:35:17 -07:00
Aaron VonderHaar
3cdf2cbcb0 Fix ARIA in examples 2020-03-31 13:26:35 -07:00
Aaron VonderHaar
f18656157c Add TextInput.V5.email input type 2020-03-31 13:19:56 -07:00
Brian Hicks
240c7513ac remove deprecated modules from deprecated-imports.csv 2020-03-31 15:05:07 -05:00
Aaron VonderHaar
03c0845973 Update TextInput example to use Debug.Control 2020-03-31 13:04:36 -07:00
Brian Hicks
9e2a24d22d remove broken example
this looks like it's been broken for a while without being run, and I'm not
sure how to fix it. Going to just remove this instead of trying to get it
working again, since it's been inactive for so long.
2020-03-31 15:03:42 -05:00
Brian Hicks
8ce5f7aebc generate tests, then run them 2020-03-31 15:03:28 -05:00
Brian Hicks
4094b97830 automatically look for verifiable examples in all exposed modules 2020-03-31 14:58:20 -05:00
Brian Hicks
00bb332621 clarify deprecation policy in README 2020-03-31 14:53:20 -05:00
Brian Hicks
b309421d3d remove unused modules 2020-03-31 14:52:13 -05:00
Brian Hicks
afa37f1f20
Merge pull request #482 from NoRedInk/tessa/add-skip-link
Tessa/add skip link
2020-03-31 13:26:05 -05:00
Tessa Kelly
fab1e3dfb7 Ratchet target errors 2020-03-31 13:20:37 -05:00
Tessa Kelly
36f3a6589e Fix routing to remove false positives due to routing: see https://github.com/dequelabs/axe-core/issues/1204 2020-03-31 13:20:37 -05:00
Tessa Kelly
ce0a6a0d53 Adds skip-button 2020-03-31 13:20:37 -05:00
Brian Hicks
3b75964d53
Merge pull request #481 from NoRedInk/tessa/update-premium-checkbox
Tessa/update premium checkbox
2020-03-31 13:19:53 -05:00
Tessa Kelly
73f3c71fb0 Use Nri.Ui.Svg.V1 2020-03-31 10:54:40 -07:00
Tessa Kelly
90f5c47773 Update the scripts 2020-03-31 10:54:40 -07:00
Tessa Kelly
7bff7cf3d9 Use pennant v2 in checkbox module 2020-03-31 10:54:40 -07:00
Tessa Kelly
7142cf64e6 Adds withCss custom svg helper 2020-03-31 10:54:40 -07:00
Michael Hadley
74a7a8aef4
Merge pull request #485 from NoRedInk/bump-npm-package-1.2.2
Bump npm package to 1.2.2
2020-03-30 18:58:36 -07:00
Michael Hadley
90b622c540 1.2.2 2020-03-30 18:43:36 -07:00
Michael Hadley
6587d51421
Merge pull request #484 from NoRedInk/bump-7.26.1
Bump version to 7.26.1
2020-03-30 17:15:57 -07:00
Michael Hadley
88e3348eb7 Bump version to 7.26.1 2020-03-30 16:51:30 -07:00
Michael Hadley
8285151f20
Merge pull request #483 from NoRedInk/fix-text-area-scroll-jumping
Prevent text area with auto resize from jumping scroll position
2020-03-30 16:48:54 -07:00
Michael Hadley
b907c12d7a Prevent text area with auto resize from jumping scroll position
The old logic looked like this:

```
if (this._textarea.scrollHeight > minHeight) {
  this._textarea.style.height = minHeight + 'px'
  this._textarea.style.height = this._textarea.scrollHeight + 'px'
}
```

Imagine a case where the `minHeight` is actually less than the current
height of the text area due to the current content. The height of the
element would be set to a smaller value, and then later reset to the
desired height. This causes the overall scroll height of the page to
shrink (because the text-area did), and then expand again. Now the
scroll position for the user on the page has changed, and this happens
on every keystroke.

This change just skips the first assignment to `.height`. I'm not sure why it
was initially there, but I can't see a reason for keeping it (especially
since it seems to be the cause of this bug).
2020-03-27 11:34:00 -07:00