1
1
mirror of https://github.com/NoRedInk/noredink-ui.git synced 2024-12-28 08:04:06 +03:00
Commit Graph

9 Commits

Author SHA1 Message Date
dependabot[bot]
98e03938a0
Bump elm-community/string-extra from 4.0.0 to 4.0.1 in /styleguide-app
Bumps [elm-community/string-extra](https://github.com/elm-community/string-extra) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/elm-community/string-extra/releases)
- [Commits](https://github.com/elm-community/string-extra/compare/4.0.0...4.0.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-03-08 00:12:38 +00:00
Richard Feldman
e2907d9ba2 Prep for 0.19 dual-publish ()
* Use elm-css 16.0.0

* 💀 Ui.Checkbox V1 and V2

* s/Css.Foreign/Css.Global/g

* 💀 Nri.Ui.Styles.V1

* 💀 BannerAlert.V1

* 💀 Modal.V1

* 💀 Dropdown.V1

* 💀 Select.V1 and V2

* 💀 Alert.V1

* 💀 Button.V1 and V2

* 💀 Divider.V1

* 💀 Icon.V1 and V2

* 💀 Outline.V1

* 💀 SegmentedControl.V1-V5

* 💀 TextArea.V1 and V2

* 💀 TextInput.V1

* delete the rest of the modules

* actually more deletions

* InputStyles v1 is unused

* move to src-0.18

* do the 0.19 upgrade

* select options are addressable by index

* elm-css 16

* update scripts

* elm-format

* Update V2.elm

* put the nbsp back

* elm-format validation for both versions
2018-11-12 15:38:19 -08:00
Luke Westby
c1ff19f0d0
Add Html.Styled versions for everything ()
* make html.styled versions of remaining widgets

* upgrade all the examples

* change license name
2018-10-23 09:55:30 -07:00
Jasper Woudenberg
2a77a03efc Migrate TextArea.V2 to Html.Styled
This does not actually migrate the styles themselves yet, it just
changes the Html type of the `TextArea` exposed from the module.
2018-05-18 10:35:31 +02:00
Hardy Jones
0a75e8229b
Extract Nri.Icon from the monolith
The recommendation is to break the styles API rather than the view API
when moving something out of the monolith into this repo.

`Nri.Icon` is not really setup for that sort of breakage.
If we would prefer to have the styles break rather than the view,
that will take more work.
Work that can be done independent of the extraction.

The transition in the monolith ought to look something like:

```elm
module Nri.Icon exposing (..)

import Html exposing (Html)
import Nri.SvgSprite
import Nri.Ui.Icon.V1 exposing (Assets, IconType)

icon : { alt : String, icon : IconType } -> Html msg
icon config =
  Nri.Ui.Icon.V1.icon assets

assets : Assets {}
assets =
  { activity = Nri.SvgSprite.activity
  , arrowDown = Nri.SvgSprite.arrowDown
  , attention_svg = Nri.Assets.attention_svg
  ...
  }
```

So hopefully, the change is still very small on the monolith side.

There's maybe a bigger concern than which API breaks.
`Nri.Icon` has some behavior for a11y.
We could definitely change the internals over during the extraction.
But, since all of these changes are value-level changes,
it's very likely that we'll break something in the process.
That's a bigger concern because instead of affecting
the handful of Engineers working at NRI,
we would be affecting the millions of people using the site.

We shouldn't fear making those kinds of changes.
However, we should make them when we can give them the appropriate
attention they deserve.
Not when one person is trying to move as fast as possible to avoid
race conditions of moving modules between repos.
2018-03-28 18:20:16 -07:00
Tessa Kelly
98a8a5458c Remove dependency on nri-elm-css 2018-03-16 17:33:24 -07:00
Tessa Kelly
63d7178b32 🐛 fix duplicated package install (not sure how this every worked 😬:) 2018-03-16 17:33:24 -07:00
Stoeffel
168bf35682 upgrade styleguide-app to latest version of elm-css 2018-02-28 14:18:52 -08:00
Brooke
0c33c83d73 add mini styleguide for ui components 2018-02-12 13:32:38 -08:00