Commit Graph

2376 Commits

Author SHA1 Message Date
Brian Hicks
b722380064 fix width and ellipsisize cutoff 2020-01-27 10:26:55 -06:00
Brian Hicks
2835442cb9 don't set text beneath the selection arrows 2020-01-27 10:21:26 -06:00
Brian Hicks
16fbb629b0 add a new selector to the styleguide to demonstrate the problem 2020-01-27 10:16:22 -06:00
Brian Hicks
840f6fa11f
Merge pull request #445 from NoRedInk/7.18.0
bump to 7.18.0
2020-01-22 17:29:59 -06:00
Brian Hicks
8b8385155f bump to 7.18.0 2020-01-22 15:25:51 -08:00
Brian Hicks
074c8c0dc1
Merge pull request #441 from NoRedInk/lab/customizable-select
Lab/customizable select
2020-01-22 17:25:00 -06:00
Tessa Kelly
6237c91b3e Merge remote-tracking branch 'origin/master' into lab/customizable-select 2020-01-22 10:23:57 -08:00
Michael Hadley
30595b73af
Merge pull request #444 from NoRedInk/release-button-click-fix
Bump to 7.17.1
2020-01-21 18:30:54 -08:00
Michael Hadley
bd3c50441e Bump to 7.17.1 2020-01-21 17:03:36 -08:00
Ben Dansby
b03b01d1c3
Merge pull request #443 from NoRedInk/dansby/modal-x-padding
remove x bottom padding
2020-01-21 17:01:23 -08:00
Ben Dansby
d46557e597 remove x bottom padding 2020-01-21 14:54:08 -08:00
Tessa Kelly
3ce36fe1d5 Fix test compilation 2020-01-16 13:20:14 -08:00
Tessa Kelly
a5d1f46ba3 Set the color for the select 2020-01-16 12:55:08 -08:00
Tessa Kelly
584d8a8acb Adds errored state 2020-01-16 12:46:20 -08:00
Tessa Kelly
b646916573 Adds focus style 2020-01-16 12:43:37 -08:00
Tessa Kelly
ab8df6e560 🎨 organize the select styles 2020-01-16 12:41:34 -08:00
Tessa Kelly
b6d5b413cf Adds the select arrows as part of the select background 2020-01-16 12:39:29 -08:00
Tessa Kelly
c2f0f883bd Require an id
I think, since we should label our selects, that it's not unreasonable to require an id
2020-01-16 11:56:17 -08:00
Tessa Kelly
44bbf5272a Adds initial version of svg arrows to the select module 2020-01-16 11:54:23 -08:00
Tessa Kelly
dc53c4a693 💀 remove Config from the Select API 2020-01-16 11:47:42 -08:00
Tessa Kelly
c8c2d9d875 Adds Select V7 (direct copy of V6) 2020-01-16 11:41:51 -08:00
Michael Hadley
df64c61a36
Merge pull request #440 from NoRedInk/fix-tracking-with-middle-click
Fix Tracking on Buttons using `linkExternalWithTracking`
2020-01-14 09:19:29 -08:00
Michael Hadley
8c6e3b3402 Middle clicks should also trigger tracking 2020-01-13 14:57:25 -08:00
Michael Hadley
52f6213d65 External tracking should work with ctrl/cmd- clicks
A button with `linkExternalWithTracking` was previously using
`EventExtras.onClickForLinkWithHref`, which was causing the event
handler to not be called when the user clicks on the link while
pressing cmd or ctrl. This is actually fine for tacking purposes,
as the page should still be open in the old tab, allowing the tracking
request to complete.

It's not clear why this particular event helper was used here for
the `ExternalWithTracking` case, but we can't find a downside for
swapping it out for a regular `Events.onClick`.
2020-01-13 14:41:53 -08:00
Tessa Kelly
d69eac88be Adds button resets 2020-01-07 14:26:20 -08:00
Tessa Kelly
82bd63c56d Adds the new helpers to the styleguide 2020-01-07 14:22:50 -08:00
Tessa Kelly
851dfe355e Adds rough as-link and as-button helpers 2020-01-07 14:04:30 -08:00
Aaron VonderHaar
64384d57dc
Merge pull request #437 from NoRedInk/avh4-patch-1
Corrected description for mustard color
2019-12-17 14:37:35 -08:00
Aaron VonderHaar
0216bc6dc8
Corrected description for mustard color 2019-12-17 14:28:15 -08:00
Aaron VonderHaar
33d53fc522
Merge pull request #436 from NoRedInk/release/7.17.0
Release 7.17.0
2019-12-17 13:11:41 -08:00
Aaron VonderHaar
79c9b38abc bump to 7.17.0 2019-12-17 13:03:02 -08:00
Aaron VonderHaar
597b357bef
Merge pull request #435 from NoRedInk/ink/nunu-colors
New colors
2019-12-17 13:01:40 -08:00
Aaron VonderHaar
e50450d59d Add type annotation 2019-12-17 12:57:47 -08:00
Aaron VonderHaar
457404aae0 Add mustard color (new name for yellow) 2019-12-17 12:00:29 -08:00
Aaron VonderHaar
c52199f094 Add new Text Highlight Colors 2019-12-17 11:54:35 -08:00
Ben Dansby
e37989227c
Merge pull request #434 from NoRedInk/dansby/accordion-margin
Zero margin on accordion
2019-12-16 16:16:39 -08:00
Tessa
81fd2f9bbb
Merge branch 'master' into dansby/accordion-margin 2019-12-16 15:15:15 -08:00
Tessa
745f4d0b80
Merge pull request #433 from NoRedInk/dansby/segmented-margin
Zero margin on segments
2019-12-16 15:15:00 -08:00
Ben Dansby
5c5396866c zero margin 2019-12-16 13:55:35 -08:00
Ben Dansby
b46372e5c6 zero margin on segments 2019-12-16 13:42:37 -08:00
Aaron VonderHaar
a66bee6c9a
Merge pull request #432 from NoRedInk/release/7.16.0
bump to 7.16.0
2019-12-13 17:17:05 -08:00
Aaron VonderHaar
51a4a26b25 bump to 7.16.0 2019-12-13 17:07:46 -08:00
Aaron VonderHaar
9261db6f92
Merge pull request #431 from NoRedInk/ink/new-ochre
Update ochre and add ochreDark
2019-12-13 17:04:37 -08:00
Aaron VonderHaar
370816d986 Update ochre and add ochreDark 2019-12-13 16:28:45 -08:00
Tessa
e317ce3e2a
Merge pull request #421 from NoRedInk/tessa/adds-missing-icons
Tessa/adds missing icons
2019-12-13 16:15:00 -08:00
Tessa
0c6def57dc
Merge branch 'master' into tessa/adds-missing-icons 2019-12-13 14:41:44 -08:00
Brooke
51a2b1ef89
Merge pull request #430 from NoRedInk/zamboni/small-bump
bump to 7.15
2019-12-13 11:38:44 -08:00
brookeangel
6602a8f51c bump to 7.15 2019-12-13 09:43:17 -08:00
Brooke
ea1fd63a43
Merge pull request #429 from NoRedInk/zamboni/left-align
fix text alignment and propagation when links are clicked
2019-12-09 17:19:39 -08:00
brookeangel
601ad01c85 fix text alignment and propagation when links are clicked 2019-12-09 10:37:06 -08:00